[1.10.2][UNSOLVED] Registering EntityItems with Forge

[yooksi]

I've been trying to find an efficient way of registering my custom EntityItems with Forge for a while. The problem arises when I see how the items behave when tossed and dropped in the world. The motion is way off and there is a few second delay before the items is teleported to a new location a few blocks away from where it once was. If seems like quite a high price to pay just to have them conveniently saved and loaded in your world. Did someone else encounter these issues, and is there a known way to fix this? My main question though would be, what is the proper way of registering and handling an EntityItem?

 

When I do not register the entities and manually spawn them in the world by overriding some methods. everything works fine but as I said, they are not loaded or saved from the world.

 

My current registration method is this:

EntityRegistry.registerModEntity(MyEntityItem.class, "my_entity_item, 0, MyMod.instance, 40, 40, false);

The way I am handling entity creation when using the registration method:

@Override
public boolean hasCustomEntity(ItemStack stack)
{  
    return true;
}

@Override
public Entity createEntity(World world, Entity location, ItemStack itemstack)
{
    return new MyEntityItem(world, location.posX, location.posY, location.posZ, itemstack);		
}

I've been trying to solve this problem on many ways for some time now and I am slowly loosing patience.

Any help would really be appreciated. Thank you in advance guys.

 

EDIT: changed 'hasCustomEntity' return value from false to true, thanks to larsgerrits for spotting the mistake.

[Animefan8888]

I beleive you want to copy the motion of the entity aswell as the positions.

[larsgerrits]

If

Item#hasCustomEntity

returns

false

,

Item#createEntity

is not called. Also, show your

MyEntityItem

class.

[yooksi]

  On 9/27/2016 at 1:55 PM, Animefan8888 said:

I beleive you want to copy the motion of the entity aswell as the positions.

I've tried this right now:

public Entity createEntity(World world, Entity location, ItemStack itemstack)
{
    return new MyEntityItem(world, location.posX, location.posY, location.posZ, itemstack, location.motionX, location.motionY, location.motionZ);		
}

public MyEntityItem(World worldObj, double posX, double d0, double posZ, ItemStack stack, double motionX, double motionY, double motionZ) 
{
    super(worldObj, posX, d0, posZ, stack);
}

It didn't seem to work at all. It also might be important to note that the when I register the EntityItem it requires a standard EntityItem constructor - MyEntityItem(World). Don't know if that is relevant or not but it looks like it's getting constructed twice, once with that constructor and once with my custom one. If I don't construct it with the custom one passing the location the entity just doesn't appear in the world.

[yooksi]

  On 9/27/2016 at 2:57 PM, larsgerrits said:

If

Item#hasCustomEntity

returns

false

,

Item#createEntity

is not called. Also, show your

MyEntityItem

class.

Thank you for spotting that, it was a mistake on my part when I was copy pasting. I didn't read it through enough. I've been experimenting a lot with it and I must have copied it in the stage when it said false. I am aware that it does not appear under this circumstances, the real problem appears when it does spawn. As I've said, the motion is way off and not to mention the weird teleportation effect (like some kind of lag).

[larsgerrits]

Yes, you need a standard constructor accepting a

World

as it's only argument, and pass it to it's super. This is for when the

Entity

is created from NBT e.g. loaded from a save file. If you want to spawn an

Entity

from code, use your own constructor.

 

For the motion, you never actually set the motion of the your

Entity

in your constructor.

[yooksi]

  On 9/27/2016 at 3:22 PM, larsgerrits said:

Yes, you need a standard constructor accepting a

World

as it's only argument, and pass it to it's super. This is for when the

Entity

is created from NBT e.g. loaded from a save file. If you want to spawn an

Entity

from code, use your own constructor.

 

For the motion, you never actually set the motion of the your

Entity

in your constructor.

Since I've tried setting the motion and all that in the constructor and it didn't work (or at least I don't know how to make it work), could you please explain to me how I would manually save and load the entity from NBT to and from the world (to achieve basically the same thing as the registration does, just without the whole 'setting up the motion and fixing the weird teleportation glitch' shenanigans). Also where and how would you set the basic motion to correct this? Because I've tried overriding the dropBlockAsItemWithChance and implementing my own version of spawnAsEntity where I only changed the entity construction invocation, and I also tried copying the motion formation code from several sources and placing it in createNewEntity in my custom item class and nothing worked.

[Animefan8888]

  On 9/28/2016 at 7:54 AM, yooksi said:

  Quote

Yes, you need a standard constructor accepting a

World

as it's only argument, and pass it to it's super. This is for when the

Entity

is created from NBT e.g. loaded from a save file. If you want to spawn an

Entity

from code, use your own constructor.

 

For the motion, you never actually set the motion of the your

Entity

in your constructor.

Since I've tried setting the motion and all that in the constructor and it didn't work (or at least I don't know how to make it work), could you please explain to me how I would manually save and load the entity from NBT to and from the world (to achieve basically the same thing as the registration does, just without the whole 'setting up the motion and fixing the weird teleportation glitch' shenanigans). Also where and how would you set the basic motion to correct this? Because I've tried overriding the dropBlockAsItemWithChance and implementing my own version of spawnAsEntity where I only changed the entity construction invocation, and I also tried copying the motion formation code from several sources and placing it in createNewEntity in my custom item class and nothing worked.

Does your EntityItem extend EntityItem?

[yooksi]

  On 9/28/2016 at 1:52 PM, Animefan8888 said:

  Quote

  Quote

Yes, you need a standard constructor accepting a

World

as it's only argument, and pass it to it's super. This is for when the

Entity

is created from NBT e.g. loaded from a save file. If you want to spawn an

Entity

from code, use your own constructor.

 

For the motion, you never actually set the motion of the your

Entity

in your constructor.

Since I've tried setting the motion and all that in the constructor and it didn't work (or at least I don't know how to make it work), could you please explain to me how I would manually save and load the entity from NBT to and from the world (to achieve basically the same thing as the registration does, just without the whole 'setting up the motion and fixing the weird teleportation glitch' shenanigans). Also where and how would you set the basic motion to correct this? Because I've tried overriding the dropBlockAsItemWithChance and implementing my own version of spawnAsEntity where I only changed the entity construction invocation, and I also tried copying the motion formation code from several sources and placing it in createNewEntity in my custom item class and nothing worked.

Does your EntityItem extend EntityItem?

Yes, it does.

[yooksi]

Bumpy ol' bump!

 

Can anyone help me with this issue?

[Animefan8888]

  On 10/17/2016 at 6:21 AM, yooksi said:

Bumpy ol' bump!

 

Can anyone help me with this issue?

Can we see the updated whole class?

[yooksi]

  On 10/18/2016 at 5:20 AM, Animefan8888 said:

  Quote

Bumpy ol' bump!

 

Can anyone help me with this issue?

Can we see the updated whole class?

• The main EntityItem class.
  
• Handle spawning after block break.
  
• Handling spawning after a toss event.
  

Let me know if you need me to provide more information.