Jump to content

ItemFrame Comparator Output


Recommended Posts

So I had an item in my 1.7.10 mod that told the player the current temperature and rainfall levels (as I varied these values over time, creating effective seasons) which then effected crop growth.


One of the things that was requested many many times was a way to read that same data as a redstone signal.


I did this by backporting the ItemFrame Comparator output logic via ASM, giving myself an event hook.  The default logic was to look at the item's rotation, but I was able to also provide a value based on the temp or rainfall if the item in the frame was the thermometer or hydrometer respectively.


As coremodding is so highly frowned upon, I am looking to insert this same sort of logic into the Comparator via Forge Pull Request.  However I see two possible ways of doing this...


Option 1:

Insert an event to EntityItemFrame#getAnalogOutput


Option 2:

Insert methods to the Item called...say...

hasItemFrameOutput(World, BlockPos)


getItemFrameOutput(World, BlockPos)

(also ItemStack?) which EntityItemFrame#getAnalogOutput then invokes.


Option 2 makes more sense for my use-case (my item classes would then override the methods and provide logic), but I am unsure which would be better in the general case / Forge's approach to vanilla alterations (are modders going to want to alter the behavior of a vanilla or other mod's item?).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.


Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.


DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.