MC 1.10+ Improving Worldgen

[winnetrie]

While my worldgen is working, i have the feeling something is not right.

I think the way i get the coordinates is wrong.

Why? Because i have a block that needs to be generated in river biomes, now when i dig down in a river i mostly do not find my block, but i do find my block generating the biome next to the river.

It isn't a big deal, people will still find it after all,but when i do something wrong i like to know what and how to improve it.

 

Here is my worldgen code:

 

public class ModWorldGenerator implements IWorldGenerator {

@Override
public void generate(Random random, int chunkX, int chunkZ, World world, IChunkGenerator chunkGenerator, IChunkProvider chunkProvider) {
	// TODO Auto-generated method stub
	switch(world.provider.getDimensionType())
	{
	case NETHER:
		generateNether(world, random, chunkX, chunkZ);
		break;
	case OVERWORLD:
		generateOverworld(world, random, chunkX, chunkZ);
		break;
	case THE_END:
		generateEnd(world, random, chunkX, chunkZ);
		break;
	}
}
public void generateNether(World world, Random rand, int x, int z){
	if (ModConfig.enabledemonite==true){
		generateOre(ModBlocks.demonite.getDefaultState(), world, rand, 0, x, z, 33, 66, 75, 1, 256, BlockMatcher.forBlock(Blocks.NETHERRACK));
		if (ModConfig.enablefeliron==true){
			generateSingleOre(ModBlocks.feliron.getDefaultState(), world, rand, 0, x, z, 100, 1, 256, BlockMatcher.forBlock(ModBlocks.demonite));

		}
	}
}
public void generateOverworld(World world, Random rand, int x, int z){

	int XX = x *16;
	int ZZ = z *16;
	BlockPos pos = new BlockPos(XX, 70, ZZ);
	String biome = world.getBiomeGenForCoords(pos).getBiomeName();//getWorldChunkManager().getBiomeGenAt(XX, ZZ);

	if (ModConfig.enablechalkstone==true){
		if(biome.contains("River")){
			generateOre(ModBlocks.chalkstone.getDefaultState(), world, rand, 0, x, z, 25, 33, 100, 45, 65, BlockMatcher.forBlock(Blocks.STONE));
		}
		if(biome.contains("Ocean")){
			generateOre(ModBlocks.chalkstone.getDefaultState(), world, rand, 0, x, z, 15, 33, 50, 20, 50, BlockMatcher.forBlock(Blocks.STONE));
			generateOre(ModBlocks.chalkstone.getDefaultState(), world, rand, 0, x, z, 15, 33, 50, 10, 50, BlockMatcher.forBlock(Blocks.STONE));
			generateOre(ModBlocks.chalkstone.getDefaultState(), world, rand, 0, x, z, 10, 15, 50, 30, 50, BlockMatcher.forBlock(Blocks.GRAVEL));
		}
	}
	if (ModConfig.enablemarblestone==true){
		if(biome.contains("Hills") || biome.contains("Mountain")){
			generateOre(ModBlocks.marblestone.getDefaultState(), world, rand, 0, x, z, 25, 33, 50, 65, 256, BlockMatcher.forBlock(Blocks.STONE));
		}
	}		
}
public void generateEnd(World world, Random rand, int x, int z){

}
public void generateOre(IBlockState state, World world, Random random, int meta, int chunkX, int chunkZ, int minVienSize, 
		int maxVienSize, int chance, int minY, int maxY, Predicate<IBlockState> generatedIn){
	int vienSize = minVienSize + random.nextInt(maxVienSize - minVienSize);
	int heightRange = maxY - minY + 1;
	WorldGenMinable gen = new WorldGenMinable(state,vienSize, generatedIn);
	for(int i =0; i < chance; i++){
		int xRand = chunkX * 16 + random.nextInt(16);
		int yRand = random.nextInt(heightRange) + minY;
		int zRand = chunkZ * 16 + random.nextInt(16);
		//Block testblock = world.getBlock(xRand, yRand, zRand);
		BlockPos pos = new BlockPos(xRand, yRand, zRand);	
		gen.generate(world,  random ,pos);		
	}	
}

public void generateSingleOre(IBlockState iBlockState, World world, Random random, int meta, int chunkX, int chunkZ, 
		int chance, int minY, int maxY, BlockMatcher blockMatcher){
	//int vienSize = minVienSize + random.nextInt(maxVienSize - minVienSize);
	int heightRange = maxY - minY + 1;
	WorldGenSingleMinable gen = new WorldGenSingleMinable(iBlockState, meta,  blockMatcher);
	for(int i =0; i < chance; i++){
		int xRand = chunkX * 16 + random.nextInt(16);
		int yRand = random.nextInt(heightRange) + minY;
		int zRand = chunkZ * 16 + random.nextInt(16);
		BlockPos pos = new BlockPos(xRand, yRand, zRand);
		gen.generate(world,  random, pos );	
	}	
}
}

 

[larsgerrits]

generateOre(ModBlocks.chalkstone.getDefaultState(), world, rand, 0, x, z, 25, 33, 100, 45, 65, BlockMatcher.forBlock(Blocks.STONE));

You should be using

xx

and

zz

instead of

x

and

z

.

[winnetrie]

Now it doesn't generate at all. I don't find anything.

[Matryoshika]

@larsgerrits

No, he was using it "correctly". Quotation marks as the method wants the chunk coords, but a chunk can of course contain 1-256 different biomes

 

@winnetrie

The biome next to the river... It doesn't happen to be in the same chunk? Because all you do, is say "[this chunk] has a river. Spawn [block] in this chunk. Where? Randomly."

I recommend that you change your

generateOre

to make use of a blockpos directly, or at least a regular x & z coordinate instead of chunk coords.

This way, you can more easily oversee where they spawn.

I also recommend that you instead for-loop through

BlockPos#getAllInBox(from, to)

and check if the biome is what you want, instead of randomly generating nearby, where the biome can have changed drastically, just 1 block away.

 

[winnetrie]

 

@winnetrie

The biome next to the river... It doesn't happen to be in the same chunk? Because all you do, is say "[this chunk] has a river. Spawn [block] in this chunk. Where? Randomly."

Yeah i was already aware that this could be the reason, but i didn't know an alternative or an improvement!

 

I don't know how to use the thing you say, but i will look into that later.

As i said before it isn't yet important, because it works. Improvements are for later when everything is finished.

 

Thank you very much for the info!

[jabelar]

FYI, for detecting biome at a location I think I've used this in the past:

 

worldObj.getChunkFromBlockCoords(blockpos).getBiome(blockpos, worldObj.getWorldChunkManager()).biomeName

 

I haven't tried it in 1.10.2 but I assume it would still work.