Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[SOLVED][1.10.2] Adding custom loot table to chest

JimiIT92

By JimiIT92
in Modder Support

 Share

Recommended Posts

JimiIT92 Dragon Slayer

JimiIT92

Posted
Posted

I have a structure in my world and i want to add a custom loot table to it's chests. I've tried doing this

TileEntityChest chest = (TileEntityChest)world.getTileEntity(key);
				chest.setLootTable(new ResourceLocation(MW.MODID, "pagoda_chest"), new Random().nextLong());

Where "pagoda_chest" is the json loot table file, located in the loot_tables folder in assets, but as far as i load the structure this error pops out

Couldn't load loot table mw:pagoda_chest from file:/C:/Users/Jimi/Documents/Minecraft%20Modding/MineWorld/bin/assets/mw/loot_tables/pagoda_chest.json
com.google.gson.JsonParseException: Loot Table "mw:pagoda_chest" Missing `name` entry for pool #0
at net.minecraftforge.common.ForgeHooks.readPoolName(ForgeHooks.java:1114) ~[ForgeHooks.class:?]
at net.minecraft.world.storage.loot.LootPool$Serializer.deserialize(LootPool.java:152) ~[LootPool$Serializer.class:?]
at net.minecraft.world.storage.loot.LootPool$Serializer.deserialize(LootPool.java:147) ~[LootPool$Serializer.class:?]
at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[TreeTypeAdapter.class:?]
at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40) ~[TypeAdapterRuntimeTypeWrapper.class:?]
at com.google.gson.internal.bind.ArrayTypeAdapter.read(ArrayTypeAdapter.java:72) ~[ArrayTypeAdapter.class:?]
at com.google.gson.Gson.fromJson(Gson.java:803) ~[Gson.class:?]
at com.google.gson.Gson.fromJson(Gson.java:868) ~[Gson.class:?]
at com.google.gson.Gson$1.deserialize(Gson.java:126) ~[Gson$1.class:?]
at net.minecraft.util.JsonUtils.deserializeClass(JsonUtils.java:378) ~[JsonUtils.class:?]
at net.minecraft.util.JsonUtils.deserializeClass(JsonUtils.java:400) ~[JsonUtils.class:?]
at net.minecraft.world.storage.loot.LootTable$Serializer.deserialize(LootTable.java:209) ~[LootTable$Serializer.class:?]
at net.minecraft.world.storage.loot.LootTable$Serializer.deserialize(LootTable.java:204) ~[LootTable$Serializer.class:?]
at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[TreeTypeAdapter.class:?]
at com.google.gson.Gson.fromJson(Gson.java:803) ~[Gson.class:?]
at com.google.gson.Gson.fromJson(Gson.java:768) ~[Gson.class:?]
at com.google.gson.Gson.fromJson(Gson.java:717) ~[Gson.class:?]
at com.google.gson.Gson.fromJson(Gson.java:689) ~[Gson.class:?]
at net.minecraftforge.common.ForgeHooks.loadLootTable(ForgeHooks.java:1038) ~[ForgeHooks.class:?]
at net.minecraft.world.storage.loot.LootTableManager$Loader.loadBuiltinLootTable(LootTableManager.java:148) [LootTableManager$Loader.class:?]
at net.minecraft.world.storage.loot.LootTableManager$Loader.load(LootTableManager.java:71) [LootTableManager$Loader.class:?]
at net.minecraft.world.storage.loot.LootTableManager$Loader.load(LootTableManager.java:52) [LootTableManager$Loader.class:?]
at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3524) [guava-17.0.jar:?]
at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2317) [guava-17.0.jar:?]
at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2280) [guava-17.0.jar:?]
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2195) [guava-17.0.jar:?]
at com.google.common.cache.LocalCache.get(LocalCache.java:3934) [guava-17.0.jar:?]
at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3938) [guava-17.0.jar:?]
at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4821) [guava-17.0.jar:?]
at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:4827) [guava-17.0.jar:?]
at net.minecraft.world.storage.loot.LootTableManager.getLootTableFromLocation(LootTableManager.java:39) [LootTableManager.class:?]
at net.minecraft.tileentity.TileEntityLockableLoot.fillWithLoot(TileEntityLockableLoot.java:55) [TileEntityLockableLoot.class:?]
at net.minecraft.tileentity.TileEntityChest.createContainer(TileEntityChest.java:495) [TileEntityChest.class:?]
at net.minecraft.entity.player.EntityPlayerMP.displayGUIChest(EntityPlayerMP.java:861) [EntityPlayerMP.class:?]
at net.minecraft.block.BlockChest.onBlockActivated(BlockChest.java:420) [blockChest.class:?]
at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:477) [PlayerInteractionManager.class:?]
at net.minecraft.network.NetHandlerPlayServer.processRightClickBlock(NetHandlerPlayServer.java:706) [NetHandlerPlayServer.class:?]
at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) [CPacketPlayerTryUseItemOnBlock.class:?]
at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) [CPacketPlayerTryUseItemOnBlock.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) [PacketThreadUtil$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_101]
at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_101]
at net.minecraft.util.Util.runTask(Util.java:25) [util.class:?]
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:742) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687) [MinecraftServer.class:?]
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [integratedServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536) [MinecraftServer.class:?]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_101]

 

Note that the file i use for the loot table is the exact copy of the desert pyramid chest loot table file. This is the json file

{
    "pools": [
        {
            "rolls": {
                "min": 2,
                "max": 4
            },
            "entries": [
                {
                    "type": "item",
                    "name": "minecraft:diamond",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 3
                            }
                        }
                    ],
                    "weight": 5
                },
                {
                    "type": "item",
                    "name": "minecraft:iron_ingot",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 5
                            }
                        }
                    ],
                    "weight": 15
                },
                {
                    "type": "item",
                    "name": "minecraft:gold_ingot",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 2,
                                "max": 7
                            }
                        }
                    ],
                    "weight": 15
                },
                {
                    "type": "item",
                    "name": "minecraft:emerald",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 3
                            }
                        }
                    ],
                    "weight": 15
                },
                {
                    "type": "item",
                    "name": "minecraft:bone",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 4,
                                "max": 6
                            }
                        }
                    ],
                    "weight": 25
                },
                {
                    "type": "item",
                    "name": "minecraft:spider_eye",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 3
                            }
                        }
                    ],
                    "weight": 25
                },
                {
                    "type": "item",
                    "name": "minecraft:rotten_flesh",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 3,
                                "max": 7
                            }
                        }
                    ],
                    "weight": 25
                },
                {
                    "type": "item",
                    "name": "minecraft:saddle",
                    "weight": 20
                },
                {
                    "type": "item",
                    "name": "minecraft:iron_horse_armor",
                    "weight": 15
                },
                {
                    "type": "item",
                    "name": "minecraft:golden_horse_armor",
                    "weight": 10
                },
                {
                    "type": "item",
                    "name": "minecraft:diamond_horse_armor",
                    "weight": 5
                },
                {
                    "type": "item",
                    "name": "minecraft:book",
                    "weight": 20,
                    "functions": [
                        {
                            "function": "enchant_randomly"
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:golden_apple",
                    "weight": 20
                },
                {
                    "type": "item",
                    "name": "minecraft:golden_apple",
                    "weight": 2,
                    "functions": [
                        {
                            "function": "set_data",
                            "data": 1
                        }
                    ]
                },
                {
                    "type": "empty",
                    "weight": 15
                }
            ]
        },
        {
            "rolls": 4,
            "entries": [
                {
                    "type": "item",
                    "name": "minecraft:bone",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:gunpowder",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:rotten_flesh",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:string",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:sand",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                }
            ]
        }
    ]
}

 

So how can i load this custom loot table?

Don't blame me if i always ask for your help. I just want to learn to be better :)

Draco18s Reality Controller

Draco18s

Posted
Posted

Table "mw:pagoda_chest" Missing `name` entry for pool #0

 

You need to add a "name" entry to each pool (insert it on line 4 for pool #0, for instance).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

Ok, so now i have a different error. The json file looks like this 

{
    "pools": [
        {
		"name": "pagoda",
            "rolls": {
                "min": 2,
                "max": 4
            },
            "entries": [
                {
                    "type": "item",
                    "name": "minecraft:diamond",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 3
                            }
                        }
                    ],
                    "weight": 5
                },
                {
                    "type": "item",
                    "name": "minecraft:iron_ingot",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 5
                            }
                        }
                    ],
                    "weight": 15
                },
                {
                    "type": "item",
                    "name": "minecraft:gold_ingot",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 2,
                                "max": 7
                            }
                        }
                    ],
                    "weight": 15
                },
                {
                    "type": "item",
                    "name": "minecraft:emerald",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 3
                            }
                        }
                    ],
                    "weight": 15
                },
                {
                    "type": "item",
                    "name": "minecraft:bone",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 4,
                                "max": 6
                            }
                        }
                    ],
                    "weight": 25
                },
                {
                    "type": "item",
                    "name": "minecraft:spider_eye",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 3
                            }
                        }
                    ],
                    "weight": 25
                },
                {
                    "type": "item",
                    "name": "minecraft:rotten_flesh",
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 3,
                                "max": 7
                            }
                        }
                    ],
                    "weight": 25
                },
                {
                    "type": "item",
                    "name": "minecraft:saddle",
                    "weight": 20
                },
                {
                    "type": "item",
                    "name": "minecraft:iron_horse_armor",
                    "weight": 15
                },
                {
                    "type": "item",
                    "name": "minecraft:golden_horse_armor",
                    "weight": 10
                },
                {
                    "type": "item",
                    "name": "minecraft:diamond_horse_armor",
                    "weight": 5
                },
                {
                    "type": "item",
                    "name": "minecraft:book",
                    "weight": 20,
                    "functions": [
                        {
                            "function": "enchant_randomly"
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:golden_apple",
                    "weight": 20
                },
                {
                    "type": "item",
                    "name": "minecraft:golden_apple",
                    "weight": 2,
                    "functions": [
                        {
                            "function": "set_data",
                            "data": 1
                        }
                    ]
                },
                {
                    "type": "empty",
                    "weight": 15
                }
            ]
        },
        {
            "rolls": 4,
            "entries": [
                {
                    "type": "item",
                    "name": "minecraft:bone",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:gunpowder",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:rotten_flesh",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:string",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                },
                {
                    "type": "item",
                    "name": "minecraft:sand",
                    "weight": 10,
                    "functions": [
                        {
                            "function": "set_count",
                            "count": {
                                "min": 1,
                                "max": 8
                            }
                        }
                    ]
                }
            ]
        }
    ]
}

 

And the error is this

Loot Table "mw:pagoda_chest" Duplicate entry name "minecraft:golden_apple" for pool #-1 entry #13

 

I think is related to the fact the the pool rolls for both regular golden apple and enchanted one, and i think that removing one of this will solve the problem, but if i want to keep it both how can i do?

Don't blame me if i always ask for your help. I just want to learn to be better :)

Draco18s Reality Controller

Draco18s

Posted
Posted

You have two entires named "minecraft:golden_apple"

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

Yes, as i said this is the copy of the desert pyramid loot table file, wich rolls for both regular and enchanted golden apples. Beside of this, if i want to roll for different values o a item/block, how can i do (since they'll have the same name)? For example, i want that in the chest can be Stone and Granite, both have the "minecraft:stone" id so what should i write in the loot table?

Don't blame me if i always ask for your help. I just want to learn to be better :)

Draco18s Reality Controller

Draco18s

Posted
Posted

You need to write a function conditional that sets the item metadata.

 

Having poked at the code-side of these things I only know how to set it up via code, I'm not sure what the JSON equivalent is, but functions can have a random probability applied to them and only if it returns true is the function executed.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

That's ruin a bit the loot table system. I think the easiset way to make it work is to handle the LootTableLoadEvent, in there if i load this loot table than i add the enchanted golden apple to the loot :/

PS: Can you provide me a link where is explained how to write a loot table from scratch? In this case i've copied a vanilla one but i want to understand how it exactly works (in particular pools and rolls). Thanks for your help :)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Draco18s Reality Controller

Draco18s

Posted
Posted

I have no idea.  I've only figured out how to manipulate it from the LootTableLoadEvent.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Choonster Reality Controller

Choonster

Posted
Posted (edited)

Each entry in a loot pool must have a unique name. The default name of an entry is the name of the item or loot pool that it references.

 

If you have multiple entries with the same default name, you need to set the "entryName" property of each entry to a unique name.

 

The wiki has an explanation of the vanilla loot table format here. Forge adds the requirement that each loot pool must have a unique "name" property and each loot entry must have a unique name (either the default name or the "entryName" property). These requirements don't apply to vanilla's loot tables, only to mod loot tables.

Edited by Choonster
Fixed formatting errors caused by forum migration

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

JimiIT92 Dragon Slayer

JimiIT92

Posted
  • Author
Posted

That will be much easier. So i can, for instance, have two rolls for a golden apple but in one i set an entryName:"regular" and in the other i set an entryName:"enchanted"? If so then is really good and will avoid using the LootTableLoadEvent

Don't blame me if i always ask for your help. I just want to learn to be better :)

Choonster Reality Controller

Choonster

Posted
Posted (edited)
On 2016-10-31 at 11:40 AM, JimiIT92 said:

That will be much easier. So i can, for instance, have two rolls for a golden apple but in one i set an entryName:"regular" and in the other i set an entryName:"enchanted"? If so then is really good and will avoid using the LootTableLoadEvent

 

You can have two entries for a golden apple in the same loot pool with different "entryName" properties, yes.

Edited by Choonster

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept