[SOLVED] My custom apple tree is not growing

[trollworkout]

Not with bonemeal or anything

 

My custom sapling block

 

  Reveal hidden contents

package com.technorcery.common.blocks;

import java.util.Random;

import com.technorcery.common.ModData;
import com.technorcery.common.blocks.PlankBlock.WoodType;
import com.technorcery.common.worldgen.WorldGenTree;

import net.minecraft.block.BlockBush;
import net.minecraft.block.IGrowable;
import net.minecraft.block.SoundType;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyInteger;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenerator;

public class SaplingBlock extends BlockBush implements IGrowable {
private final WoodType type;
    public static final PropertyInteger STAGE = PropertyInteger.create("stage", 0, 1);
    protected static final AxisAlignedBB SAPLING_AABB = new AxisAlignedBB(0.09999999403953552D, 0.0D, 0.09999999403953552D, 0.8999999761581421D, 0.800000011920929D, 0.8999999761581421D);
    
    public SaplingBlock(String name, WoodType type)
    {
    	this.type = type;
	this.setUnlocalizedName(name);
	this.setRegistryName(name);
        this.setSoundType(SoundType.PLANT);
        this.setHardness(0.0F);
        this.setTickRandomly(true);
        this.setDefaultState(this.blockState.getBaseState().withProperty(STAGE, Integer.valueOf(0)));
	this.setCreativeTab(ModData.CREATIVE_TAB);
    }
    
    @Override
    public void updateTick(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (!worldIn.isRemote)
        {
            super.updateTick(worldIn, pos, state, rand);

            if (worldIn.getLightFromNeighbors(pos.up()) >= 9 && rand.nextInt(7) == 0)
            {
                this.grow(worldIn, pos, state, rand);
            }
        }
    }
    
    public void grow(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (((Integer)state.getValue(STAGE)).intValue() == 0)
        {
            worldIn.setBlockState(pos, state.cycleProperty(STAGE), 4);
        }
        else
        {
            this.generateTree(worldIn, pos, state, rand);
        }
    }
    
    @SuppressWarnings("unused")
    public void generateTree(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (!net.minecraftforge.event.terraingen.TerrainGen.saplingGrowTree(worldIn, rand, pos)) return;
	WorldGenerator worldgenerator = new WorldGenTree(true, false, type);
        worldIn.setBlockState(pos, state, 4);
    }
    
    @Override
    public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos)
    {
        return SAPLING_AABB;
    }

@Override
public boolean canGrow(World worldIn, BlockPos pos, IBlockState state, boolean isClient) {
	return true;
}

@Override
public boolean canUseBonemeal(World worldIn, Random rand, BlockPos pos, IBlockState state) {
	return (double)worldIn.rand.nextFloat() < 0.45D;
}

@Override
public void grow(World worldIn, Random rand, BlockPos pos, IBlockState state) {
	this.grow(worldIn, pos, state, rand);
}


    @Override
    public IBlockState getStateFromMeta(int meta)
    {
        return this.getDefaultState().withProperty(STAGE, Integer.valueOf((meta &  >> 3));
    }

    @Override
    public int getMetaFromState(IBlockState state)
    {
        int i = 0;
        i = i | ((Integer)state.getValue(STAGE)).intValue() << 3;
        return i;
    }
    
    @Override
    protected BlockStateContainer createBlockState()
    {
        return new BlockStateContainer(this, new IProperty[] {STAGE});
    }
}

 

 

My custom tree worldgen class

 

  Reveal hidden contents

package com.technorcery.common.worldgen;

import java.util.Random;

import com.technorcery.common.ModBlocks;
import com.technorcery.common.blocks.PlankBlock.WoodType;

import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenAbstractTree;

public class WorldGenTree extends WorldGenAbstractTree {
private final WoodType type;
    private final boolean useExtraRandomHeight;

public WorldGenTree(boolean notify, boolean useExtraRandomHeightIn, WoodType type) {
	super(notify);
        this.type = type;
        this.useExtraRandomHeight = useExtraRandomHeightIn;
}

@Override
public boolean generate(World worldIn, Random rand, BlockPos position)
    {
        int i = rand.nextInt(3) + 5;
        IBlockState LOG = ModBlocks.LOG_APPLE.getDefaultState();
        IBlockState LEAF = ModBlocks.LEAF_APPLE.getDefaultState();
        
        if (type == WoodType.ELDER)
        {
        	LOG = ModBlocks.LOG_ELDER.getDefaultState();
        	LEAF = ModBlocks.LEAF_ELDER.getDefaultState();
        }

        if (this.useExtraRandomHeight)
        {
            i += rand.nextInt(2);
        }

        boolean flag = true;

        if (position.getY() >= 1 && position.getY() + i + 1 <= 256)
        {
            for (int j = position.getY(); j <= position.getY() + 1 + i; ++j)
            {
                int k = 1;

                if (j == position.getY())
                {
                    k = 0;
                }

                if (j >= position.getY() + 1 + i - 2)
                {
                    k = 2;
                }

                BlockPos.MutableBlockPos blockpos$mutableblockpos = new BlockPos.MutableBlockPos();

                for (int l = position.getX() - k; l <= position.getX() + k && flag; ++l)
                {
                    for (int i1 = position.getZ() - k; i1 <= position.getZ() + k && flag; ++i1)
                    {
                        if (j >= 0 && j < worldIn.getHeight())
                        {
                            if (!this.isReplaceable(worldIn, blockpos$mutableblockpos.setPos(l, j, i1)))
                            {
                                flag = false;
                            }
                        }
                        else
                        {
                            flag = false;
                        }
                    }
                }
            }

            if (!flag)
            {
                return false;
            }
            else
            {
                BlockPos down = position.down();
                IBlockState state = worldIn.getBlockState(down);
                boolean isSoil = state.getBlock().canSustainPlant(state, worldIn, down, net.minecraft.util.EnumFacing.UP, (net.minecraft.block.BlockSapling)Blocks.SAPLING);

                if (isSoil && position.getY() < worldIn.getHeight() - i - 1)
                {
                    state.getBlock().onPlantGrow(state, worldIn, down, position);

                    for (int i2 = position.getY() - 3 + i; i2 <= position.getY() + i; ++i2)
                    {
                        int k2 = i2 - (position.getY() + i);
                        int l2 = 1 - k2 / 2;

                        for (int i3 = position.getX() - l2; i3 <= position.getX() + l2; ++i3)
                        {
                            int j1 = i3 - position.getX();

                            for (int k1 = position.getZ() - l2; k1 <= position.getZ() + l2; ++k1)
                            {
                                int l1 = k1 - position.getZ();

                                if (Math.abs(j1) != l2 || Math.abs(l1) != l2 || rand.nextInt(2) != 0 && k2 != 0)
                                {
                                    BlockPos blockpos = new BlockPos(i3, i2, k1);
                                    IBlockState state2 = worldIn.getBlockState(blockpos);

                                    if (state2.getBlock().isAir(state2, worldIn, blockpos) || state2.getBlock().isAir(state2, worldIn, blockpos))
                                    {
                                        this.setBlockAndNotifyAdequately(worldIn, blockpos, LEAF);
                                    }
                                }
                            }
                        }
                    }

                    for (int j2 = 0; j2 < i; ++j2)
                    {
                        BlockPos upN = position.up(j2);
                        IBlockState state2 = worldIn.getBlockState(upN);

                        if (state2.getBlock().isAir(state2, worldIn, upN) || state2.getBlock().isLeaves(state2, worldIn, upN))
                        {
                            this.setBlockAndNotifyAdequately(worldIn, position.up(j2), LOG);
                        }
                    }

                    return true;
                }
                else
                {
                    return false;
                }
            }
        }
        else
        {
            return false;
        }
    }

}

 

[trollworkout]

Is it cause I need to register something? Maybe tree worldgen needs registering??

[Animefan8888]

  On 11/1/2016 at 6:35 PM, trollworkout said:

Is it cause I need to register something? Maybe tree worldgen needs registering??

Yes you need to register WorldGenerators.

[trollworkout]

But how do I register it?

 

The GameRegistry.RegisterWorldGenerator only registers IWorldGenerator and not WorldGenerator for my custom tree gen.

 

Seems other mods don't register their custom tree gen.

 

I'm thinking my problem may be somewhere else maybe my grow function in my sapling is broken.

[Animefan8888]

  On 11/1/2016 at 7:18 PM, trollworkout said:

But how do I register it?

 

The GameRegistry.RegisterWorldGenerator only registers IWorldGenerator and not WorldGenerator for my custom tree gen.

 

Seems other mods don't register their custom tree gen.

 

I'm thinking my problem may be somewhere else maybe my grow function in my sapling is broken.

Doesn't WorldGenAbstractTree implement IWorldGenerator and you never call the generation method you just create a new instance then never do anything.

[trollworkout]

WorldGenAbstractTree extends WorldGenerator

 

Nope it implements WorldGenerator not IWorldGenerator.

 

 

Whatever code I have up there it does not bonemeal and will not grow ever. There's some issue somewhere. I have a feeling the sapling is broken.

[Animefan8888]

  On 11/1/2016 at 7:29 PM, trollworkout said:

WorldGenAbstractTree extends WorldGenerator

 

Nope it implements WorldGenerator not IWorldGenerator.

And WorldGenerator implements IWorldGenerator

 

  Quote

Whatever code I have up there it does not bonemeal and will not grow ever. There's some issue somewhere. I have a feeling the sapling is broken.

 

  Quote

you never call the generation method you just create a new instance then never do anything.

Here I meant in your growTreeMethod(...).

[Animefan8888]

  On 11/1/2016 at 8:00 PM, diesieben07 said:

  Quote

And WorldGenerator implements IWorldGenerator

No, it doesn't.

Really? Wow, is IWorldGenerator just provided by forge as a better alternative? I have never looked at WorldGenerator as I have not needed it.

[larsgerrits]

IWorldGenerator

is added by Forge to make custom world generation easier. Vanilla code is generated in

BiomeDecorator

, and the custom generation is called from

Chunk#populateChunk

.

[Animefan8888]

  On 11/1/2016 at 10:04 PM, larsgerrits said:

IWorldGenerator

is added by Forge to make custom world generation easier. Vanilla code is generated in

BiomeDecorator

, and the custom generation is called from

Chunk#populateChunk

.

Good to know. Still shows that I have much more to learn.

[trollworkout]

WorldGenerator does not implements or extends anything. IWorldGenerator and WorldGenerator are not compatible.

 

 

So how do I fix my custom tree?

[trollworkout]

I figured it out guys.  I was right my sapling was incorrect.

 

Gen tree was wrong. I fixed it like so

 

  Reveal hidden contents

   public void generateTree(World worldIn, BlockPos pos, IBlockState state, Random rand)
    {
        if (!net.minecraftforge.event.terraingen.TerrainGen.saplingGrowTree(worldIn, rand, pos)) return;
	WorldGenerator worldgenerator = new WorldGenTree(true, false, type);

        IBlockState iblockstate2 = Blocks.AIR.getDefaultState();
        worldIn.setBlockState(pos, iblockstate2, 4);
        
        if (!worldgenerator.generate(worldIn, rand, pos.add(0, 0, 0)))
        {
        	 worldIn.setBlockState(pos, state, 4);
        }
    }

 

 

Note the

        IBlockState iblockstate2 = Blocks.AIR.getDefaultState();

        worldIn.setBlockState(pos, iblockstate2, 4);

       

        if (!worldgenerator.generate(worldIn, rand, pos.add(0, 0, 0)))

        {

        worldIn.setBlockState(pos, state, 4);

        }

 

seems like you need to set the state of air block to 4 before you can spawn the tree.