[1.10.2] FileNotFoundEx for native ResourceLoc, when using ResourcePack only

[Matryoshika]

Hello!

I'm making a mod that allows one to create blocks (so far) completely from json files. Very basic, nothing fancy, but valid blocks.

Models & blockstates are also handled "outside" the mod, in the config folder.

I've implemented IResourcePack, and throwing it into the List<IResourcePack> inside the Minecraft.class, during preInit. Everything works just fine, except that between Block registration (the new RegistryEvent way) & preInit, the ModelLoaderRegistry calls for "modid:models/item/<name>.json" which of course, due to the nature of this whole mod, will return a FileNotFoundException. This spams the client-side console, and that, in essence, is my issue. Unnecessary information in logs, especially when it is "fixed" just moments afterward, is detrimental.

 

What would one need to do, to stop the model from registering so soon? Or can I stop the ModelLoader from calling

modid:models/item/<block>

altogether, as that is handled separately by the ResourcePack?

Source-code can be found here: https://github.com/Matryoshika/Fabrica

 

Solved

Had to manually call

Minecraft#refreshResources()

to reload the IResourcePacks, before the ModelLoaderRegistry tries to load my models.

[Matryoshika]

  On 12/15/2016 at 2:00 AM, TheSunCat said:

@SuppressWarnings? I have never made a mod like this, but it is a cool idea.

What?

How....

Do you know how Minecraft rendering works? Cause that answer infers the opposite...

 

Basic runthrough: for every registered block (& item, but skipping that) the ModelLoaderRegistry calls

getModel()

, which goes through all ModelLoaders (Obj, B3d, DynBucket are forge added ones, then there's custom modelloaders as well of course.) Last resort is the vanilla modelloader. This calls

SimpleReloadableResourceManager#getResource()

which, when eventually here, calls

FallbackResourceManager#getResource()

, which is what is printing the

FileNotFoundException

.

 

All of these classes, are vanilla Minecraft or Forge coded. Literally outside of my domain.

 

 

Hmmm...  Now that I think about it, I should be able to intercept it in FallbackResourceManager. It is getting all IResourcePack and iterating over them. Seems that I am registering my own IResourcePack a wee bit too late. Gonna see if I can add it earlier in the process.

[Draco18s]

  On 12/15/2016 at 5:16 PM, TheSunCat said:

I was thinking of adding @SuppressWarnings before your resource registration, but it was just a guess of what might work. I see you got it working, so I am eager to download your mod when it is finished!!

 

SuppressWarnings is like ignoring that light on your dash telling you to change the oil:

The car is going to catch fire and you're just ignoring it.

 

The only reason to use SuppressWarnings is when you know that there's a particular non-critical warning being thrown and that it's not actually a problem.  It doesn't fix the problem it just says "I don't wish to be informed."

 

FileNotFound is not a warning, it's an error.  The file isn't there, it wasn't loaded.  Ignoring it won't suddenly make the file load.

[Draco18s]

  On 12/15/2016 at 6:26 PM, TheSunCat said:

because the errors are going to get fixed right afterward

 

This makes no sense.  The error is not thrown until after all the loaders have failed to load the file.  If the file is loaded at all then no error is thrown.