Jump to content

Recommended Posts

Posted

I am trying to set up a command structure that would use /myMod myNewCommand Arguments

 

It seems that I could register 1 command class that uses /myMod as its sole alias and handle various subcommands during the execution of that single super command. An example of this follows:

package kmm.TestMod.Commands;

import net.minecraft.command.CommandBase;
import net.minecraft.command.CommandException;
import net.minecraft.command.ICommandSender;
import net.minecraft.server.MinecraftServer;
import net.minecraft.world.World;

/**
*
* @author Rinzler
*/
public class CommandTester extends CommandBase {

    @Override
    public String getCommandName() {
        return "myModName";
    }

    @Override
    public String getCommandUsage(ICommandSender sender) {
        return "help";
    }

    @Override
    public void execute(MinecraftServer server, ICommandSender sender, String[] args) throws CommandException {
        //
        World world = sender.getEntityWorld();
        
        if(world.isRemote) {
            //do stuff
        } else {
            if(args[0].equals("myNewCommand1")) {
                if(args.length > 1) {
                    //do myNewCommand1 plus Arguments
                } else {
                    //do stuff for myNewCommand1 no arguments
                }                
            }
            if(args[0].equals("myNewCommand2")) {
                if(args.length > 1) {
                    //do stuff for myNewCommand2 plus arguments
                } else {
                    //do stuff for myNewCommand2 no arguments
                }
            }
            //...more commands...
        }
        
        
    }
    

}

Is there a better way of doing this such that I can use /myMod as a command opener?

Posted

Extend

CommandTreeBase

to create a command with sub-commands. Use

CommandTreeBase#addSubcommand

to add a sub-command.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

Extend

CommandTreeBase

to create a command with sub-commands. Use

CommandTreeBase#addSubcommand

to add a sub-command.

Exactly what I needed. Thanks! I have it working as I wanted now.

 

However, do I need to handle the help text for each subcommand? I can't seem to access it otherwise.

 

/help mymod gets the help text from the CommandTreeBase...but I can't seem to find the texts for the subcommands. I could just add a help argument branch for each subcommand...

 

edit: I am generating the help text by simply having

public void execute(MinecraftServer server, ICommandSender sender, String[] args) throws CommandException {
        

        if (args.length == 1 && args[0].equals("help")) {
            sender.addChatMessage(new TextComponentString(getCommandUsage(sender)));
        }
    }

in my subcommand execution. Seems to be working fine, although perhaps there is a better way.

Posted

Extend

CommandTreeBase

to create a command with sub-commands. Use

CommandTreeBase#addSubcommand

to add a sub-command.

Exactly what I needed. Thanks! I have it working as I wanted now.

 

However, do I need to handle the help text for each subcommand? I can't seem to access it otherwise.

 

/help mymod gets the help text from the CommandTreeBase...but I can't seem to find the texts for the subcommands. I could just add a help argument branch for each subcommand...

 

edit: I am generating the help text by simply having

public void execute(MinecraftServer server, ICommandSender sender, String[] args) throws CommandException {
        

        if (args.length == 1 && args[0].equals("help")) {
            sender.addChatMessage(new TextComponentString(getCommandUsage(sender)));
        }
    }

in my subcommand execution. Seems to be working fine, although perhaps there is a better way.

 

For my mod's command, I added a

help

sub-command that extends

CommandHelp

, stores the instance of the base command and overrides

CommandHelp#getCommandMap

and

CommandHelp#getSortedPossibleCommands

to return values from the base command.

 

CommandTreeBase

provides a

getCommandMap

method, but you have to implement

getSortedPossibleCommands

yourself (

CommandHelp

calls

ICommandManager#getPossibleCommands

and sorts the result).

 

You can see the base command here and the

help

sub-command here.

 

Unfortunately this prints the vanilla header (which says

/help

instead of

/testmod3 help

), but you'd need to re-implement

CommandHelp#execute

yourself to get around this.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

Extend

CommandTreeBase

to create a command with sub-commands. Use

CommandTreeBase#addSubcommand

to add a sub-command.

Exactly what I needed. Thanks! I have it working as I wanted now.

 

However, do I need to handle the help text for each subcommand? I can't seem to access it otherwise.

 

/help mymod gets the help text from the CommandTreeBase...but I can't seem to find the texts for the subcommands. I could just add a help argument branch for each subcommand...

 

edit: I am generating the help text by simply having

public void execute(MinecraftServer server, ICommandSender sender, String[] args) throws CommandException {
        

        if (args.length == 1 && args[0].equals("help")) {
            sender.addChatMessage(new TextComponentString(getCommandUsage(sender)));
        }
    }

in my subcommand execution. Seems to be working fine, although perhaps there is a better way.

 

For my mod's command, I added a

help

sub-command that extends

CommandHelp

, stores the instance of the base command and overrides

CommandHelp#getCommandMap

and

CommandHelp#getSortedPossibleCommands

to return values from the base command.

 

CommandTreeBase

provides a

getCommandMap

method, but you have to implement

getSortedPossibleCommands

yourself (

CommandHelp

calls

ICommandManager#getPossibleCommands

and sorts the result).

 

You can see the base command here and the

help

sub-command here.

 

Unfortunately this prints the vanilla header (which says

/help

instead of

/testmod3 help

), but you'd need to re-implement

CommandHelp#execute

yourself to get around this.

 

For the help files I am now using

if (args.length == 1 && args[0].equals("help")) {
      throw new WrongUsageException("commands.testmod.command1.usage", new Object[0]);
      //TextComponentTranslation tct = new TextComponentTranslation("commands.testmod.command1.usage", new Object[0]);
      //sender.addChatMessage(tct);
}

 

Seems to work fine. Both the WrongUsageException and the TextComponentTranslation are working to get the string from the lang file.

Posted

Or rather: varargs is syntactic sugar that allows the compiler to automatically wrap the parameters in a

new Object[]

for you. This includes 0 extra arguments.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

I like Syntactic Sugar. It reminds me of the flavor of my tears when sitting through Data Structures and Algorithms a couple years ago.

 

Trust me, I learned more about data structures and algorithms from modding Minecraft than I ever did in college.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.