[Solved][1.10] Get Meta from Block for ItemStack

[Seriak]

I'm trying to update a mod from 1.7.10, I have an item that when you right click on a block it checks the players inventory for more of that block and adds them in a line.

 

Its working fine for stone, white wool, etc, anything with a meta value of 0/default state.

 

How can I create an item stack of colored wool, stained glass, etc from a block in the world, onItemUse? or how can I get the actual meta int?

[Lambda]

Some code would be nice, to tell us how your doing it in the first place..

[Seriak]

This is the code I had before

public boolean onItemUse(ItemStack stack, EntityPlayer player, World world, int x, int y, int z, int side,
	float xOff, float yOff, float zOff)
{
	int  = 0, yD = 0, zD = 0;
	switch (side){
	case 0: yD = -1; break; case 2: zD = -1; break; case 4:  = -1; break;
	case 1: yD =  1; break; case 3: zD =  1; break; case 5:  =  1; break;}

	int len = (player.isSneaking()) ? sneakLength : length;
	Block block = world.getBlock(x, y, z);
	int meta = world.getBlockMetadata(x, y, z);

	for (int i = 1; i <= len; i++)
	{
		Block b = world.getBlock(x + i * , y + i * yD, z + i * zD);
		if ( ( ( (b == Blocks.air) || (b == Blocks.water) || (b == Blocks.flowing_water) ||
			(b == Blocks.lava) || (b == Blocks.flowing_lava) ) ) &&
			( (player.capabilities.isCreativeMode) ||
			(player.inventory.consumeInventoryItem(Item.getItemFromBlock(block))) ) )
		{
			world.setBlock(x + i * , y + i * yD, z + i * zD, block);
			if (block instanceof SecurityWall) ((SecurityWall)block).onBlockPlacedBy(
				world, x + i * , y + i * yD, z + i * zD, player, stack);
			if (meta != 0) world.setBlockMetadataWithNotify(x + i * , y + i * yD, z + i * zD, meta, 0);
			stack.damageItem(1, player);
		}
		else
		{
			return true;
		}
	}

	if ((side == 1) && (player.posX > x) && (player.posX < x+1) && (player.posZ > z) && (player.posZ < z+1) &&
		(player.posY > y) && (player.posX < y+1)) player.posY += (player.isSneaking()) ? sneakLength : length;

	return true;
}	
}

and this is the code now

public EnumActionResult onItemUse(ItemStack stack, EntityPlayer player, World world, BlockPos pos, EnumHand hand,
	EnumFacing facing, float hitX, float hitY, float hitZ)
    {		
	int  = 0, yD = 0, zD = 0;
	switch (facing) 
	{   case WEST:  = -1; break;	case DOWN: yD = -1; break;	case NORTH: zD = -1; break;
		case EAST:  = 1; break;	case UP: yD = 1; break;		case SOUTH: zD = 1; break;}

	for (int i = 1; i <= (player.isSneaking() ? length / 2 : length); i++)
	{
		Block block = world.getBlockState(new BlockPos(pos.getX() + i * , pos.getY() + i * yD, pos.getZ() + i * zD)).getBlock();

		if ((((block == Blocks.AIR) || (block == Blocks.WATER) || (block == Blocks.FLOWING_WATER) || (block == Blocks.LAVA) || (block == Blocks.FLOWING_LAVA))) &&
			((player.capabilities.isCreativeMode) || (RemoveItemFromInventory(player, world.getBlockState(pos)))))
		{
			stack.damageItem(1, player);
			world.setBlockState(new BlockPos(pos.getX() + i * , pos.getY()+ i * yD, pos.getZ() + i * zD), world.getBlockState(pos));
			//if (block instanceof SecurityWall) ((SecurityWall)block).onBlockPlacedBy(world, pos.getX() + i * , pos.getY() + i * yD, pos.getZ() + i * zD, player, stack);
		}
		else break;
	}

	if ((facing == EnumFacing.UP) && (player.posX > pos.getX()) && (player.posX < pos.getX()+1) && (player.posZ > pos.getZ()) && (player.posZ < pos.getZ()+1) &&
		(player.posY > pos.getY()) && (player.posX < pos.getY()+3)) player.posY += (player.isSneaking()) ? length / 2 : length;

	return EnumActionResult.SUCCESS;
}	
private boolean RemoveItemFromInventory(EntityPlayer player, IBlockState block)
{
	int slot = player.inventory.getSlotFor(new ItemStack(block.getBlock()));
	if (slot == -1) return false;

	ItemStack stack = player.inventory.getStackInSlot(slot);
	--stack.stackSize;
	if (stack.stackSize == 0) player.inventory.removeStackFromSlot(slot);
	return true;
}

[Lambda]

Edit this to your needs, I believe it works. Post back if it doesn't.

 

            IBlockState state = world.getBlockState(new BlockPos(pos.getX() + i * , pos.getY() + i * yD, pos.getZ() + i * zD));
            Block block = state.getBlock();
            int meta = block.getMetaFromState(state);

          world.setBlockState(new BlockPos(pos.getX() + i * , pos.getY()+ i * yD, pos.getZ() + i * zD), world.getBlockState(pos), meta);

 

The

World#setBlockState

has 2 methods, one that takes the BlockPos and the new state, and one that takes BlockPos, new state, and 'flags', which has yet to be localized to 'meta' I believe.

[Draco18s]

  On 1/6/2017 at 5:40 AM, Lambda said:

and 'flags', which has yet to be localized to 'meta' I believe.

 

No.

 

Absolutely not.

 

"Flags" is documented quite well.

 

  Quote

    /**
     * Sets the block state at a given location. Flag 1 will cause a block update. Flag 2 will send the change to
     * clients (you almost always want this). Flag 4 prevents the block from being re-rendered, if this is a client
     * world. Flags can be added together.
     */
    public boolean setBlockState(BlockPos pos, IBlockState newState, int flags)

[Lambda]

Ah, didn't see that! Thanks for that..

 

Edit: So is there even a way to set meta to a block / state any more? I don't see any methods that actually change the meta of the block.

[Choonster]

  On 1/6/2017 at 5:48 AM, Lambda said:

Ah, didn't see that! Thanks for that..

 

Edit: So is there even a way to set meta to a block / state any more? I don't see any methods that actually change the meta of the block.

 

World#setBlockState

sets the

IBlockState

at the specified position, which includes the

Block

and any properties that are saved to metadata. You can read more on this here.

 

Use

Block#getStateForPlacement(World, BlockPos, EnumFacing, float, float, float, int, EntityLivingBase, EnumHand)

to get the

IBlockState

that would be placed by an entity's held item.

[Seriak]

I think I'm all set now. Thanks for pointing me in the right direction. This is what I ended up with:

 

Excerpt

Block selectedBlock = world.getBlockState(pos).getBlock();
	int meta = selectedBlock.damageDropped(world.getBlockState(pos));
	ItemStack blockStack = new ItemStack(world.getBlockState(pos).getBlock(), 1, meta);

 

Full methods

@Override
public EnumActionResult onItemUse(ItemStack stack, EntityPlayer player, World world, BlockPos pos, EnumHand hand,
	EnumFacing facing, float hitX, float hitY, float hitZ)
    {		
	int  = 0, yD = 0, zD = 0;
	switch (facing) 
	{   case WEST:  = -1; break;	case DOWN: yD = -1; break;	case NORTH: zD = -1; break;
		case EAST:  = 1; break;	case UP: yD = 1; break;		case SOUTH: zD = 1; break;}

	for (int i = 1; i <= (player.isSneaking() ? length / 2 : length); i++)
	{
		Block block = world.getBlockState(new BlockPos(pos.getX() + i * , pos.getY() + i * yD, pos.getZ() + i * zD)).getBlock();

		if ((((block == Blocks.AIR) || (block == Blocks.WATER) || (block == Blocks.FLOWING_WATER) || (block == Blocks.LAVA) || (block == Blocks.FLOWING_LAVA))) &&
			((player.capabilities.isCreativeMode) || (RemoveItemFromInventory(player, world, pos))))
		{
			stack.damageItem(1, player);
			world.setBlockState(new BlockPos(pos.getX() + i * , pos.getY()+ i * yD, pos.getZ() + i * zD), world.getBlockState(pos));
			//if (block instanceof SecurityWall) ((SecurityWall)block).onBlockPlacedBy(world, pos.getX() + i * , pos.getY() + i * yD, pos.getZ() + i * zD, player, stack);
		}
		else break;
	}

	if ((facing == EnumFacing.UP) && (player.posX > pos.getX()) && (player.posX < pos.getX()+1) && (player.posZ > pos.getZ()) && (player.posZ < pos.getZ()+1) &&
		(player.posY > pos.getY()) && (player.posX < pos.getY()+3)) player.posY += (player.isSneaking()) ? length / 2 : length;

	return EnumActionResult.SUCCESS;
}	
private boolean RemoveItemFromInventory(EntityPlayer player, World world, BlockPos pos)
{
	Block selectedBlock = world.getBlockState(pos).getBlock();
	int meta = selectedBlock.damageDropped(world.getBlockState(pos));
	ItemStack blockStack = new ItemStack(world.getBlockState(pos).getBlock(), 1, meta);

	int slot = player.inventory.getSlotFor(blockStack);
	if (slot != -1)
	{
		ItemStack stack = player.inventory.getStackInSlot(slot);
		if (--stack.stackSize == 0) player.inventory.removeStackFromSlot(slot);
		return true;
	}
	else return false;
}