Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.11.2 | Solved] Crashes on Right Clicking a Block

Tony_The_Tiger

By Tony_The_Tiger
in Modder Support

 Share

Recommended Posts

Tony_The_Tiger Tree Puncher

Tony_The_Tiger

Posted
Posted

So I've been trying to make a block that contains an input and output (2 items). Honestly not sure what to do at this point. Any help would be appreciated!

 

ContainerBlockTileEntity

 

package com.TonyTiger.simplecoins.guicontainer;

import com.TonyTiger.simplecoins.TileEntity.MintTileEntity;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemStack;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class ContainerMintTileEntity extends Container {

private MintTileEntity te;
protected World worldObj;
protected BlockPos pos;

/*
 * SLOTS:
 * 
 * Input 0 ........ 0
 * Output 1 ........ 1
 * Player Inventory 9-35 .. 2  - 28
 * Player Inventory 0-8 ... 29 - 37
 */

public MintTileEntity getMintTileEntity(){
	return te;
}

public ContainerMintTileEntity(IInventory playerInv, MintTileEntity inte){
	te = inte;
	worldObj = inte.getWorld();
	pos = inte.getPos();

	//Tile slot input
	this.addSlotToContainer(new Slot(te,0,252,63));

	//Tile slot output
	this.addSlotToContainer(new Slot(te,1,482,63));

	// Player Inventory, Slot 9-35, Slot IDs 2  - 28
    for (int y = 0; y < 3; ++y) {
        for (int x = 0; x < 9; ++x) {
            this.addSlotToContainer(new Slot(playerInv, x + y * 9 + 2, 32 + x * 72, 171 + y * 72));
        }
    }

    // Player Inventory, Slot 0-8, Slot IDs 29 - 37
    for (int x = 0; x < 9; ++x) {
        this.addSlotToContainer(new Slot(playerInv, x, 8 + x * 72, 403));
    }
}

@Override
public boolean canInteractWith(EntityPlayer playerIn) {
	return te.isUsableByPlayer(playerIn);
}

@Override
public ItemStack transferStackInSlot(EntityPlayer playerIn, int fromSlot) {
    ItemStack previous = null;
    Slot slot = (Slot) this.inventorySlots.get(fromSlot);

    if (slot != null && slot.getHasStack()) {
        ItemStack current = slot.getStack();
        previous = current.copy();

        if (fromSlot < 2) {
            // From TE Inventory to Player Inventory
            if (!this.mergeItemStack(current, 2, 37, true))
                return null;
        }else{
            // From Player Inventory to TE Inventory
            if (!this.mergeItemStack(current, 0, 1, false))
                return null;
        }
        
        if (current.getCount() == 0)
            slot.putStack((ItemStack) null);
        else
            slot.onSlotChanged();

        if (current.getCount() == previous.getCount())
            return null;
        slot.onTake(playerIn, current);
    }
    return previous;
}

}

 

 

GuiBlockTileEntity

 

package com.TonyTiger.simplecoins.client.gui;

import com.TonyTiger.simplecoins.TileEntity.MintTileEntity;
import com.TonyTiger.simplecoins.guicontainer.ContainerMintTileEntity;

import net.minecraft.client.gui.Gui;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.inventory.IInventory;
import net.minecraft.util.ResourceLocation;

public class GuiMintTileEntity extends GuiContainer{

private IInventory playerInv;
private MintTileEntity te;

public GuiMintTileEntity(IInventory playerInv, MintTileEntity te){
	super(new ContainerMintTileEntity(playerInv,te));
	this.te = te;
	this.playerInv = playerInv;
	this.xSize = 704;
	this.ySize = 499;
}
@Override
protected void drawGuiContainerBackgroundLayer(float f, int mousex, int mousey) {
	GlStateManager.color(1.0f,1.0f,1.0f,1.0f);
	this.mc.getTextureManager().bindTexture(new ResourceLocation("simplecoins:textures/gui/container/mint.png"));
	Gui.drawModalRectWithCustomSizedTexture(this.guiLeft, this.guiTop, 
			0, 0, xSize, ySize, xSize, ySize);
//		this.fontRendererObj.drawString("Mint", 10, 10, 1, true);

}

@Override
protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY) {
    String s = this.te.getDisplayName().getUnformattedText();
    this.fontRendererObj.drawString(s, 88 - this.fontRendererObj.getStringWidth(s) / 2, 6, 4210752);            //#404040
    this.fontRendererObj.drawString(this.playerInv.getDisplayName().getUnformattedText(), 8, 72, 4210752);      //#404040
}

}

 

 

Block

 

package com.TonyTiger.simplecoins.block;

import com.TonyTiger.simplecoins.Main;
import com.TonyTiger.simplecoins.TileEntity.MintTileEntity;
import com.TonyTiger.simplecoins.network.ModGuiHandler;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.InventoryHelper;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class MintBlock extends Block{

public final static String modid = Main.MODID;

public MintBlock(String unlocalizedName, Material material, float hardness, float resistance){
	super(material);

	this.setSoundType(SoundType.METAL);
	this.setUnlocalizedName(unlocalizedName);
	this.setHarvestLevel("pickaxe",0);
	this.setCreativeTab(CreativeTabs.MISC);
	this.setResistance(resistance);
	this.setHardness(hardness);
	this.setRegistryName(modid, unlocalizedName);

}
public MintBlock(String unlocalizedName, float hardness, float resistance) {
        this(unlocalizedName, Material.IRON, hardness, resistance);
    }

    public MintBlock(String unlocalizedName) {
        this(unlocalizedName, 2.0f, 10.0f);   
    }
    @Override
    public boolean hasTileEntity(IBlockState state){
    	return true;
    }
@Override
public TileEntity createTileEntity(World worldIn, IBlockState state) {
	return new MintTileEntity();
}
@Override
public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, 
		EntityPlayer player, EnumHand hand, EnumFacing side, float hitX, float hitY, float hitZ) {
	if(!world.isRemote)
        player.openGui(Main.instance, ModGuiHandler.MOD_TILE_ENTITY_GUI, world, pos.getX(), pos.getY(), pos.getZ());
	return true;
}

@Override
public void breakBlock(World world, BlockPos pos, IBlockState blockstate){
    MintTileEntity te = (MintTileEntity) world.getTileEntity(pos);
    InventoryHelper.dropInventoryItems(world, pos, te);
    super.breakBlock(world, pos, blockstate);
}

@Override
public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
    if (stack.hasDisplayName()) {
        ((MintTileEntity) worldIn.getTileEntity(pos)).setCustomName(stack.getDisplayName());
    }
}

}

 

 

GuiHandler

 

package com.TonyTiger.simplecoins.network;

import com.TonyTiger.simplecoins.TileEntity.MintTileEntity;
import com.TonyTiger.simplecoins.client.gui.GuiMintTileEntity;
import com.TonyTiger.simplecoins.guicontainer.ContainerMintTileEntity;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.network.IGuiHandler;

public class ModGuiHandler implements IGuiHandler {

public static final int MOD_TILE_ENTITY_GUI = 0;

@Override
public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
    if (ID == MOD_TILE_ENTITY_GUI)
        return new ContainerMintTileEntity(player.inventory, (MintTileEntity) world.getTileEntity(new BlockPos(x, y, z)));

    return null;
}

@Override
public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
    if (ID == MOD_TILE_ENTITY_GUI)
        return new GuiMintTileEntity(player.inventory, (MintTileEntity) world.getTileEntity(new BlockPos(x, y, z)));

    return null;
}

}

 

 

BlockTileEntity

 

package com.TonyTiger.simplecoins.TileEntity;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ITickable;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.TextComponentString;
import net.minecraft.util.text.TextComponentTranslation;

public class MintTileEntity extends TileEntity implements ITickable, IInventory {
    
    private ItemStack[] inventory;
    private String customName;

    public MintTileEntity(){
    	this.inventory = new ItemStack[this.getSizeInventory()];
    }
    
    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound nbt){
    	super.writeToNBT(nbt);

        NBTTagList list = new NBTTagList();
        for (int i = 0; i < this.getSizeInventory(); ++i) {
            if (this.getStackInSlot(i) != null) {
                NBTTagCompound stackTag = new NBTTagCompound();
                stackTag.setByte("Slot", (byte) i);
                this.getStackInSlot(i).writeToNBT(stackTag);
                list.appendTag(stackTag);
            }
        }
        nbt.setTag("Items", list);

        if (this.hasCustomName()) {
            nbt.setString("CustomName", this.getCustomName());
        }
        
        return nbt;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
    	super.readFromNBT(nbt);

        NBTTagList list = nbt.getTagList("Items", 10);
        for (int i = 0; i < list.tagCount(); ++i) {
            NBTTagCompound stackTag = list.getCompoundTagAt(i);
            int slot = stackTag.getByte("Slot") & 255;
            // Was formerly ItemStack.loadItemStackFromNBT(stackTag)
            this.setInventorySlotContents(slot, new ItemStack(stackTag));
        }

        if (nbt.hasKey(this.getCustomName(), ) {
            this.setCustomName(nbt.getString(this.getCustomName()));
        }
    }
    
    @Override
    public NBTTagCompound getUpdateTag()
    {
        return writeToNBT(new NBTTagCompound());
    }

@Override
public void update() {

}

public String getCustomName() {
        return this.customName;
    }

    public void setCustomName(String customName) {
        this.customName = customName;
    }

@Override
public String getName() {
	return this.hasCustomName() ? this.customName : "container.simplecoins_tile_entity";
}

@Override
public boolean hasCustomName() {
	return this.customName != null && !this.customName.equals("");
}

@Override
public ITextComponent getDisplayName() {
    return this.hasCustomName() ? new TextComponentString(this.getName()) : new TextComponentTranslation(this.getName());
}

@Override
public void clear() {
	for (int i = 0; i < this.getSizeInventory(); i++)
        this.setInventorySlotContents(i, null);
}

@Override
public void closeInventory(EntityPlayer arg0){}

@Override
public ItemStack decrStackSize(int index, int count) {
	if (this.getStackInSlot(index) != null) {
        ItemStack itemstack;

        if (this.getStackInSlot(index).getCount() <= count) {
            itemstack = this.getStackInSlot(index);
            this.setInventorySlotContents(index, null);
            this.markDirty();
            return itemstack;
        } else {
            itemstack = this.getStackInSlot(index).splitStack(count);

            if (this.getStackInSlot(index).getCount() <= 0) {
                this.setInventorySlotContents(index, null);
            } else {
                //Just to show that changes happened
                this.setInventorySlotContents(index, this.getStackInSlot(index));
            }

            this.markDirty();
            return itemstack;
        }
    } else {
        return null;
    }
}

@Override
public int getField(int arg0) {
	return 0;
}

@Override
public int getFieldCount() {
	return 0;
}

@Override
public int getInventoryStackLimit() {
	return 64;
}

@Override
public int getSizeInventory() {
	return 2;
}

@Override
public ItemStack getStackInSlot(int index) {
	if (index < 0 || index >= this.getSizeInventory())
        return null;
    return this.inventory[index];
}

@Override
public boolean isEmpty() {
	if(inventory.equals(null))
		return true;
	for(ItemStack is : inventory){
		if(is.equals(null) && is.getCount() == 0)
			return true;
	}
	return false;
}

@Override
public boolean isItemValidForSlot(int arg0, ItemStack arg1) {
	return true;
}

@Override
public boolean isUsableByPlayer(EntityPlayer player) {
	return this.getWorld().getTileEntity(this.getPos()) == this 
	&& player.getDistanceSq(this.pos.add(0.5, 0.5, 0.5)) <= 64;
}

@Override
public void openInventory(EntityPlayer arg0){}

//Was formerly getStackInSlotOnClosing(int index)
@Override
public ItemStack removeStackFromSlot(int index){
	ItemStack stack = this.getStackInSlot(index);
    this.setInventorySlotContents(index, null);
    return stack;
}

@Override
public void setField(int arg0, int arg1) {	
}

@Override
public void setInventorySlotContents(int index, ItemStack stack) {
	if (index < 0 || index >= this.getSizeInventory())
        return;

    if (stack != null && stack.getCount() > this.getInventoryStackLimit())
        stack.setCount(this.getInventoryStackLimit());
        
    if (stack != null && stack.getCount() == 0)
        stack = null;

    this.inventory[index] = stack;
    this.markDirty();
}

}

 

 

BlockTileEntities

 

package com.TonyTiger.simplecoins.TileEntity;

import java.util.ArrayList;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ITickable;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.TextComponentString;
import net.minecraft.util.text.TextComponentTranslation;

public class MintTileEntity extends TileEntity implements ITickable, IInventory {
    
    private ItemStack anItemStack;
    private ArrayList aList = new ArrayList();
    
    private ItemStack[] inventory;
    private String customName;

    public MintTileEntity(){
    	this.inventory = new ItemStack[this.getSizeInventory()];
    }
    
    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound nbt){
    	super.writeToNBT(nbt);

        NBTTagList list = new NBTTagList();
        for (int i = 0; i < this.getSizeInventory(); ++i) {
            if (this.getStackInSlot(i) != null) {
                NBTTagCompound stackTag = new NBTTagCompound();
                stackTag.setByte("Slot", (byte) i);
                this.getStackInSlot(i).writeToNBT(stackTag);
                list.appendTag(stackTag);
            }
        }
        nbt.setTag("Items", list);

        if (this.hasCustomName()) {
            nbt.setString("CustomName", this.getCustomName());
        }
        
        return nbt;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
    	super.readFromNBT(nbt);

        NBTTagList list = nbt.getTagList("Items", 10);
        for (int i = 0; i < list.tagCount(); ++i) {
            NBTTagCompound stackTag = list.getCompoundTagAt(i);
            int slot = stackTag.getByte("Slot") & 255;
            // Was formerly ItemStack.loadItemStackFromNBT(stackTag)
            this.setInventorySlotContents(slot, new ItemStack(stackTag));
        }

        if (nbt.hasKey(this.getCustomName(), ) {
            this.setCustomName(nbt.getString(this.getCustomName()));
        }
    }
    
    @Override
    public NBTTagCompound getUpdateTag()
    {
        return writeToNBT(new NBTTagCompound());
    }

@Override
public void update() {

}

public String getCustomName() {
        return this.customName;
    }

    public void setCustomName(String customName) {
        this.customName = customName;
    }

@Override
public String getName() {
	return this.hasCustomName() ? this.customName : "container.simplecoins_tile_entity";
}

@Override
public boolean hasCustomName() {
	return this.customName != null && !this.customName.equals("");
}

@Override
public ITextComponent getDisplayName() {
    return this.hasCustomName() ? new TextComponentString(this.getName()) : new TextComponentTranslation(this.getName());
}

@Override
public void clear() {
	for (int i = 0; i < this.getSizeInventory(); i++)
        this.setInventorySlotContents(i, null);
}

@Override
public void closeInventory(EntityPlayer arg0){}

@Override
public ItemStack decrStackSize(int index, int count) {
	if (this.getStackInSlot(index) != null) {
        ItemStack itemstack;

        if (this.getStackInSlot(index).getCount() <= count) {
            itemstack = this.getStackInSlot(index);
            this.setInventorySlotContents(index, null);
            this.markDirty();
            return itemstack;
        } else {
            itemstack = this.getStackInSlot(index).splitStack(count);

            if (this.getStackInSlot(index).getCount() <= 0) {
                this.setInventorySlotContents(index, null);
            } else {
                //Just to show that changes happened
                this.setInventorySlotContents(index, this.getStackInSlot(index));
            }

            this.markDirty();
            return itemstack;
        }
    } else {
        return null;
    }
}

@Override
public int getField(int arg0) {
	return 0;
}

@Override
public int getFieldCount() {
	return 0;
}

@Override
public int getInventoryStackLimit() {
	return 64;
}

@Override
public int getSizeInventory() {
	return 2;
}

@Override
public ItemStack getStackInSlot(int index) {
	if (index < 0 || index >= this.getSizeInventory())
        return null;
    return this.inventory[index];
}

@Override
public boolean isEmpty() {
	if(inventory.equals(null))
		return true;
	for(ItemStack is : inventory){
		if(is.equals(null) && is.getCount() == 0)
			return true;
	}
	return false;
}

@Override
public boolean isItemValidForSlot(int arg0, ItemStack arg1) {
	return true;
}

@Override
public boolean isUsableByPlayer(EntityPlayer player) {
	return this.getWorld().getTileEntity(this.getPos()) == this 
	&& player.getDistanceSq(this.pos.add(0.5, 0.5, 0.5)) <= 64;
}

@Override
public void openInventory(EntityPlayer arg0){}

//Was formerly getStackInSlotOnClosing(int index)
@Override
public ItemStack removeStackFromSlot(int index){
	ItemStack stack = this.getStackInSlot(index);
    this.setInventorySlotContents(index, null);
    return stack;
}

@Override
public void setField(int arg0, int arg1) {	
}

@Override
public void setInventorySlotContents(int index, ItemStack stack) {
	if (index < 0 || index >= this.getSizeInventory())
        return;

    if (stack != null && stack.getCount() > this.getInventoryStackLimit())
        stack.setCount(this.getInventoryStackLimit());
        
    if (stack != null && stack.getCount() == 0)
        stack = null;

    this.inventory[index] = stack;
    this.markDirty();
}

}

 

 

Crash Report

 

---- Minecraft Crash Report ----
// I feel sad now 

Time: 1/9/17 4:10 PM
Description: Ticking player

java.lang.NullPointerException: Ticking player
at net.minecraft.item.ItemStack.areItemStacksEqual(ItemStack.java:376)
at net.minecraft.inventory.Container.detectAndSendChanges(Container.java:78)
at net.minecraft.entity.player.EntityPlayerMP.onUpdate(EntityPlayerMP.java:280)
at net.minecraft.world.World.updateEntityWithOptionalForce(World.java:1961)
at net.minecraft.world.WorldServer.updateEntityWithOptionalForce(WorldServer.java:840)
at net.minecraft.world.World.updateEntity(World.java:1931)
at net.minecraft.world.WorldServer.tickPlayers(WorldServer.java:650)
at net.minecraft.world.World.updateEntities(World.java:1723)
at net.minecraft.world.WorldServer.updateEntities(WorldServer.java:621)
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:720)
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:624)
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:149)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482)
at java.lang.Thread.run(Unknown Source)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Server thread
Stacktrace:
at net.minecraft.item.ItemStack.areItemStacksEqual(ItemStack.java:376)
at net.minecraft.inventory.Container.detectAndSendChanges(Container.java:78)
at net.minecraft.entity.player.EntityPlayerMP.onUpdate(EntityPlayerMP.java:280)
at net.minecraft.world.World.updateEntityWithOptionalForce(World.java:1961)
at net.minecraft.world.WorldServer.updateEntityWithOptionalForce(WorldServer.java:840)
at net.minecraft.world.World.updateEntity(World.java:1931)

-- Player being ticked --
Details:
Entity Type: null (net.minecraft.entity.player.EntityPlayerMP)
Entity ID: 22
Entity Name: Tony_De_Tiger
Entity's Exact location: -150.50, 4.00, 858.50
Entity's Block location: World: (-151,4,858), Chunk: (at 9,0,10 in -10,53; contains blocks -160,0,848 to -145,255,863), Region: (-1,1; contains chunks -32,32 to -1,63, blocks -512,0,512 to -1,255,1023)
Entity's Momentum: 0.00, -0.08, 0.00
Entity's Passengers: []
Entity's Vehicle: ~~ERROR~~ NullPointerException: null
Stacktrace:
at net.minecraft.world.WorldServer.tickPlayers(WorldServer.java:650)
at net.minecraft.world.World.updateEntities(World.java:1723)
at net.minecraft.world.WorldServer.updateEntities(WorldServer.java:621)

-- Affected level --
Details:
Level name: New World
All players: 1 total; [EntityPlayerMP['Tony_De_Tiger'/22, l='New World', x=-150.50, y=4.00, z=858.50]]
Chunk stats: ServerChunkCache: 256 Drop: 0
Level seed: 4065143544568251499
Level generator: ID 01 - flat, ver 0. Features enabled: true
Level generator options: 
Level spawn location: World: (-142,4,865), Chunk: (at 2,0,1 in -9,54; contains blocks -144,0,864 to -129,255,879), Region: (-1,1; contains chunks -32,32 to -1,63, blocks -512,0,512 to -1,255,1023)
Level time: 957 game time, 957 day time
Level dimension: 0
Level storage version: 0x04ABD - Anvil
Level weather: Rain time: 159140 (now: false), thunder time: 42575 (now: false)
Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: true
Stacktrace:
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:720)
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:624)
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:149)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482)
at java.lang.Thread.run(Unknown Source)

-- System Details --
Details:
Minecraft Version: 1.11.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_111, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 248812296 bytes (237 MB) / 500170752 bytes (477 MB) up to 928514048 bytes (885 MB)
JVM Flags: 0 total; 
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
FML: MCP 9.38 Powered by Forge 13.20.0.2205 6 mods loaded, 6 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
UCHIJAAAA	minecraft{1.11.2} [Minecraft] (minecraft.jar) 
UCHIJAAAA	mcp{9.19} [Minecraft Coder Pack] (minecraft.jar) 
UCHIJAAAA	FML{8.0.99.99} [Forge Mod Loader] (forgeBin-1.11.2-13.20.0.2205.jar) 
UCHIJAAAA	forge{13.20.0.2205} [Minecraft Forge] (forgeBin-1.11.2-13.20.0.2205.jar) 
UCHIJAAAA	simplecoins{0.2.0} [simple Coins mod] (bin) 
UCHIJAAAA	examplemod{1.0} [Example Mod] (bin) 
Loaded coremods (and transformers): 
GL info: ~~ERROR~~ RuntimeException: No OpenGL context found in the current thread.
Profiler Position: N/A (disabled)
Player Count: 1 / 8; [EntityPlayerMP['Tony_De_Tiger'/22, l='New World', x=-150.50, y=4.00, z=858.50]]
Type: Integrated Server (map_client.txt)
Is Modded: Definitely; Client brand changed to 'fml,forge'

 

I don't know anything.

shadowfacts Dragon Slayer

shadowfacts

Posted
Posted

The crash is caused because a null ItemStack exists where Minecraft isn't expecting one. In 1.11+ ItemStacks can no longer be null, instead ItemStack.EMPTY should be used. There are several places in your container and tile entity classes where you're returning a null ItemStack. Replace these null references with ItemStack.EMPTY.

Don't make mods if you don't know Java.

Check out my website: http://shadowfacts.net

Developer of many mods

Tony_The_Tiger Tree Puncher

Tony_The_Tiger

Posted
  • Author
Posted

ContainerBlockTileEntity

 

package com.TonyTiger.simplecoins.guicontainer;

import com.TonyTiger.simplecoins.TileEntity.MintTileEntity;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.Slot;
import net.minecraft.item.ItemStack;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class ContainerMintTileEntity extends Container {

private MintTileEntity te;
protected World worldObj;
protected BlockPos pos;

/*
 * SLOTS:
 * 
 * Input 0 ........ 0
 * Output 1 ........ 1
 * Player Inventory 9-35 .. 2  - 28
 * Player Inventory 0-8 ... 29 - 37
 */

public MintTileEntity getMintTileEntity(){
	return te;
}

public ContainerMintTileEntity(IInventory playerInv, MintTileEntity inte){
	te = inte;
	worldObj = inte.getWorld();
	pos = inte.getPos();

	//Tile slot input
	this.addSlotToContainer(new Slot(te,0,252,63));

	//Tile slot output
	this.addSlotToContainer(new Slot(te,1,482,63));

	// Player Inventory, Slot 9-35, Slot IDs 2  - 28
    for (int y = 0; y < 3; ++y) {
        for (int x = 0; x < 9; ++x) {
            this.addSlotToContainer(new Slot(playerInv, x + y * 9 + 2, 32 + x * 72, 171 + y * 72));
        }
    }

    // Player Inventory, Slot 0-8, Slot IDs 29 - 37
    for (int x = 0; x < 9; ++x) {
        this.addSlotToContainer(new Slot(playerInv, x, 8 + x * 72, 403));
    }
}

@Override
public boolean canInteractWith(EntityPlayer playerIn) {
	return te.isUsableByPlayer(playerIn);
}

@Override
public ItemStack transferStackInSlot(EntityPlayer playerIn, int fromSlot) {
    ItemStack previous = ItemStack.EMPTY;
    Slot slot = (Slot) this.inventorySlots.get(fromSlot);
    
    if (slot.equals(null) && slot.getHasStack()) {
        ItemStack current = slot.getStack();
        previous = current.copy();

        if (fromSlot < 2) {
            // From TE Inventory to Player Inventory
            if (!this.mergeItemStack(current, 2, 37, true))
                return ItemStack.EMPTY;
        }else{
            // From Player Inventory to TE Inventory
            if (!this.mergeItemStack(current, 0, 1, false))
                return ItemStack.EMPTY;
        }
        
        if (current.getCount() == 0)
            slot.putStack(ItemStack.EMPTY);
        else
            slot.onSlotChanged();

        if (current.getCount() == previous.getCount())
            return ItemStack.EMPTY;
        slot.onTake(playerIn, current);
    }
    return previous;
}

}

 

 

BlockTileEntity

 

package com.TonyTiger.simplecoins.TileEntity;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ITickable;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.TextComponentString;
import net.minecraft.util.text.TextComponentTranslation;

public class MintTileEntity extends TileEntity implements ITickable, IInventory {
    
    private ItemStack[] inventory;
    private String customName;

    public MintTileEntity(){
    	this.inventory = new ItemStack[this.getSizeInventory()];
    }
    
    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound nbt){
    	super.writeToNBT(nbt);

        NBTTagList list = new NBTTagList();
        for (int i = 0; i < this.getSizeInventory(); ++i) {
            if (this.getStackInSlot(i) != ItemStack.EMPTY) {
                NBTTagCompound stackTag = new NBTTagCompound();
                stackTag.setByte("Slot", (byte) i);
                this.getStackInSlot(i).writeToNBT(stackTag);
                list.appendTag(stackTag);
            }
        }
        nbt.setTag("Items", list);

        if (this.hasCustomName()) {
            nbt.setString("CustomName", this.getCustomName());
        }
        
        return nbt;
    }

    @Override
    public void readFromNBT(NBTTagCompound nbt) {
    	super.readFromNBT(nbt);

        NBTTagList list = nbt.getTagList("Items", 10);
        for (int i = 0; i < list.tagCount(); ++i) {
            NBTTagCompound stackTag = list.getCompoundTagAt(i);
            int slot = stackTag.getByte("Slot") & 255;
            // Was formerly ItemStack.loadItemStackFromNBT(stackTag)
            this.setInventorySlotContents(slot, new ItemStack(stackTag));
        }

        if (nbt.hasKey(this.getCustomName(), ) {
            this.setCustomName(nbt.getString(this.getCustomName()));
        }
    }
    
    @Override
    public NBTTagCompound getUpdateTag(){
    
        return writeToNBT(new NBTTagCompound());
    }

@Override
public void update() {

}

public String getCustomName() {
        return this.customName;
    }

    public void setCustomName(String customName) {
        this.customName = customName;
    }

@Override
public String getName() {
	return this.hasCustomName() ? this.customName : "container.simplecoins_tile_entity";
}

@Override
public boolean hasCustomName() {
	return this.customName.equals(null) && !this.customName.equals("");
}

@Override
public ITextComponent getDisplayName() {
    return this.hasCustomName() ? new TextComponentString(this.getName()) : new TextComponentTranslation(this.getName());
}

@Override
public void clear() {
	for (int i = 0; i < this.getSizeInventory(); i++)
        this.setInventorySlotContents(i, ItemStack.EMPTY);
}

@Override
public void closeInventory(EntityPlayer arg0){}

@Override
public ItemStack decrStackSize(int index, int count) {
	if (ItemStack.areItemStacksEqual(this.getStackInSlot(index),ItemStack.EMPTY)) {
        ItemStack itemstack = ItemStack.EMPTY;

        if (this.getStackInSlot(index).getCount() <= count) {
            itemstack = this.getStackInSlot(index);
            this.setInventorySlotContents(index, ItemStack.EMPTY);
            this.markDirty();
            return itemstack;
        } else {
            itemstack = this.getStackInSlot(index).splitStack(count);

            if (this.getStackInSlot(index).getCount() <= 0) {
                this.setInventorySlotContents(index, ItemStack.EMPTY);
            } else {
                //Just to show that changes happened
                this.setInventorySlotContents(index, this.getStackInSlot(index));
            }

            this.markDirty();
            return itemstack;
        }
    } else {
        return ItemStack.EMPTY;
    }
}

@Override
public int getField(int arg0) {
	return 0;
}

@Override
public int getFieldCount() {
	return 0;
}

@Override
public int getInventoryStackLimit() {
	return 64;
}

@Override
public int getSizeInventory() {
	return 2;
}

@Override
public ItemStack getStackInSlot(int index) {
	if (index < 0 || index >= this.getSizeInventory())
        return ItemStack.EMPTY;
    return this.inventory[index];
}

@Override
public boolean isEmpty() {
	for(ItemStack is : inventory){
		if(ItemStack.areItemStacksEqual(is,ItemStack.EMPTY) && is.getCount() == 0)
			return true;
	}
	return false;
}

@Override
public boolean isItemValidForSlot(int arg0, ItemStack arg1) {
	return true;
}

@Override
public boolean isUsableByPlayer(EntityPlayer player) {
	return this.getWorld().getTileEntity(this.getPos()) == this 
	&& player.getDistanceSq(this.pos.add(0.5, 0.5, 0.5)) <= 64;
}

@Override
public void openInventory(EntityPlayer arg0){}

//Was formerly getStackInSlotOnClosing(int index)
@Override
public ItemStack removeStackFromSlot(int index){
	ItemStack stack = this.getStackInSlot(index);
    this.setInventorySlotContents(index, ItemStack.EMPTY);
    return stack;
}

@Override
public void setField(int arg0, int arg1) {	
}

@Override
public void setInventorySlotContents(int index, ItemStack stack) {
	if (index < 0 || index >= this.getSizeInventory())
        return;

    if (ItemStack.areItemStacksEqual(stack,ItemStack.EMPTY) && stack.getCount() > this.getInventoryStackLimit())
        stack.setCount(this.getInventoryStackLimit());
        
    if (ItemStack.areItemStacksEqual(stack,ItemStack.EMPTY) && stack.getCount() == 0)
        stack = ItemStack.EMPTY;

    this.inventory[index] = stack;
    this.markDirty();
}

}

 

 

Block

 

package com.TonyTiger.simplecoins.block;

import com.TonyTiger.simplecoins.Main;
import com.TonyTiger.simplecoins.TileEntity.MintTileEntity;
import com.TonyTiger.simplecoins.network.ModGuiHandler;

import net.minecraft.block.Block;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.InventoryHelper;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class MintBlock extends Block{

public final static String modid = Main.MODID;

public MintBlock(String unlocalizedName, Material material, float hardness, float resistance){
	super(material);

	this.setSoundType(SoundType.METAL);
	this.setUnlocalizedName(unlocalizedName);
	this.setHarvestLevel("pickaxe",0);
	this.setCreativeTab(CreativeTabs.MISC);
	this.setResistance(resistance);
	this.setHardness(hardness);
	this.setRegistryName(modid, unlocalizedName);

}
public MintBlock(String unlocalizedName, float hardness, float resistance) {
        this(unlocalizedName, Material.IRON, hardness, resistance);
    }

    public MintBlock(String unlocalizedName) {
        this(unlocalizedName, 2.0f, 10.0f);   
    }
    @Override
    public boolean hasTileEntity(IBlockState state){
    	return true;
    }
@Override
public TileEntity createTileEntity(World worldIn, IBlockState state) {
	return new MintTileEntity();
}
@Override
public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, 
		EntityPlayer player, EnumHand hand, EnumFacing side, float hitX, float hitY, float hitZ) {
	if(!world.isRemote)
        player.openGui(Main.instance, ModGuiHandler.MOD_TILE_ENTITY_GUI, world, pos.getX(), pos.getY(), pos.getZ());
	return true;
}

@Override
public void breakBlock(World world, BlockPos pos, IBlockState blockstate){
    MintTileEntity te = (MintTileEntity) world.getTileEntity(pos);
    InventoryHelper.dropInventoryItems(world, pos, te);
    super.breakBlock(world, pos, blockstate);
}

@Override
public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
    if (stack.hasDisplayName()) {
        ((MintTileEntity) worldIn.getTileEntity(pos)).setCustomName(stack.getDisplayName());
    }
}

}

 

 

GuiHandler

 

import com.TonyTiger.simplecoins.guicontainer.ContainerMintTileEntity;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraftforge.fml.common.network.IGuiHandler;

public class ModGuiHandler implements IGuiHandler {

public static final int MOD_TILE_ENTITY_GUI = 0;

@Override
public Object getServerGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
    if (ID == MOD_TILE_ENTITY_GUI)
        return new ContainerMintTileEntity(player.inventory, (MintTileEntity) world.getTileEntity(new BlockPos(x, y, z)));

    return null;
}

@Override
public Object getClientGuiElement(int ID, EntityPlayer player, World world, int x, int y, int z) {
    if (ID == MOD_TILE_ENTITY_GUI)
        return new GuiMintTileEntity(player.inventory, (MintTileEntity) world.getTileEntity(new BlockPos(x, y, z)));

    return null;
}

}

 

 

GuiBlockTileEntities

 

package com.TonyTiger.simplecoins.client.gui;

import com.TonyTiger.simplecoins.TileEntity.MintTileEntity;
import com.TonyTiger.simplecoins.guicontainer.ContainerMintTileEntity;

import net.minecraft.client.gui.Gui;
import net.minecraft.client.gui.inventory.GuiContainer;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.inventory.IInventory;
import net.minecraft.util.ResourceLocation;

public class GuiMintTileEntity extends GuiContainer{

private IInventory playerInv;
private MintTileEntity te;

public GuiMintTileEntity(IInventory playerInv, MintTileEntity te){
	super(new ContainerMintTileEntity(playerInv,te));
	this.te = te;
	this.playerInv = playerInv;
	this.xSize = 704;
	this.ySize = 499;
}
@Override
protected void drawGuiContainerBackgroundLayer(float f, int mousex, int mousey) {
	GlStateManager.color(1.0f,1.0f,1.0f,1.0f);
	this.mc.getTextureManager().bindTexture(new ResourceLocation("simplecoins:textures/gui/container/mint.png"));
	Gui.drawModalRectWithCustomSizedTexture(this.guiLeft, this.guiTop, 
			0, 0, xSize, ySize, xSize, ySize);
//		this.fontRendererObj.drawString("Mint", 10, 10, 1, true);

}

@Override
protected void drawGuiContainerForegroundLayer(int mouseX, int mouseY) {
    String s = this.te.getDisplayName().getUnformattedText();
    this.fontRendererObj.drawString(s, 88 - this.fontRendererObj.getStringWidth(s) / 2, 6, 4210752);            //#404040
    this.fontRendererObj.drawString(this.playerInv.getDisplayName().getUnformattedText(), 8, 72, 4210752);      //#404040
}

}

 

 

BlockTileEntities

 

package com.TonyTiger.simplecoins.TileEntity;

import net.minecraftforge.fml.common.registry.GameRegistry;

public class ModTileEntities {
public static void init(){
	GameRegistry.registerTileEntity(MintTileEntity.class, "simplecoins_tile_entity");
}
}

 

I don't know anything.

Draco18s Reality Controller

Draco18s

Posted
Posted

Instead of using an 

ItemStack[]

, use a 

NonNullList<ItemStack>

.

 

You have to do this because 

ItemStack[] = new ItemStack[5]

contains 5 null item stacks.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept