Jump to content

Recommended Posts

Posted

As the title said, i have a class that should check the explosion event. But for some reason this is never called.

The event is registered in preInit CommonProxy by doing this

MinecraftForge.EVENT_BUS.register(new EventExplosion());

 

and this is the event class

public class EventExplosion {
@SubscribeEvent
public void onCreeperExplosion(ExplosionEvent event) {
System.out.println("EXPLOSION!!");
}

 

Just for test the only thing it does is to print that string in console, but as you might guess this doesn't happen :/ So why this specific event is not fired?

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted

No, the class that implements the event is called EventExplosion, the event that i'm catching is called ExplosionEvent. I have other classes that catches events like this and they works, it's just this i don't know why it doesn't :/ For instance this class

public class EventPlayerTick {

@SubscribeEvent
public void onPlayerTick(PlayerTickEvent event) {
...stuff
}

does work even if the name of class and the name of the event are similar

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted

I tried catching only the Detonate sub event but it still doesn't fire. If i ignite a creeper or a tnt and this explode then that printout is not printed (meaning that the event is never called). I'm sure the vent is registered because i've added a constructor in the event class with a print and it printed. Could this be a bug, since i've seen other example codes of explosion handling and they're all the same as mine (except for the fact that they catch only the Detonate sub event, wich is what i will do)? I'm using the Recommended 1.10.2 Forge version (1.10.2 - 12.18.3.2185)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted

Oh, dumb me then :D Anyway i have other events registered the same way and they all works, is just this that is ignored and i really don't understand why :/

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted

works fine for me

MinecraftForge.EVENT_BUS.register(new Eplosion());

public class Eplosion {
    @SubscribeEvent
    public void onExplosion(ExplosionEvent event) {
        LogHelper.info("BOOM");
    }
}

Posted

This is the CommonProxy class (i only have this)

package com.forgeguard.proxy;

import com.forgeguard.events.*;

import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.FMLCommonHandler;

public class CommonProxy {
public void init() {

	MinecraftForge.EVENT_BUS.register(new EventLeftClick());
	MinecraftForge.EVENT_BUS.register(new EventPlaceBlock());
	MinecraftForge.EVENT_BUS.register(new EventDestroyBlock());
	MinecraftForge.EVENT_BUS.register(new EventPvp());
	MinecraftForge.EVENT_BUS.register(new EventEntityInteract());
	MinecraftForge.EVENT_BUS.register(new EventDrop());
	MinecraftForge.EVENT_BUS.register(new EventMobSpawn());
	MinecraftForge.EVENT_BUS.register(new EventExplosion());
	MinecraftForge.EVENT_BUS.register(new EventUseItem());
	MinecraftForge.EVENT_BUS.register(new EventRightClick());
	MinecraftForge.EVENT_BUS.register(new EventChat());
	MinecraftForge.EVENT_BUS.register(new EventEntityFall());
	MinecraftForge.EVENT_BUS.register(new EventHunger());
	MinecraftForge.EVENT_BUS.register(new EventPlayerTick());
}
}

 

And this is the main mod class

package com.forgeguard;

import java.util.HashMap;
import java.util.UUID;

import com.forgeguard.commands.CommandRegion;
import com.forgeguard.proxy.CommonProxy;
import com.forgeguard.region.Region;
import com.forgeguard.utils.Utils;

import net.minecraft.item.ItemStack;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.event.FMLServerStartingEvent;

@Mod(modid = ForgeGuard.MODID, version = ForgeGuard.VERSION, name = ForgeGuard.NAME,serverSideOnly = true, acceptableRemoteVersions = "*")
public class ForgeGuard
{
    public static final String MODID = "forgeguard";
    public static final String NAME = "Forge Guard";
    public static final String VERSION = "0.1";
    @Instance("forgeguard")
public static ForgeGuard INSTANCE;
    @SidedProxy(serverSide = "com.forgeguard.proxy.CommonProxy")
public static CommonProxy PROXY;
    public static Utils UTILS;
    public static String REGIONPATH = "./config/ForgeGuard/regions.dat";
    public static String TEMPPATH = "./config/ForgeGuard/regions_temp.dat";
    public static String CONFIGPATH = "./config/ForgeGuard/config.cfg";
    public static ItemStack SELECTOR;
    public static HashMap<UUID, Region> PENDINGS = new HashMap<UUID, Region>();
    public static HashMap<UUID, Region> EDITINGS = new HashMap<UUID, Region>();
    
    
    public static String REGION_PERMISSION = "";
    public static String BYPASS_PERMISSION = "";

    
    @EventHandler
    public void preInit(FMLPreInitializationEvent event) {
    	UTILS = new Utils();
    	
    	UTILS.loadConfig();

    }
    
    @EventHandler
    public void init(FMLInitializationEvent event) {
    	PROXY.init();
    }
    
    
    @EventHandler
    public void serverLoad(FMLServerStartingEvent event)
    {
       event.registerServerCommand(new CommandRegion());
    }
}

 

And this is the event class

public class EventExplosion {
@SubscribeEvent
public void onCreeperExplosion(ExplosionEvent.Detonate event) {

	System.out.println("EXPLOSION!!");
}
}

Don't blame me if i always ask for your help. I just want to learn to be better :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.