[SOLVED] [1.10.2] Compare EntityItem to Item

[Daeruin]

This is probably something dumb, but I can't figure out how to find out if an EntityItem is a certain item. I'm using EntityItemPickupEvent, which can give you an EntityItem with event.getItem(). I can't see any method to return an Item type, and from Item I can't see any method to return an EntityItem. I've searched all over Google and haven't found anything recent that does this (1.7.10 and earlier seem to have different methods than 1.10.2). It seem like this sort of thing ought to be really common and easy to do for this event. Am I missing something?

Edited February 4, 2017 by Daeruin

[Draco18s]

EntityItem#getItem

If I recall the method name correctly.

[Daeruin]

Thanks. It's actually EntityItem#getEntityItem. I overlooked it before. The method names could perhaps be improved. The end result is pretty confusing:

 

event.getItem().getEntityItem().getItem() == youritem

 

The first method returns an EntityItem (not an Item), the second method returns an ItemStack (not an EntityItem), and the third method actually returns an Item.

[Choonster]

7 minutes ago, Daeruin said:

Thanks. It's actually EntityItem#getEntityItem. I overlooked it before. The method names could perhaps be improved. The end result is pretty confusing:

 

event.getItem().getEntityItem().getItem() == youritem

 

The first method returns an EntityItem (not an Item), the second method returns an ItemStack (not an EntityItem), and the third method actually returns an Item.

 

You can suggest name changes on the MCPBot Issue Tracker. You can use MCPBot itself to find the SRG name of a field/method/parameter.

Edited February 4, 2017 by Choonster
BBCode [url] tag doesn't work any more

[Daeruin]

Good idea. The first method (EntityItemPickupEvent.getItem) is actually Forge code. Would that suggestion also be made via MCPBot Issue Tracker?

[Kokkie]

I think not

[Draco18s]

I think that would be a Forge PR on github.