Jump to content

[1.10.2] [SOLVED] getModelLocation called and return correct model but wrong item icon in the end


Recommended Posts

Posted (edited)

ItemMeshDefinition implementation

 

public class MESH implements ItemMeshDefinition {

    @Override
    public ModelResourceLocation getModelLocation(ItemStack itemStack) {
        if (itemStack != null
                && itemStack.hasTagCompound()
                && itemStack.getTagCompound().hasKey(TAG)) {
            return new ModelResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(itemStack.getTagCompound().getString(TAG)));
        }
        return new ModelResourceLocation(ITEM.getRegistryName().toString());
    }
}

 

ItemRenderRegister

 

public class ItemRenderRegister {

    public static void preInit() {

        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());

        register(ITEM);
    }

    public static void init() {
    }

    private static void register(Item item) {
        register(item, 0, item.getRegistryName().toString());
    }

    private static void register(Item item, int metadata, String file) {
        ModelLoader.setCustomModelResourceLocation(item, metadata, new ModelResourceLocation(file));
    }
}

 

I declare some subtypes in my ITEM class with NBT used to define textures.

With this code, all my ITEM have the default texture from this location :

ITEM.getRegistryName().toString()

Also I put breakpoints in :

getModelLocation

It is never called.

 

If I move

register(ITEM);

from

preInit

to

init

then

getModelLocation 

is called and the resources location are the correct ones but ITEM textures are now all null.

 

I don't have any error in my stack trace.

 

 

Edited by Islandil
Posted

Client Proxy

public class ClientProxy extends CommonProxy {

    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);

        ItemRenderRegister.preInit();
    }
...
}

 

New ItemRenderRegister preInit

public static void preInit() {
        register(ITEM);

        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());
    }

 

Same result. All my item have the default texture. No call inside

getModelLocation

 

Posted (edited)

Maybe you are speaking about item register and not about item render register.

My item register is in the preInit of my CommonProxy, which is called before my ClientProxy preInit.

Is this the correct order ?

 

Edit : other way around.

Edited by Islandil
Posted
  On 2/6/2017 at 4:23 PM, Islandil said:

Maybe you are speaking about item register and not about item render register.

My item register is in the preInit of my CommonProxy, which is called after my ClientProxy preInit.

How to execute them in the correct order ?

Expand  

By not being an idiot and swapping two lines of code so they get executed in the correct order.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
  On 2/6/2017 at 4:25 PM, Draco18s said:

By not being an idiot and swapping two lines of code so they get executed in the correct order.

Expand  

Annnnd I am not ! Because I wrongly placed my breakpoint to test. And the calls are in the correct order.

See my edit.

Edited by Islandil
Posted

Then you're calling things in the correct order.

What's the problem now?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
  On 2/6/2017 at 4:12 PM, Islandil said:

Client Proxy

public class ClientProxy extends CommonProxy {

    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);

        ItemRenderRegister.preInit();
    }
...
}

 

New ItemRenderRegister preInit

public static void preInit() {
        register(ITEM);

        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());
    }

 

Same result. All my item have the default texture. No call inside

getModelLocation

 

Expand  

Still the same.

Posted

Ok. My new ItemRenderRegister

public class ItemRenderRegister {

    public static void preInit() {
        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());
    }
}

I get null model for my icons. Using a breakpoint inside my

getModelLocation

I see the correct models being called and I checked the files names.

 

So my problem is : why do I have no model for my icon in my inventory even if the right model is returned by

getModelLocation

?

Posted

Adding

"inventory"

in

getModelLocation

solved the issue.

return new ModelResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(itemStack.getTagCompound().getString(TAG)), "inventory");

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • just rewatched the tutorial and my code is exactly the same as kaupenjoe's.  the item is added into the game but like i said to start it doesnt have a texture or a proper name for whatever reason.
    • yes the name is en_us.json and it is in resources -> assests -> testmod -> lang folders.  i have checked my code and am pretty confident that the code itself is correct.  i even tried loading the project in eclipse and it has the same problems, I think i will just rewatch the whole tutorial and will give an update on the situation.
    • same error, I also tried removing Valkyrian skies as well because I noticed it coming up a lot in the debug log errors
    • Hey man,    i have only been modding Minecraft for a few days but maybe I can help you. First of all make sure to follow every step of Kaupenjoe's tutorial, I found it to been very helpful and complete. The game uses the raw translation key for the item (in your case "item.testmod.alexandrite") if it can't find the correct lang file. Make sure it's name is "en_us.json" and it is saved under "ressources" -> "assets" -> "testmod".
    • whenever I try to get this item to render into the game it appears with the not texture purple and black squares and calls itself by the lang translation file path instead of the name i gave it.   { "item.testmod.alexandrite": "Alexandrite" } this is the lang json file package net.Hurst.testmod.item; import net.Hurst.testmod.TestMod; import net.minecraft.world.item.Item; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID); public static final RegistryObject<Item> ALEXANDRITE = ITEMS.register("alexandrite", () -> new Item(new Item.Properties())); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } this is my ModItems.java file package net.Hurst.testmod; import com.mojang.logging.LogUtils; import net.Hurst.testmod.item.ModItems; import net.minecraft.world.item.CreativeModeTabs; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.BuildCreativeModeTabContentsEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.ModLoadingContext; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.config.ModConfig; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(TestMod.MOD_ID) public class TestMod { public static final String MOD_ID = "testmod"; private static final Logger LOGGER = LogUtils.getLogger(); public TestMod() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); modEventBus.addListener(this::commonSetup); ModItems.register(modEventBus); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC); } private void commonSetup(final FMLCommonSetupEvent event) { } // Add the example block item to the building blocks tab private void addCreative(BuildCreativeModeTabContentsEvent event) { if(event.getTabKey() == CreativeModeTabs.INGREDIENTS){ event.accept(ModItems.ALEXANDRITE); } } // You can use SubscribeEvent and let the Event Bus discover methods to call @SubscribeEvent public void onServerStarting(ServerStartingEvent event) { } // You can use EventBusSubscriber to automatically register all static methods in the class annotated with @SubscribeEvent @Mod.EventBusSubscriber(modid = MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { } } } this is my TestMod.java file { "parent": "minecraft:item/generated", "textures": { "layer0": "testmod:item/generated" } } this is my model file for the item. I am using intellij 2025.1.2 with fdk 1.21 and java 21 I would appreciate the help.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.