Jump to content

[1.10.2] [SOLVED] getModelLocation called and return correct model but wrong item icon in the end


Islandil

Recommended Posts

ItemMeshDefinition implementation

 

public class MESH implements ItemMeshDefinition {

    @Override
    public ModelResourceLocation getModelLocation(ItemStack itemStack) {
        if (itemStack != null
                && itemStack.hasTagCompound()
                && itemStack.getTagCompound().hasKey(TAG)) {
            return new ModelResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(itemStack.getTagCompound().getString(TAG)));
        }
        return new ModelResourceLocation(ITEM.getRegistryName().toString());
    }
}

 

ItemRenderRegister

 

public class ItemRenderRegister {

    public static void preInit() {

        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());

        register(ITEM);
    }

    public static void init() {
    }

    private static void register(Item item) {
        register(item, 0, item.getRegistryName().toString());
    }

    private static void register(Item item, int metadata, String file) {
        ModelLoader.setCustomModelResourceLocation(item, metadata, new ModelResourceLocation(file));
    }
}

 

I declare some subtypes in my ITEM class with NBT used to define textures.

With this code, all my ITEM have the default texture from this location :

ITEM.getRegistryName().toString()

Also I put breakpoints in :

getModelLocation

It is never called.

 

If I move

register(ITEM);

from

preInit

to

init

then

getModelLocation 

is called and the resources location are the correct ones but ITEM textures are now all null.

 

I don't have any error in my stack trace.

 

 

Edited by Islandil
Link to comment
Share on other sites

Client Proxy

public class ClientProxy extends CommonProxy {

    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);

        ItemRenderRegister.preInit();
    }
...
}

 

New ItemRenderRegister preInit

public static void preInit() {
        register(ITEM);

        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());
    }

 

Same result. All my item have the default texture. No call inside

getModelLocation

 

Link to comment
Share on other sites

Maybe you are speaking about item register and not about item render register.

My item register is in the preInit of my CommonProxy, which is called before my ClientProxy preInit.

Is this the correct order ?

 

Edit : other way around.

Edited by Islandil
Link to comment
Share on other sites

1 minute ago, Islandil said:

Maybe you are speaking about item register and not about item render register.

My item register is in the preInit of my CommonProxy, which is called after my ClientProxy preInit.

How to execute them in the correct order ?

By not being an idiot and swapping two lines of code so they get executed in the correct order.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 minute ago, Draco18s said:

By not being an idiot and swapping two lines of code so they get executed in the correct order.

Annnnd I am not ! Because I wrongly placed my breakpoint to test. And the calls are in the correct order.

See my edit.

Edited by Islandil
Link to comment
Share on other sites

Then you're calling things in the correct order.

What's the problem now?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

17 minutes ago, Islandil said:

Client Proxy


public class ClientProxy extends CommonProxy {

    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);

        ItemRenderRegister.preInit();
    }
...
}

 

New ItemRenderRegister preInit


public static void preInit() {
        register(ITEM);

        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());
    }

 

Same result. All my item have the default texture. No call inside


getModelLocation

 

Still the same.

Link to comment
Share on other sites

Ok. My new ItemRenderRegister

public class ItemRenderRegister {

    public static void preInit() {
        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());
    }
}

I get null model for my icons. Using a breakpoint inside my

getModelLocation

I see the correct models being called and I checked the files names.

 

So my problem is : why do I have no model for my icon in my inventory even if the right model is returned by

getModelLocation

?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.