[1.10.2] [SOLVED] getModelLocation called and return correct model but wrong item icon in the end

[Islandil]

ItemMeshDefinition implementation

 

public class MESH implements ItemMeshDefinition {

    @Override
    public ModelResourceLocation getModelLocation(ItemStack itemStack) {
        if (itemStack != null
                && itemStack.hasTagCompound()
                && itemStack.getTagCompound().hasKey(TAG)) {
            return new ModelResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(itemStack.getTagCompound().getString(TAG)));
        }
        return new ModelResourceLocation(ITEM.getRegistryName().toString());
    }
}

 

ItemRenderRegister

 

public class ItemRenderRegister {

    public static void preInit() {

        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());

        register(ITEM);
    }

    public static void init() {
    }

    private static void register(Item item) {
        register(item, 0, item.getRegistryName().toString());
    }

    private static void register(Item item, int metadata, String file) {
        ModelLoader.setCustomModelResourceLocation(item, metadata, new ModelResourceLocation(file));
    }
}

 

I declare some subtypes in my ITEM class with NBT used to define textures.

With this code, all my ITEM have the default texture from this location :

ITEM.getRegistryName().toString()

Also I put breakpoints in :

getModelLocation

It is never called.

 

If I move

register(ITEM);

from

preInit

to

init

then

getModelLocation 

is called and the resources location are the correct ones but ITEM textures are now all null.

 

I don't have any error in my stack trace.

 

 

Edited February 6, 2017 by Islandil

[Islandil]

Client Proxy

public class ClientProxy extends CommonProxy {

    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);

        ItemRenderRegister.preInit();
    }
...
}

 

New ItemRenderRegister preInit

public static void preInit() {
        register(ITEM);

        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());
    }

 

Same result. All my item have the default texture. No call inside

getModelLocation

 

[Islandil]

Maybe you are speaking about item register and not about item render register.

My item register is in the preInit of my CommonProxy, which is called before my ClientProxy preInit.

Is this the correct order ?

 

Edit : other way around.

Edited February 6, 2017 by Islandil

[Draco18s]

  On 2/6/2017 at 4:23 PM, Islandil said:

Maybe you are speaking about item register and not about item render register.

My item register is in the preInit of my CommonProxy, which is called after my ClientProxy preInit.

How to execute them in the correct order ?

Expand  

By not being an idiot and swapping two lines of code so they get executed in the correct order.

[Islandil]

  On 2/6/2017 at 4:25 PM, Draco18s said:

By not being an idiot and swapping two lines of code so they get executed in the correct order.

Expand  

Annnnd I am not ! Because I wrongly placed my breakpoint to test. And the calls are in the correct order.

See my edit.

Edited February 6, 2017 by Islandil

[Draco18s]

Then you're calling things in the correct order.

What's the problem now?

[Islandil]

  On 2/6/2017 at 4:12 PM, Islandil said:

Client Proxy

public class ClientProxy extends CommonProxy {

    @Override
    public void preInit(FMLPreInitializationEvent e) {
        super.preInit(e);

        ItemRenderRegister.preInit();
    }
...
}

 

New ItemRenderRegister preInit

public static void preInit() {
        register(ITEM);

        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());
    }

 

Same result. All my item have the default texture. No call inside

getModelLocation

 

Expand  

Still the same.

[Islandil]

Ok. My new ItemRenderRegister

public class ItemRenderRegister {

    public static void preInit() {
        ResourceLocation[] LOC = new ResourceLocation[LENGTH];
        for (int i = 0; i < LOC.length; i++) {
            LOC[i] = new ResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(i));
        }
        ModelBakery.registerItemVariants(ITEM, LOC);

        ModelLoader.setCustomMeshDefinition(ITEM, new MESH());
    }
}

I get null model for my icons. Using a breakpoint inside my

getModelLocation

I see the correct models being called and I checked the files names.

 

So my problem is : why do I have no model for my icon in my inventory even if the right model is returned by

getModelLocation

?

[Islandil]

Adding

"inventory"

in

getModelLocation

solved the issue.

return new ModelResourceLocation(ITEM.getRegistryName().toString() + "_" + ITEM.getVar(itemStack.getTagCompound().getString(TAG)), "inventory");