Jump to content

[1.11] Power system not working after optimization.


Recommended Posts

Posted

I switched from the RF API to Forges power system recently, that's not a problem anymore. But I was optimizing/fixing errors in my code and I broke it again. I was trying to make a block that grabs power from generator blocks and it worked partially before trying to fix it. Before, in the gui it showed the power rising, but then it stopped gathering power before it was full. After changing the code the power does not rise at all visually.

 

The following are the classes I changed:

 

TileEntity:

http://pastebin.com/RnXveEb8

 

Container:

http://pastebin.com/kkpie1AP

 

MessageHandler:

http://pastebin.com/Q7sctG4C

 

Messge:

http://pastebin.com/JYTnj5QP

 

If you need anything else let me know.

 

Posted

Why are you separating EnumFacing.UP and EnumFacing.DOWN from the horizontals? And in your PurifierMessageHandler handles powerRecieved as the power and not the change in power.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted
41 minutes ago, Animefan8888 said:

Why are you separating EnumFacing.UP and EnumFacing.DOWN from the horizontals?

I think I did because I didn't want it to accept power from the bottom or top. Not sure why I would have done that.

 

44 minutes ago, Animefan8888 said:

And in your PurifierMessageHandler handles powerRecieved as the power and not the change in power.

I've looked at that. It is passed to updateProgressBar which calls setField which has this check:

 

if(id == 2) {
	if(value > 0){
		energyStorage.receiveEnergy(value, false);
	} else {
		energyStorage.extractEnergy(Math.abs(value), false);
	}

	markDirty();
}

 

Is this a wrong way of doing it?

Posted
13 minutes ago, Awesome_Spider said:

I've looked at that. It is passed to updateProgressBar which calls setField which has this check:

 


if(id == 2) {
	if(value > 0){
		energyStorage.receiveEnergy(value, false);
	} else {
		energyStorage.extractEnergy(Math.abs(value), false);
	}

	markDirty();
}

 

Is this a wrong way of doing it?

Well it is called setField so I thought it would do energyStored = value. I forgot to clarify this, but is the energy going up server side?

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

For some reason I was running it on client side. It's working now. Thanks

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi, i'm really having problems trying to set the texture to my custom item. I thought i'm doing everything correctly, but all i see is the missing texture block for my item. I am trying this for over a week now and getting really frustrated. The only time i could make the texture work, was when i used an older Forge version (52.0.1) for Minecraft (1.21.4). Was there a fundamental change for textures and models somewhere between versions that i'm missing? I started with Forge 54.1.0 and had this problem, so in my frustration i tried many things: Upgrading to Forge 54.1.1, created multiple new projects, workspaces, redownloaded everything and setting things up multiple times, as it was suggested in an older thread. Therea are no errors in the console logs, but maybe i'm blind, so i pasted the console logs to pastebin anyway: https://pastebin.com/zAM8RiUN The only time i see an error is when i change the models JSON file to an incorrect JSON which makes sense and that suggests to me it is actually reading the JSON file.   I set the github repository to public, i would be so thankful if anyone could take a look and tell me what i did wrong: https://github.com/xLorkin/teleport_pug_forge   As a note: i'm pretty new to modding, this is my first mod ever. But i'm used to programming. I had some up and downs, but through reading the documentation, using google and experimenting, i could solve all other problems. I only started modding for Minecraft because my son is such a big fan and wanted this mod.
    • Please read the FAQ (link in orange bar at top of page), and post logs as described there.
    • Hello fellow Minecrafters! I recently returned to Minecraft and realized I needed a wiki that displays basic information easily and had great user navigation. That’s why I decided to build: MinecraftSearch — a site by a Minecraft fan, for Minecraft fans. Key Features So Far Straight-to-the-Point Info: No extra fluff; just the essentials on items, mobs, recipes, loot and more. Clean & Intuitive Layout: Easy navigation so you spend less time scrolling and more time playing. Optimized Search: Search for anything—items, mobs, blocks—and get results instantly. What I’m Thinking of Adding More data/information: Catch chances for fishing rod, traveling villager trades, biomes info and a lot more. The website is still under development and need a lot more data added. Community Contributions: Potential for user-uploaded tips for items/mobs/blocks in the future. Feature Requests Welcome: Your ideas could shape how the wiki evolves! You can see my roadmap at the About page https://minecraftsearch.com/about I’d love for you to check out MinecraftSearch and see if it helps you find the info you need faster. Feedback is crucial—I want to develop this further based on what the community needs most, so please let me know what you think. Thanks, and happy crafting!
    • Instructions on how to install newer Java can be found in the FAQ
    • That's just plain wrong... newer versions are much better optimised and start a lot faster than 1.8.9, both Forge and Minecraft itself. Comparing Fabric 1.21 with Forge 1.8 is like comparing apples and oranges... one's brand new and the other's over a decade old.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.