Jump to content
Please read the rules and FAQ before starting a new topic
Currently supported: All versions

Mod loading twice with new Forge

laseromich

By laseromich
in Support & Bug Reports

 Share

Recommended Posts

laseromich Tree Puncher

laseromich

Posted
Posted

All mods who inside mineraft.jar (now i try only with IC2)  - loaded twice!  With old forge(3.1) forks fine

But mods in /mods/ folder load once

 

start.bat

 

  Reveal hidden contents

 

 

ForgeModLoader-0.log

 

  Reveal hidden contents

 

LexManos Reality Controller

LexManos

Posted
Posted

humm, why is ic2 in your jar?

And cleanup your jar things may of gotten wonkey. Start with a fresh jar.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

laseromich Tree Puncher

laseromich

Posted
  • Author
Posted

My custom fix  in cpw/Loader.java

where your " for "  ~~ 356 string 

that will protect scan minecraft.jar twice for mods :/ 

 

 

 
          int minejar=0;
           for (int i=0; i<minecraftSources.length; i++) {
                if (minecraftSources[i].isFile()) {
		if (minecraftSources[i].getName().equals("minecraft.jar") ){	
			if (minejar < 1  )	{       minejar++;	attemptFileLoad(minecraftSources[i], SourceType.CLASSPATH);}
		}
		else{
			log.fine(String.format("Found a minecraft related file at %s, loading",minecraftSources[i].getName()));
			attemptFileLoad(minecraftSources[i], SourceType.CLASSPATH);
		}		

                } else if (minecraftSources[i].isDirectory()) {
                    log.fine(String.format("Found a minecraft related directory at %s, loading",minecraftSources[i].getAbsolutePath()));
                    attemptDirLoad(minecraftSources[i],"",SourceType.CLASSPATH);
                }
            }
        }
        log.fine("Minecraft jar mods loaded successfully");

you want ask for whaat that?

 

1- if  in minecraft.jar no mods, thay load MineForge - twice!  :\

2- if  in minecraft.jar mods thay load it twice too :D

LexManos Reality Controller

LexManos

Posted
Posted

That's is some ugly ass code.

Anyways, this shouldn't be happening and you shouldn't need to edit any classes to stop it.

I can not reproduce your issues, I load things only once when they are in the jar.

Give me your EXACTLY installed files, and your EXACT install order.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

cpw Creeper Killer

cpw

Posted
Posted

lasero, what is going on here? You have the minecraft jar duplicated on your classpath somehow and that is causing your issue. The question is, why do you have minecraft.jar on the classpath twice? What launcher are you using that is doing that? I would suggest fixing the launcher...

Also, LCTrees is broken with recent forge. It won't work until the author updates the mod...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept