[1.10.2] [SOLVED] Changing block state wipes out tile entity data?

[Daeruin]

I have a block with a tile entity. The block has several different states. In the block's onBlockActivated, when it is clicked on with a specific item, I want to change the block to a different state and set off a timer in my tile entity. I can get the timer part to work on its own, but when I change the block's state, the timer seems to be wiped out.

 

ModBlock#onBlockActivated

@Override
public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumHand hand, ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ)
{
	if (world.isRemote)
	{
			// spawn particles
			return false;
		}
		else return true;
	}
	else
	{
		TileEntity tileEntity = world.getTileEntity(pos);
		if (heldItem != null)
		{
			if (heldItem.getItem() instanceof PrimalItemGlowingEmber && state.getValue(CAMPFIRE_STATE) == EnumCampfireState.TINDER)
			{
				if (((PrimalTileEntityCampfire) tileEntity).tinderStokeTime == 0)
				{
					((PrimalTileEntityCampfire) tileEntity).tinderStokeTime = 60;
					world.setBlockState(pos, getDefaultState().withProperty(CAMPFIRE_STATE, EnumCampfireState.TINDER_STOKED));
				}
				return false;
			}
		return true;
	}
}

 

ModTileEntity#update

public void update()
{
	if (!this.world.isRemote)
	{
		EnumCampfireState campfireState = world.getBlockState(this.pos).getValue(PrimalBlockCampfire.CAMPFIRE_STATE);
		if (this.tinderStokeTime > 0)
		{
			--this.tinderStokeTime;
		}
}

 

If I remove the "world.setBlockState..." line from onBlockActivated, the timer variable gets set and decrements correctly. As soon as I add that line back in, the variable doesn't get set correctly (or gets reset somehow). I didn't think the state of my block would have anything to do with the tile entity data.

Edited February 20, 2017 by Daeruin

[Choonster]

By default, mod TileEntities are replaced any time the block state changes. To change this, override TileEntity#shouldRefresh to return true when the Blocks of the old and the new IBlockStates are different.

[Animefan8888]

Did you edit your ModBlock#onBlockActivated before posting it here? Because the way it is currently would not even compile.

[Leomelonseeds]

@Choonster That will probably be a big help with my Grill. Thanks!

[Daeruin]

50 minutes ago, Animefan8888 said:

Did you edit your ModBlock#onBlockActivated before posting it here? Because the way it is currently would not even compile.

Yes, I cut out a bunch of stuff that wasn't relevant to the question.

[Daeruin]

55 minutes ago, Choonster said:

By default, mod TileEntities are replaced any time the block state changes. To change this, override TileEntity#shouldRefresh to return true when the Blocks of the old and the new IBlockStates are different.

Thank you, I'll try that and let you know how it goes!

[Daeruin]

Worked like a charm! However, I have a question about this comment in the documentation:

 

Quote

Use with caution as this will leave straggler TileEntities, or create conflicts with other TileEntities if not used properly.

What does that mean? How should I "use it properly"?

[Choonster]

15 minutes ago, Daeruin said:

Worked like a charm! However, I have a question about this comment in the documentation:

 

What does that mean? How should I "use it properly"?

 

Don't return false when the Block changes, otherwise your Block's TileEntity will remain after the IBlockState at its position was replaced with another.

[Daeruin]

I think I've got it. I should have read your earlier comment more carefully. It seems like you could either check that the old and new block from the IBlockStates are NOT the same, and return true, else return false, like this:

 

    @Override

    public boolean shouldRefresh(World world, BlockPos pos, IBlockState oldState, IBlockState newState)

    {

        if (oldState.getBlock() != newState.getBlock()) return true;

        else return false;

    }

 

Or check that the old and new block ARE the same, and return false. But don't just return false every time.

[Choonster]

1 hour ago, Daeruin said:

I think I've got it. I should have read your earlier comment more carefully. It seems like you could either check that the old and new block from the IBlockStates are NOT the same, and return true, else return false, like this:

 

    @Override

    public boolean shouldRefresh(World world, BlockPos pos, IBlockState oldState, IBlockState newState)

    {

        if (oldState.getBlock() != newState.getBlock()) return true;

        else return false;

    }

 

Or check that the old and new block ARE the same, and return false. But don't just return false every time.

 

That's correct.

 

When you have a method that does if (some_boolean_expression) return true; else return false;, you can simplify it to return some_boolean_expression;.

[jeffryfisher]

There might be some corner cases where your block's shouldRefresh is called when your block is not even there (or when one instance is replaced by another, depending on how your mod functions and how you might extend the block class later). Therefore, rather than just checking for a changed block, you might check whether the old and new blocks are your block (or instanceof).

[Daeruin]

18 hours ago, Choonster said:

When you have a method that does if (some_boolean_expression) return true; else return false;, you can simplify it to return some_boolean_expression;.

 

How . . . logical.

 

9 hours ago, jeffryfisher said:

There might be some corner cases where your block's shouldRefresh is called when your block is not even there (or when one instance is replaced by another, depending on how your mod functions and how you might extend the block class later). Therefore, rather than just checking for a changed block, you might check whether the old and new blocks are your block (or instanceof).

 

I'm not sure if those corner cases would ever apply to me, but just to be safe I changed it:

 

@Override
public boolean shouldRefresh(World world, BlockPos pos, IBlockState oldState, IBlockState newState)
{
    return !(oldState.getBlock() instanceof <myblock> && newState.getBlock() instanceof <myblock>);
}