[1.10.2] [SOLVED] Spawning particles in onBlockActivated

[Daeruin]

I want to spawn some fire particles in my block's onBlockActivated method, when a variable in my tile entity is the right value (basically, you have to "activate" the block 3 times within a small window of time before the particles will spawn, and I'm saving the number of times and time elapsed in my tile entity). I have read about a million posts on this, and everything says that you should be able to spawn vanilla particles from the server. I swear I have seen examples of other mods doing this, too, but I can't get it to work. I know the code is running, because the println statement fires.

 

I also tried sending a packet, but it didn't work. I didn't include that code since I don't really think I should have to do that anyway. Please correct me if I'm wrong.

 

I also tried spawning the particles on the client, but even after grabbing a copy of my tile entity from the BlockPos parameter, I can't seem to access the variables (they don't change like they should).

 

@Override
public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumHand hand, ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ)
{
	EnumCampfireState campfireState = state.getValue(CAMPFIRE_STATE);
	TileEntity tileEntity = world.getTileEntity(pos);
	int stokeTime = ((PrimalTileEntityCampfire) tileEntity).tinderStokeTime;
	int timesBlown = ((PrimalTileEntityCampfire) tileEntity).tinderTimesBlown;

	if (world.isRemote) // client
	{
	// do stuff
	}
	else // server
	{			
		if (heldItem == null && campfireState == EnumCampfireState.TINDER_STOKED)
		{
			if (stokeTime < 40)
			{
				((PrimalTileEntityCampfire) tileEntity).tinderStokeTime = 60;
				((PrimalTileEntityCampfire) tileEntity).tinderTimesBlown += 1;
				PrimalPacketHandler.INSTANCE.sendTo(new PrimalCampfirePacket(player, 0, pos), (EntityPlayerMP) player);
			}
			if (timesBlown > 3)
			{
				System.out.println("Spawning particle");
				world.spawnParticle(EnumParticleTypes.FLAME, (double) pos.getX(), (double) pos.getY(), (double) pos.getZ(), 0.0D, 0.0D, 0.0D, new int[0]);
			}			
		}			
	}
	return true;
}

 

Edited May 9, 2017 by Daeruin

[TheMasterGabriel]

What version are you using? If it's the latest, you are not overriding onBlockActivated, as there is an extra ItemStack parameter. You should be overriding

public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) { return false; }

which you can find in the Block class.

Edited February 21, 2017 by TheMasterGabriel

[Daeruin]

I'm using 1.10.2, as stated in the post title. Pretty sure my override is fine, as my version of Block shows this:

    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ)

 

[Animefan8888]

I believe the problem is you are spawning the particles with zero speed and inside the block so they are not visible.

[Daeruin]

That's a good idea, but in this case the block is basically transparent. When I put that exact same call in the block's randomDisplayTick method, I can see the particles just fine.

[TheMasterGabriel]

2 hours ago, Daeruin said:

I'm using 1.10.2, as stated in the post title

 

Whoops, I don't know how I missed that. Apologies

 

From past experience, I'm fairly sure that particles only exist on the client, which is why you are not seeing them. Block#randomDisplayTick fires only on the client side, so it makes sense that you could see them there. Try spawning them on the client side. As for your variable problem, that is also due to the client/server side. In order for tile entity to recognize the variable changes on the client-side, you need to update the number of right clicks on the server side and then send the update to the client-side via a packet. You can read about networking and the side stuff on the Forge docs here.

[Choonster]

World#spawnParticle(EnumParticleTypes, double, double, double, double, double, double, int...) does nothing on the server, it only spawns particles when called on the client. You need to use one of the spawnParticle overloads from WorldServer instead.

[Daeruin]

I have read tutorials and other posts on this forum stating that you can initiate a particle on the server, using world#spawnParticle, and the server will automatically send out the required packets. For example:

 

http://jabelarminecraft.blogspot.com/p/minecraft-forge-1721710-modding-tips.html

 

Quote

Tip: Initiate the spawn of vanilla particles on the server side,. Even though EntityFX is only a client side class, the server method doesn't instantiate it but rather sends a packet to all the clients (which then instantiate the class). Since you usually want all players to see the particles, the method to initiate the spawn should be invoked on the server side (world.obj.isRemote should be false). 

 

I have done a few packets before, but it bugs me to go to that effort when a single line method call should work.

 

I already tried sending a packet to spawn the particle directly on the client, and it didn't work. It will play the sound correctly, and the println statements appear, but it won't spawn the particle. Here's the packet:

 

Spoiler

public class PrimalCampfirePacket implements IMessage
{

	private int playerId;
	private int messageId;
	private double posX;
	private double posY;
	private double posZ;

	public PrimalCampfirePacket()
	{
	}

	public PrimalCampfirePacket(EntityPlayer player, int messageId, BlockPos pos)
	{
		this.playerId = player.getEntityId();
		this.messageId = messageId;
		this.posX = pos.getX() + 0.5D;
		this.posY = pos.getY();
		this.posZ = pos.getZ() + 0.5D;
	}

	@Override
	public void fromBytes(ByteBuf buffer)
	{
		this.playerId = buffer.readInt();
		this.messageId = buffer.readInt();
		this.posX = buffer.readInt();
		this.posY = buffer.readInt();
		this.posZ = buffer.readInt();
	}

	@Override
	public void toBytes(ByteBuf buffer)
	{
		buffer.writeInt(playerId);
		buffer.writeInt(messageId);
		buffer.writeDouble(posX);
		buffer.writeDouble(posY);
		buffer.writeDouble(posZ);
	}

	public static class PrimalCampfireHandler implements IMessageHandler<PrimalCampfirePacket, IMessage>
	{

		@Override
		public IMessage onMessage(final PrimalCampfirePacket message, final MessageContext ctx)
		{
			IThreadListener mainThread = Minecraft.getMinecraft();
			mainThread.addScheduledTask(new Runnable()
			{
				@Override
				public void run()
				{
					Entity entity = Minecraft.getMinecraft().world.getEntityByID(message.playerId);
					System.out.println("Packet entity: " + entity);
					System.out.println("Packet messageId: " + message.messageId);
					if (entity instanceof EntityPlayer)
					{
						if (message.messageId == 0)
						{
							System.out.println("Packet playing sound");
							((EntityPlayer) entity).playSound(PrimalSoundRegistry.blowing, 1.0F, 1.0F);
						}
						if (message.messageId == 1)
						{
							System.out.println("Packet spawning flame");
							Minecraft.getMinecraft().world.spawnParticle(EnumParticleTypes.FLAME, message.posX, message.posY, message.posZ, 0.0D, 0.0D, 0.0D, new int[0]);
						}
					}
				}
			});
			return null;
		}

	}

}

 

 

[Daeruin]

12 minutes ago, Choonster said:

World#spawnParticle(EnumParticleTypes, double, double, double, double, double, double, int...) does nothing on the server, it only spawns particles when called on the client. You need to use one of the spawnParticle overloads from WorldServer instead.

 

Ninja'd. How do I do that? Do I cast my world parameter to WorldServer?

(On the server side, naturally - !world.isRemote)

[TheMasterGabriel]

In your code, you already check if you are on the server side. Because of that, you can cast your world object to a WorldServer object and then use the following method to spawn your particles. It's much easier than the manual packet thing (which I wouldn't have told you about if I'm not oblivious and had read the WorldServer class). Well, knowledge of packets is always good anyways . 

 

/** Spawns the desired particle and sends the necessary packets to the relevant connected players. */
public void spawnParticle(EnumParticleTypes particleType, double xCoord, double yCoord, double zCoord, int numberOfParticles, double xOffset, double yOffset, double zOffset, double particleSpeed, int... particleArguments)

 

Edited February 21, 2017 by TheMasterGabriel

[Daeruin]

Woo-hoo! That worked. Many thanks.