Search the Forums BEFORE making a new post.

[1.11.2] Changing bonemeal behavior

Posted February 23, 20178 yr

Hello, is there a way to change the amount that bonemeal lets the crop grow? I want to make it so it's like the old days that you just need 1 bonemeal per crop...

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 23, 20178 yr

Author

How do I set the grow level?

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 23, 20178 yr

Author

~~Where can I find that?~~

Couldn't find ItemBonemeal, forgot it was a dye

Edited February 23, 20178 yr by Kokkie

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 23, 20178 yr

Author

How can I forge it to make it full-grown?

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 23, 20178 yr

Author

Through some hacky nifty ways I managed to come up with this, would it work?

	@SubscribeEvent
	public void onCropGrow(BonemealEvent event) {
		event.setCanceled(true);
		World world = event.getWorld();
		IBlockState state = event.getBlock();
		BlockPos pos = event.getPos();
		ItemStack stack = event.getEntityPlayer().getActiveItemStack();
		if (state.getBlock() instanceof IGrowable) {
			IGrowable igrowable = (IGrowable) state.getBlock();

			if (igrowable.canGrow(world, pos, state, world.isRemote)) {
				if (!world.isRemote) {
					igrowable.grow(world, world.rand, pos, state);
					if (igrowable instanceof BlockCrops) {
						world.setBlockState(pos, state.withProperty(BlockCrops.AGE, ((BlockCrops)igrowable).getMaxAge()));
					}
					stack.shrink(1);
				}
			}
		}
	}

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 23, 20178 yr

Author

Wow I had that idea in the beginning but thought Nah that wont work....

	@SubscribeEvent
	public void onCropGrow(BonemealEvent event) {
		event.setCanceled(true);
		World world = event.getWorld();
		IBlockState state = event.getBlock();
		BlockPos pos = event.getPos();
		ItemStack stack = event.getEntityPlayer().getActiveItemStack();
		if (state.getBlock() instanceof IGrowable) {
			IGrowable igrowable = (IGrowable) state.getBlock();

			if (igrowable.canGrow(world, pos, state, world.isRemote)) {
				if (!world.isRemote) {
					igrowable.grow(world, world.rand, pos, state);
					while (igrowable.canGrow(world, pos, state, world.isRemote)) {
						igrowable.grow(world, world.rand, pos, state);
					}
					stack.shrink(1);
				}
			}
		}
	}

Let's test this out

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

Author

Now it 'crashes' the game when I use bonemeal, so when I use it I can't use anything in the game (use hoes on land, open guis from blocks) and then it crashes when I try to go back to the main menu... No crashes in the console

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

It gets stuck in an infinite loop at the while because it is using the same state everytime instead you should get the state from the World field and BlockPos field.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

February 26, 20178 yr

Author

	@SubscribeEvent
	public void onCropGrow(BonemealEvent event) {
		event.setCanceled(true);
		World world = event.getWorld();
		IBlockState state = event.getBlock();
		BlockPos pos = event.getPos();
		ItemStack stack = event.getEntityPlayer().getActiveItemStack();
		if (state.getBlock() instanceof IGrowable) {
			IGrowable igrowable = (IGrowable) state.getBlock();

			if (igrowable.canGrow(world, pos, state, world.isRemote)) {
				if (!world.isRemote) {
					igrowable.grow(world, world.rand, pos, state);
					while (igrowable.canGrow(world, pos, state, world.isRemote)) {
						igrowable.grow(world, world.rand, pos, state);
						igrowable = (IGrowable) world.getBlockState(pos).getBlock();
					}
					stack.shrink(1);
				}
			}
		}
	}

Doesn't work either

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

No your state, not the IGrowable. In the while loop the state you pass into the method needs to be updated so use the worlds state at the BlockPos.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

February 26, 20178 yr

Author

Ah thanks it works, only thing is, it doesn't take away an item... And the tree gets well.. buggy... It isn't rendered until you update the blocks (right-click)...

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

3 minutes ago, Kokkie said:

Ah thanks it works, only thing is, it doesn't take away an item... And the tree gets well.. buggy... It isn't rendered until you update the blocks (right-click)...

You will need to mark the block for an update specifically the client. World#markBlockForUpdate (I think that is the name at least it is similar).

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

February 26, 20178 yr

Author

Which one?

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

I believe the first one and if i am wrong others please correct me.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

February 26, 20178 yr

Author

					world.markAndNotifyBlock(pos, world.getChunkFromBlockCoords(pos), state, state, 2);

This doesn't work

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

The second state needs to be the one gotten from the world.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

February 26, 20178 yr

Author

	@SubscribeEvent
	public void onCropGrow(BonemealEvent event) {
		event.setCanceled(true);
		World world = event.getWorld();
		IBlockState state = event.getBlock();
		BlockPos pos = event.getPos();
		ItemStack stack = event.getEntityPlayer().getActiveItemStack();
		if (state.getBlock() instanceof IGrowable) {
			IGrowable igrowable = (IGrowable) state.getBlock();
			if (igrowable.canGrow(world, pos, state, world.isRemote)) {
				if (!world.isRemote) {
					while (igrowable.canGrow(world, pos, state, world.isRemote)) {
						igrowable.grow(world, world.rand, pos, state);
						state = world.getBlockState(pos);
					}
					world.markAndNotifyBlock(pos, world.getChunkFromBlockCoords(pos), state, world.getBlockState(pos), 2);
					stack.shrink(1);
				}
			}
		}
	}

Nope...

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

Try looking at the Javadoc for the method.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

February 26, 20178 yr

Author

Where can I find the javadoc? And what should I look for?

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

Look at the method in the class it belongs to. The comments above the method are known as the javadoc.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

February 26, 20178 yr

Author

Oh that... Ok.

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

Author

Also, I get this error in the console

[14:16:20] [Server thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.event.entity.player.BonemealEvent@75452f75:
java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=stage, clazz=class java.lang.Integer, values=[0, 1]} as it does not exist in BlockStateContainer{block=minecraft:log, properties=[axis, variant]}
	at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:201) ~[BlockStateContainer$StateImplementation.class:?]
	at net.minecraft.block.BlockSapling.grow(BlockSapling.java:71) ~[BlockSapling.class:?]
	at net.minecraft.block.BlockSapling.grow(BlockSapling.java:251) ~[BlockSapling.class:?]
	at com.Egietje.degeweldigemod.handler.CheeseCommonHandler.onCropGrow(CheeseCommonHandler.java:80) ~[CheeseCommonHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_18_CheeseCommonHandler_onCropGrow_BonemealEvent.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) [EventBus.class:?]
	at net.minecraftforge.event.ForgeEventFactory.onApplyBonemeal(ForgeEventFactory.java:355) [ForgeEventFactory.class:?]
	at net.minecraft.item.ItemDye.applyBonemeal(ItemDye.java:118) [ItemDye.class:?]
	at net.minecraft.item.ItemDye.onItemUse(ItemDye.java:62) [ItemDye.class:?]
	at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:812) [ForgeHooks.class:?]
	at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:179) [ItemStack.class:?]
	at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:516) [PlayerInteractionManager.class:?]
	at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:712) [NetHandlerPlayServer.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) [CPacketPlayerTryUseItemOnBlock.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) [CPacketPlayerTryUseItemOnBlock.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) [PacketThreadUtil$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:1.8.0_77]
	at java.util.concurrent.FutureTask.run(Unknown Source) [?:1.8.0_77]
	at net.minecraft.util.Util.runTask(Util.java:26) [Util.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:753) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:698) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:547) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_77]
[14:16:20] [Server thread/ERROR] [FML]: Index: 1 Listeners:
[14:16:20] [Server thread/ERROR] [FML]: 0: NORMAL
[14:16:20] [Server thread/ERROR] [FML]: 1: ASM: com.Egietje.degeweldigemod.handler.CheeseCommonHandler@63a5a05a onCropGrow(Lnet/minecraftforge/event/entity/player/BonemealEvent;)V
[14:16:20] [Server thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=stage, clazz=class java.lang.Integer, values=[0, 1]} as it does not exist in BlockStateContainer{block=minecraft:log, properties=[axis, variant]}
	at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_77]
	at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_77]
	at net.minecraft.util.Util.runTask(Util.java:27) [Util.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:753) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:698) [MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:547) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_77]
Caused by: java.lang.IllegalArgumentException: Cannot get property PropertyInteger{name=stage, clazz=class java.lang.Integer, values=[0, 1]} as it does not exist in BlockStateContainer{block=minecraft:log, properties=[axis, variant]}
	at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:201) ~[BlockStateContainer$StateImplementation.class:?]
	at net.minecraft.block.BlockSapling.grow(BlockSapling.java:71) ~[BlockSapling.class:?]
	at net.minecraft.block.BlockSapling.grow(BlockSapling.java:251) ~[BlockSapling.class:?]
	at com.Egietje.degeweldigemod.handler.CheeseCommonHandler.onCropGrow(CheeseCommonHandler.java:80) ~[CheeseCommonHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_18_CheeseCommonHandler_onCropGrow_BonemealEvent.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) ~[EventBus.class:?]
	at net.minecraftforge.event.ForgeEventFactory.onApplyBonemeal(ForgeEventFactory.java:355) ~[ForgeEventFactory.class:?]
	at net.minecraft.item.ItemDye.applyBonemeal(ItemDye.java:118) ~[ItemDye.class:?]
	at net.minecraft.item.ItemDye.onItemUse(ItemDye.java:62) ~[ItemDye.class:?]
	at net.minecraftforge.common.ForgeHooks.onPlaceItemIntoWorld(ForgeHooks.java:812) ~[ForgeHooks.class:?]
	at net.minecraft.item.ItemStack.onItemUse(ItemStack.java:179) ~[ItemStack.class:?]
	at net.minecraft.server.management.PlayerInteractionManager.processRightClickBlock(PlayerInteractionManager.java:516) ~[PlayerInteractionManager.class:?]
	at net.minecraft.network.NetHandlerPlayServer.processTryUseItemOnBlock(NetHandlerPlayServer.java:712) ~[NetHandlerPlayServer.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:68) ~[CPacketPlayerTryUseItemOnBlock.class:?]
	at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.processPacket(CPacketPlayerTryUseItemOnBlock.java:13) ~[CPacketPlayerTryUseItemOnBlock.class:?]
	at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_77]
	at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_77]
	at net.minecraft.util.Util.runTask(Util.java:26) ~[Util.class:?]
	... 5 more

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 26, 20178 yr

Author

So... What should the method do?

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 27, 20178 yr

Author

Bump

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

February 27, 20178 yr

Author

So.. this?

	@SubscribeEvent
	public void onBonemeal(BonemealEvent event) {
		event.setCanceled(true);
		World world = event.getWorld();
		BlockPos pos = event.getPos();
		IBlockState state = world.getBlockState(pos);
		ItemStack stack = event.getEntityPlayer().getHeldItemMainhand();
		if (stack.getItem() != Items.DYE) {
			stack = event.getEntityPlayer().getHeldItemOffhand();
			if (stack.getItem() != Items.DYE) {
				return;
			}
		}
		if (state.getBlock() instanceof IGrowable) {
			IGrowable igrowable = (IGrowable) state.getBlock();
			if (!world.isRemote) {
				while (igrowable.canGrow(world, pos, state, world.isRemote)) {
					igrowable.grow(world, world.rand, pos, state);
					state = world.getBlockState(pos);
					if (state.getBlock() instanceof IGrowable) {
						igrowable = (IGrowable) state.getBlock();
					} else {
						stack.shrink(1);
					}
				}
			}
		}
	}

Edited February 27, 20178 yr by Kokkie
Other solution

Classes: 94

Lines of code: 12173

Other files: 206

Github repo: https://github.com/KokkieBeer/DeGeweldigeMod

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/50829-1112-changing-bonemeal-behavior/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 4 hours ago4 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · 18 hours ago18 hr
Orbital strike cannon fishing rod mod

@FoxyWoxy do you potentially have an estimated time for fabric 1.21.5 and what will it be posted on (modrinth, etc.)

By JayKing014 · 21 hours ago21 hr
Orbital strike cannon fishing rod mod

By FoxyWoxy · 21 hours ago21 hr
New Forum Design/Update: Issues and Suggestions

I don't know that either - newer worked with Invision Community 😕

The Forum/Guides show a customized toolbar:
https://invisioncommunity.com/4guides/themes-and-customizations/editor-and-emoticons_327/customizing-editor-toolbars-r132/
But I have no idea if this applies to v5

Regarding the Forum, "Mark all as read" seems to be hidden as default but is available if I click on my profile:
https://invisioncommunity.com/forums/topic/481218-fix-for-unreadmark-read/

I saw that it works here and also fixes the one unread thread mentioned in my first post - so I had just overlooked it

The toolbar changes are just QoL - if there is no way to change it at the moment, that's fine

By TileEntity · Yesterday at 09:21 PM1 day

VictorEvers

Sign In

[1.11.2] Changing bonemeal behavior

Featured Replies

Join the conversation

Posts

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

New Forum Design/Update: Issues and Suggestions

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)