[1.10.2] solved add enchant-able item?

[Cleverpanda]

Hello.

I'd like to have an item that as part of it's crafting process, needs to be put in the enchantment table and 30 levels applied to it. I can't find any resources or forge hooks that allow me to add an enchantable item or specify a single enchantment it's allowed to have.

Can anyone help me on how I can accomplish this?
thanks

 

Edited February 27, 2017 by Cleverpanda

[Choonster]

Minecraft doesn't let you control how many levels an enchantment consumes, it's always 1, 2 or 3 depending on which slot of the enchantment table it's in.

 

To add an enchantment, create a class that extends Enchantment and register it like any other IForgeRegistryEntry (i.e. IForgeRegistry#register in RegistryEvent.Register<Enchantment> or GameRegistry.register in preInit).

 

Override Enchantment#getMinEnchantability and Enchantment#getMaxEnchantability to control the enchantablility and XP levels required to apply the enchantment.

 

Create an EnchantmentType with EnumHelper.addEnchantmentType or override Enchantment#canApply/Enchantment#canApplyAtEnchantingTable to control which items the enchantment can be applied to.

 

Override Item#canApplyAtEnchantingTable to control which enchantments can be applied to an item.

[Cleverpanda]

Item#canApplyAtEnchantingTable doesn't seem to exist?

[Cleverpanda]

currently my item ovverrides getItemEnchantability() and returns 3.
My enchantment is registered with GameRegistry.register(new DummyEnchantment()); in preInit
and the enchantment class is http://pastebin.com/m1fXCkcm
And nothing is showing up when I put the item in the enchantment table

[Draco18s]

I think that's supposed to be Enchantment#canApplyAtEnchantingTable

 

Edit:

return stack.getItem() == ItemList.ENCHANT_CRAFTING_ITEM ? true:false;

There is no reason to do this. You can simply do this:

return stack.getItem() == ItemList.ENCHANT_CRAFTING_ITEM;

Second, make your max enchantibility a larger number. As is, you've said "this is only valid at exactly 3 levels."  Too high and it'll get skipped.

Edited February 27, 2017 by Draco18s

[Cleverpanda]

*Facepalm* wow, of course.

and Any number that's larger should work, yeah? I just did 4. make the min 2 just to be sure.

canApply(stack) is being called for other enchantable items (Pickaxe) but not for my item when I put it in the table

Edited February 27, 2017 by Cleverpanda
info changed

[Draco18s]

Try overriding canApplyAtEnchantingTable in your enchantment too.

[Cleverpanda]

It does; returns canApply(stack)

[Cleverpanda]

Neither functon is even being called when I put my item in there

[Draco18s]

Have you overriden getItemEnchantability in your Item? The base value is 0, which means not enchantable.

[Cleverpanda]

Yes I have, it returns 3

[Cleverpanda]

Could it be my enchantment constructor?

super(Enchantment.Rarity.RARE, EnumEnchantmentType.ALL, new EntityEquipmentSlot[] {EntityEquipmentSlot.MAINHAND});

[Cleverpanda]

My item just extends Item and overrides getItemEnchantability

[Draco18s]

I'm at a loss.  Put a breakpoint on line 327 of ContainerEnchantment (net.minecraft.inventory) just before it calls EnchantmentHelper.buildEnchantmentList(...) and stick your item in and trace the code to see what it does and why it doesn't call canApply for your item.

[Cleverpanda]

Solved!

public boolean isItemEnchantable()
    {
        return !this.getItem().isItemTool(this) ? false : !this.isItemEnchanted();
    }

was false so I overrode isItemTool to be true.
Not sure what adverse effects this may have, but it solves the issue

[Choonster]

2 hours ago, Cleverpanda said:

Item#canApplyAtEnchantingTable doesn't seem to exist?

 

I forgot that it was only added in 1.11, so it doesn't exist in 1.10.2.

[jeffryfisher]

13 hours ago, Cleverpanda said:

I overrode isItemTool to be true.

If that's the case, then perhaps your item class should extend class ItemTool.

[Cleverpanda]

1 hour ago, jeffryfisher said:

If that's the case, then perhaps your item class should extend class ItemTool.

Nah. nothing else in ItemTool would be relevant