[1.10.2] Crops

[WildHeart]

I have a plant that grows in the two unit, but second unit age is greater than 0 then the top block changes its blockstates with upper on lower. How to fix?

Code:

Spoiler

public class BlockDoubleCrops extends BlockCrops
{
    public static final PropertyEnum<EnumCropHalf> HALF = PropertyEnum.create("half", EnumCropHalf.class);
    private Item setSeed, setCrop;

    public BlockDoubleCrops(final Item seed, final Item crop)
    {
        setCreativeTab(Farmland.FMCT);
        setTickRandomly(true);
        disableStats();
        setDefaultState(blockState.getBaseState().withProperty(this.getAgeProperty(), Integer.valueOf(0)).withProperty(HALF, EnumCropHalf.LOWER));
        this.setSeed = seed;
        this.setCrop = crop;
    }

    @Override
    protected PropertyInteger getAgeProperty()
    {
        return super.getAgeProperty();
    }

    @Override
    protected BlockStateContainer createBlockState()
    {
        return new BlockStateContainer(this, new IProperty[] {AGE, HALF});
    }

    @Override
    public boolean onBlockActivated(final World worldIn, final BlockPos pos, final IBlockState state, final EntityPlayer playerIn, final EnumHand hand, @Nullable final ItemStack heldItem, final EnumFacing side, final float hitX, final float hitY, final float hitZ)
    {
        if(!worldIn.isRemote)
        {
            if(isMaxAge(state))
            {
                final EntityItem crop = new EntityItem(worldIn, pos.getX(), pos.getY(), pos.getZ(), new ItemStack(getCrop()));
                worldIn.spawnEntityInWorld(crop);
                worldIn.setBlockState(pos, withAge(0));
                return true;
            }
        }
        return false;
    }

    @Override
    protected boolean canSustainBush(IBlockState state)
    {
        return state.getBlock() == Blocks.FARMLAND || state.getBlock() == this;
    }

    @Override
    public void grow(final World worldIn, final BlockPos pos, final IBlockState state)
    {
        super.grow(worldIn, pos, state);

        if(getAge(state) == getMaxAge())
        {
            //if(worldIn.isAirBlock(pos.offset(EnumFacing.UP)))
            {
                //worldIn.setBlockState(pos.offset(EnumFacing.UP), blockState.getBaseState().withProperty(HALF, EnumCropHalf.UPPER));
                worldIn.setBlockState(pos.up(), this.getDefaultState().withProperty(HALF, EnumCropHalf.UPPER), 2);
            }
        }
    }

    @Override
    public void onBlockHarvested(final World worldIn, final BlockPos pos, final IBlockState state, final EntityPlayer player)
    {
        super.onBlockHarvested(worldIn, pos, state, player);

        if (state.getValue(HALF) == EnumCropHalf.UPPER)
        {
            if (worldIn.getBlockState(pos.down()).getBlock() == this)
            {
                if (!player.capabilities.isCreativeMode)
                {
                    dropBlockAsItem(worldIn, pos, state, 0);
                }

                worldIn.setBlockToAir(pos);
            }
        }
        else if (state.getValue(HALF) == EnumCropHalf.LOWER)
        {
            if (worldIn.getBlockState(pos.up()).getBlock() == this)
            {
                if (!player.capabilities.isCreativeMode)
                {
                    dropBlockAsItem(worldIn, pos, state, 0);
                    dropBlockAsItem(worldIn, pos.up(), state, 0);
                }

                worldIn.setBlockToAir(pos.up());
            }
        }
    }

    @Override
    protected Item getSeed()
    {
        return this.setSeed;
    }

    @Override
    protected Item getCrop()
    {
        return this.setCrop;
    }

    @Override
    public boolean canUseBonemeal(final World worldIn, final Random rand, final BlockPos pos, final IBlockState state)
    {
        return true;
    }
}

 

 

Edited March 12, 2017 by WildHeart

[WildHeart]

up

[WildHeart]

6 minutes ago, diesieben07 said:

Sorry, but I have no idea what you are talking about.

 

[WildHeart]

This video shows that after 0 the top block changes its state to lower.

[MFMods]

likely the inherited grow method. try replacing it with your own code.

[WildHeart]

5 minutes ago, diesieben07 said:

You need to override getMetaFromState and getStateFromMeta to save not only the age (like BlockCrops does) but both AGE and HALF.

Don't quite understand how it should look can be an example?

[Jay Avery]

35 minutes ago, WildHeart said:

Don't quite understand how it should look can be an example?

Look at the class you're extending to see what it does in those methods. getMetaFromState takes an IBlockState and returns an int, getStateFromMeta takes an int and returns an IBlockState. They are used to store the block's state information in the form of a number and then convert it back.

[WildHeart]

3 minutes ago, Jay Avery said:

Look at the class you're extending to see what it does in those methods. getMetaFromState takes an IBlockState and returns an int, getStateFromMeta takes an int and returns an IBlockState. They are used to store the block's state information in the form of a number and then convert it back.

Hrm, something like that?

public IBlockState getStateFromMeta(int meta)
    {
        return (meta & 1) > 0 ? this.getDefaultState().withProperty(HALF, EnumCropHalf.UPPER) : this.getDefaultState().withProperty(HALF, EnumCropHalf.LOWER);
    }

    public int getMetaFromState(IBlockState state)
    {
        return state.getValue(HALF) == EnumCropHalf.UPPER ? 1 : 0;
    }

 

[MFMods]

exactly. meta is what gets saved on the disk.

except you are to code two properties into 4 bits - a maximum of 8 growth stages and 2 half variants.

[WildHeart]

4 minutes ago, MFMods said:

exactly. meta is what gets saved on the disk.

except you are to code two properties into 4 bits - a maximum of 8 growth stages and 2 half variants.

Hmm what do you suggest? To reduce the number of stages of growth?

[MFMods]

you get 4 bits total (16 values). no discussion there.

if you spend 1 bit on half (2 values) that leaves 3 bits for growth stages, meaning a maximum of 8 values.

 

if you need more than 8 stages, then you need to make top and bottom half separate blocks and maintain that multiblock structure.

[WildHeart]

34 minutes ago, MFMods said:

 

Edited March 12, 2017 by WildHeart

[WildHeart]

So, i create:

    @Override
    public IBlockState getStateFromMeta(int meta) {
        return getDefaultState().withProperty(HALF, meta == 0 ? EnumCropHalf.LOWER : EnumCropHalf.UPPER);
    }

    @Override
    public int getMetaFromState(IBlockState state) {
        EnumCropHalf type = state.getValue(HALF);
        return type.getMeta();
    }

Now as I understand it, you need to create getSubBlocks?

[WildHeart]

4 minutes ago, diesieben07 said:

That will not work, now you only save the HALF property. You need to save both HALF and AGE.

With this at the moment, the problem. I can't do both(type.getMeta && withAge)

[MFMods]

and do not override getSubBlocks. that's for when you want separate independent variants of the same block (like sandstone for example).

 

*sigh*  i'd make a horrible teacher....

 

go to http://minecraft.gamepedia.com/Wood

do you understand how two information pieces are encoded into 16 possible values of metadata?

on the Bed page you will see three information pieces encoded. is the storing part clear clear to you?

[WildHeart]

10 minutes ago, diesieben07 said:

That will not work, now you only save the HALF property. You need to save both HALF and AGE.

Right?

@Override
public IBlockState getStateFromMeta(int meta) {
    return getDefaultState().withProperty(HALF, meta == 0 ? EnumCropHalf.LOWER : EnumCropHalf.UPPER).withProperty(AGE_DOUBLE, Integer.valueOf(meta));
}

@Override
public int getMetaFromState(IBlockState state) {
    EnumCropHalf type = state.getValue(HALF);
    return type.getMeta() & ((Integer)state.getValue(AGE_DOUBLE)).intValue();
}

[WildHeart]

Forgot to say, I changed the age. Now he is 4 instead of 8.

[WildHeart]

21 minutes ago, diesieben07 said:

No. You need to learn bitwise operators.

Begin to understand mc code I found this code. He in fact is the answer to my question?

    /**
     * Convert the given metadata into a BlockState for this Block
     */
    public IBlockState getStateFromMeta(int meta)
    {
        return this.getDefaultState().withProperty(FACING, EnumFacing.getFront(meta & 7)).withProperty(NODROP, Boolean.valueOf((meta & 8) > 0));
    }

    /**
     * Convert the BlockState into the correct metadata value
     */
    public int getMetaFromState(IBlockState state)
    {
        int i = 0;
        i = i | ((EnumFacing)state.getValue(FACING)).getIndex();

        if (((Boolean)state.getValue(NODROP)).booleanValue())
        {
            i |= 8;
        }

        return i;
    }

 

[WildHeart]

1 hour ago, diesieben07 said:

Same answer.

So, I did what you wanted and works as I need. What did I do? I started using getActualState checking the block on the bottom. Finally works as I intended. Special thanks to diesieben07 for your help and nerves of steel. I will continue to explore Properties, in order not to ask such questions, thanks to all!