[1.11.2] Tile Entity Block Texture Not Updating When Property Changes

[CalmBit]

Hey there forum,

Having some serious issues with getting my block to update its texture when a property is changed - as far as I can tell, i've implemented every single bit of code suggested, and should have a working implementation, and yet for some reason it refuses to work correctly.

 

This gist contains all of the relevant code, along with the blockstate file for the block I'm having trouble with.

 

While the BlockGrinder seems to receive the appropriate property update (with the F3 menu representing state as "grinder_on" when the conditions are met and seamlessly switching to "grinder_off" when they're not), the texture of the block only updates if I press F3+A to reload the chunks.

Any ideas what I could be screwing up?

[Draco18s]

Why are you extending BlockContainer?  You don't need this, it fucks everything else up and stop using it.

This does dick and as such you shouldn't even be extending BlockContainer at all, even if that class had value (which it doesn't):

public TileEntity createNewTileEntity(World worldIn, int meta) {
    return null;
}

Seriously. WTF.  Unless you meant for it to be abstract like the rest of the class...

Why do you create your own FACING property? Why not using the one from BlockDirectional or BlockHorizontal?

As for textures based on properties inside a TE, you need to sync the TE state to the client:

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/farming/entities/TileEntityTanner.java#L95-L98

Edited March 14, 2017 by Draco18s

[CalmBit]

Quote

Why are you extending BlockContainer?

Well, shit. Looks like I didn't get the memo. (I haven't worked on a mod since 1.7, so I'm still working on old knowledge from that and other sources, so I'm not exactly the brightest when it comes to all of it).

I'll remove that garbage, and see what else I can do.

 

Quote

public TileEntity createNewTileEntity(World worldIn, int meta) {
    return null;
}

I can't handle how moronic I can be - sorry if this was a waste of your time.
 

Quote

Why do you create your own FACING property? Why not using the one from BlockDirectional or BlockHorizontal?

Because I'm pretty fucking stupid and totally didn't look for an implementation before doing it myself. Also gonna change this.

Edited March 14, 2017 by CalmBit
More hot garbage

[CalmBit]

Ok, so I made the requested "no shit" improvements and added the extra two methods detailed in file you linked for TE state syncing (didn't realize there were four separate methods, but alright). Should have all other syncing measures in place.

The TE's update now has the following (mirrored from the file, essentially):
 

        if(wasActive != isActive) {
            this.world.markBlockRangeForRenderUpdate(this.pos, this.pos);
            this.world.notifyBlockUpdate(this.pos, this.world.getBlockState(this.pos), this.world.getBlockState(this.pos), 3);
            this.world.scheduleBlockUpdate(this.pos, this.getBlockType(), 0, 0);
            this.markDirty();
        }

 

Still not having any luck on the texture updating. The code's definitely being called when it needs to be (tested in debugger), and all other TE sync methods should be in place (packet updating, getActualState(), etc.)

(gist contains updated code as well)

Edited March 14, 2017 by CalmBit

[CalmBit]

Alright, figured it out, feel like an idiot. Your class tipped me off to the fact I was running sided logic, and that my update function was probably only being called on the server. Turns out that's a solid yes, and de-sided the logic. Will this have any particular side-effects I should look out for? I'm not exactly sure what the purpose is with siding that kind of logic, but it seems to be the standard.

 

That's not necessarily a solid idea, on my part. Seems like a great way to get weird de-sysncs...

Edited March 14, 2017 by CalmBit

[CalmBit]

As a last edit, I re-instated the server-sided logic, but made wasActive an instance variable rather than a local variable, with its value being each time its found to be non-congruent with isActive.  This achieves all of the desired effects. Thank you!

[Draco18s]

11 hours ago, CalmBit said:

(didn't realize there were four separate methods, but alright).

They all do slightly different things. I ended up with all four because something wasn't working right (turned out to be a problem elsewhere, oops) and having all four doesn't hurt necessarily.  It could probably be reduced two two of them and work Just Fine.

 

Next, there's actually three network methods, not two.

https://github.com/Draco18s/ReasonableRealism/blob/master/src/main/java/com/draco18s/farming/entities/TileEntityTanner.java#L176-L188

One is called when the TE is first created, the other the rest of the time (and no, I can't remember which is which).