Probably Just Being Dumb..

[minecraftbigfoot]

This doesn't drop a skull, though from what I can see it should.

	//"skeleton", "wither", "zombie", "char", "creeper", "dragon"
	@SubscribeEvent
	public void entityDrops(LivingDropsEvent event) 
	{		
		Minecraft mc = Minecraft.getMinecraft();
		EntityPlayer plr = mc.thePlayer;

		if(plr.inventory.getCurrentItem().getItem().equals(BrandyWeapons.vorpalBlade))
		{
			if(event.getEntity().getEntityId() == 51){
				event.getEntity().entityDropItem(new ItemStack(Items.SKULL, 1, 0), 0);}
			if(event.getEntity().getEntityId() == 5){
				event.getEntity().entityDropItem(new ItemStack(Items.SKULL, 1, 1), 0);}
			if(event.getEntity().getEntityId() == 54){
				event.getEntity().entityDropItem(new ItemStack(Items.SKULL, 1, 2), 0);}
			if(event.getEntity() == plr){
				event.getEntity().entityDropItem(new ItemStack(Items.SKULL, 1, 3), 0);}
			if(event.getEntity().getEntityId() == 50){
				event.getEntity().entityDropItem(new ItemStack(Items.SKULL, 1, 4), 0);}
			if(event.getEntity().getEntityId() == 63){
				event.getEntity().entityDropItem(new ItemStack(Items.SKULL, 1, 5), 0);}
		}
	}

Wondering if it is because I am using EntityIDs?

[minecraftbigfoot]

Cheers Sir!

[Draco18s]

Your code will also crash if you punch something to death (assuming you aren't on 1.11).

plr.inventory.getCurrentItem().getItem().equals(BrandyWeapons.vorpalBlade)

 

What happens if plr.inventory.getCurrentItem() is null?

[jeffryfisher]

4 hours ago, Draco18s said:

Your code will also crash if you punch something to death

Or maybe also when your thorns enchantment kills something while your hand is empty.

Speaking of hands, shouldn't the code be looking at main and off-hand?  In other words, what should happen if a player is holding the vorpal sword in his off-hand?

[Spyeedy]

17 minutes ago, jeffryfisher said:

Or maybe also when your thorns enchantment kills something while your hand is empty.

Speaking of hands, shouldn't the code be looking at main and off-hand?  In other words, what should happen if a player is holding the vorpal sword in his off-hand?

He seems to be working on a pre-1.9 mc version, hence, no main hand and offhand.

[minecraftbigfoot]

I am working on MC 1.10, however I was using CurrentItem because from what I remember from a couple of years ago that was the right call (stopped playing for 2 or so years).

 

However I will change it to get main hand

[Spyeedy]

Ah I see, probably should state the mc version you are working on next time in the thread's title next time. 

[minecraftbigfoot]

Probably should hehe, thank you.

 

Whilst you're here..

 

event.getDrops().add(new ItemStack(Items.SKULL, 1, 0))

 

wants me to make the ItemStack a EntityItem, not being funny but what does this mean?

[minecraftbigfoot]

Boom!

if(event.getEntity() instanceof EntitySkeleton)
			{
				ItemStack stack = new ItemStack(Items.SKULL, 1, 0);
        		if(stack.stackSize > 1){stack.stackSize = 1;}
        		EntityItem drop = new EntityItem(attacked.worldObj, attacked.posX, attacked.posY, attacked.posZ, stack);
        		event.getDrops().add(drop);
        	}

 

Thanks all, think I was just having a mental block, how things have changed over just a couple of years :')

[Jay Avery]

59 minutes ago, minecraftbigfoot said:

if(stack.stackSize > 1){stack.stackSize = 1;}

This line is completely unnecessary. You create a stack with a size of 1, and then check in case it's not 1..?

[minecraftbigfoot]

8 hours ago, Jay Avery said:

This line is completely unnecessary. You create a stack with a size of 1, and then check in case it's not 1..?

Yesterday was not my finest day 

[minecraftbigfoot]

Need a little help Null checking, thought that a valid null check was 

•         if(plr.inventory.getCurrentItem().getItem() != null && plr.inventory.getCurrentItem().getItem().equals(BrandyWeapons.vorpalBlade))

But I find this gives me a null pointer exception and errors, I'm being dumb right?

[minecraftbigfoot]

Thank you Sir!

		if(plr.getHeldItemMainhand() != null && plr.getHeldItemMainhand().getItem().equals(BrandyWeapons.vorpalBlade))

works perfect!