Updating a free source mod

[Sofften]

Hi,

I actually trying to uptade a 1.10 mod to 1.11.2, which is MAtmos (abandonned by Hurricane, and then updated by Sollace). It works with LiteLoader.

Sorry but I'm not a modder, I'm only discovering it and I don't have knowledge in Java, I know you will tell me that this forum isn't a Java classroom but what I ask is very little, I'm not here to ask you how to create code or a whole mod.

 

I've update the gradle and ant stuff to 1.11.2, but some classes files give me errors about mc source code and methods, I understood that it is because of the Minecraft source code which has changed from 1.10 to 1.11.2. I could repair it for really really simple things ('thePlayer' began 'player', 'theWord' began 'world') but there is some other things that I dont know how to repair. Here is a list :

 

        EntityPlayerSP player = mc.player;

setValue("armor_0_as_number", number(player.inventory.armorInventory[0]));
        setValue("armor_1_as_number", number(player.inventory.armorInventory[1]));
        setValue("armor_2_as_number", number(player.inventory.armorInventory[2]));
        setValue("armor_3_as_number", number(player.inventory.armorInventory[3]));

Error : The type of the expression must be an array type but it resolved to NonNullList<ItemStack>

 

            ItemStack item = player.inventory.armorInventory;

Error : Same

 

        Entity ride = Minecraft.getMinecraft().player.getRidingEntity();

 

 

[Draco18s]

37 minutes ago, Sofften said:

Error : The type of the expression must be an array type but it resolved to NonNullList<ItemStack>

Essentially what's happened is that Minecraft 1.11 requires that the ItemStack variable type can no longer be null.  Instead it uses the static constant, ItemStack.AIR (if I remember the location correctly).  Similarly all ArrayLists<ItemStack> must be replaced with NonNullList<ItemStack>.

 

But yes, you're going to need some Java knowledge to be able to mod, even updating, because you need to understand the sentences above.

[Sofften]

REPOST: sorry my post bugged

Hi,

I actually trying to uptade a 1.10 mod to 1.11.2, which is MAtmos (abandonned by Hurricane, and then updated by Sollace). It works with LiteLoader.

Sorry but I'm not a modder, I'm only discovering it and I don't have knowledge in Java, I know you will tell me that this forum isn't a Java classroom but what I ask is very little, I'm not here to ask you how to create code or a whole mod.

 

I've update the gradle and ant stuff to 1.11.2, but some classes files give me errors about mc source code and methods, I understood that it is because of the Minecraft source code which has changed from 1.10 to 1.11.2, because it works perfectly well in 1.10. I could repair it for really really simple things ('thePlayer' began 'player', 'theWord' began 'world') but there is some other things that I dont know how to repair. Here is a list :

 

        EntityPlayerSP player = mc.player;

setValue("armor_0_as_number", number(player.inventory.armorInventory[0]));
        setValue("armor_1_as_number", number(player.inventory.armorInventory[1]));
        setValue("armor_2_as_number", number(player.inventory.armorInventory[2]));
        setValue("armor_3_as_number", number(player.inventory.armorInventory[3]));

Error : The type of the expression must be an array type but it resolved to NonNullList<ItemStack>

 

            ItemStack item = player.inventory.armorInventory;

Error : Same

 

        setValue("entity_id", EntityList.getEntityID(ride));

Error : The method getEntityID(Entity) is undefined for the type EntityList

 

        EntityHorse ride = (EntityHorse) xride;

        setValue("chested", ride.isChested());

        setValue("type", ride.getType().isUndead());

        setValue("reproduced", ride.getHasReproduced());

Error : The method getType() is undefined for the type EntityHorse

Error : The method isChested() is undefined for the type EntityHorse

Error : The method getHasReproduced() is undefined for the type EntityHorse

 

                    int entityID = EntityList.getEntityID(e);

Error : The method getEntityID(Entity) is undefined for the type EntityList

 

int eID = e instanceof EntityPlayer ? 0 : EntityList.getEntityID(e);

Error : The method getEntityID(Entity) is undefined for the type EntityList

 

        return player.inventory.armorInventory[this.zeronth];

Error : The type of the expression must be an array type but it resolved to NonNullList<ItemStack>

 

                .getEntityID(mc.objectMouseOver.entityHit) : MODULE_CONSTANTS.NO_ENTITY);

Error : The method getEntityID(Entity) is undefined for the type EntityList

 

If some files are missing to understand just tell me, i will upload it, but actually I think it's only due to methods changes in Minecraft classes files, so yeah I know I shouldn't try anything without knowing Java code, but I'm just asking to you if you could tell me what should I write (What is the new methods spelling), not necessary to explain me, but if you cant say me what to do just try to explain me it's always better I will do my best to understand

Edited March 29, 2017 by Sofften

[Draco18s]

1) Some method signatures changed, this is probably the cause of any "The method [func]() is undefined for the type [class]" errors.

2) You really need to know Java

3) See prior posts.

[Sofften]

2 minutes ago, Draco18s said:

1) Some method signatures changed, this is probably the cause of any "The method [func]() is undefined for the type [class]" errors.

2) You really need to know Java

3) See prior posts.

"Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. "

Ok understood, on my way to read your online guide about java basics, except if you advise me another. Then I was thinking; is there a list of method changes trough version, so that I can find what I need ? Because once I've understood what this code that I posted means, I dont see how I will know where to find the new method, and in which class file. And also I still have some java knowledge, so just explain me what I need to do to repair those errors and I will manage to understand by readin java guides. Thx for answer.

[Draco18s]

https://github.com/ModCoderPack/MCPBot-Issues/issues

[Sofften]

5 minutes ago, Draco18s said:

https://github.com/ModCoderPack/MCPBot-Issues/issues

Well I don't understand why you send me that considering that it's absolutely not helping me in any way, but well if you dont want to help me that's sad, but no problem i will manage to find help ;).

[Draco18s]

That's the list of all renames.  Its not terribly well organized, but it is the list.

[Sofften]

Well ok, but I found nothing about  NonNullList<ItemStack> , getEntityID, getType, isChested and getHasReproduced, sadly. 

 

[loordgek]

where can i get the code ?

 

[Sofften]

Here is the mod source code package (gradle and mod files already updated for 1.11.2)

MAtmos-r33.zip

[Sofften]

For the 'change list' I just found this : https://wiki.mcjty.eu/modding/index.php/Porting-1.10-1.11 which looks interesting, even if this :

ItemStack changes

This is the most significant change. An empty itemstack (like a slot in a chest that is empty or the player's hand that is empty) is no longer equal to null but to ItemStack.EMPTY instead! In fact 'null' ItemStack's are no longer allowed. You have to carefully go over all your code (use annotations where appropriate) to find all places where you use null for itemstacks and replace them. Also where you compare with null you have to replace this with a isEmpty() call. Be careful with things like ItemStack[] items because these are initialized to null. You need to ensure that all these items are initialized to EMPTY instead of null. It is recommended to use NonNullList<ItemStack> for this on 1.11 or else use ItemStackList from CompatLayer.

is not fully understandable for me.

[loordgek]

what part do you not understand ?

[Sofften]

In fact I understand the text, but not the link with the errors I have ( This error :"The type of the expression must be an array type but it resolved to NonNullList<ItemStack>" ). Also the website does not contain help about getEntityID, getType, isChested and getHasReproduced errors. 

[loordgek]

NOTE this is a liteloader project not a forge project

 

getEntityID is still there

 

	@Override
	protected ItemStack getItem(EntityPlayer player)
	{
		return player.inventory.armorInventory[this.zeronth];
	}

do you get the error here ?

 

isChested is now hasChest

[Sofften]

Is 'getEntityID' still in net.minecraft.entity.EntityList ? cause it tells me that it's not.

Yes here, but also in L_legacy (linked) :

 

        setValue("armor_0_as_number", number(player.inventory.armorInventory[0]));
        setValue("armor_1_as_number", number(player.inventory.armorInventory[1]));
        setValue("armor_2_as_number", number(player.inventory.armorInventory[2]));
        setValue("armor_3_as_number", number(player.inventory.armorInventory[3]));

 

and in M_ply_armor (linked) :

 

         EntityPlayerSP player = Minecraft.getMinecraft().player;
        
        for (int i = 0; i < 4; i++)
        {
            ItemStack item = player.inventory.armorInventory;
            ItemProcessorHelper.setValue(this, item, Integer.toString(i));
        }

 

hasChest doesn't work, except if it's not from net.minecraft.entity.passive.EntityHorse

 

 

L__legacy.java

M__ply_armor.java

[loordgek]

for the inv you need to do it like so

player.inventory.armorInventory.get(index)

 

[Sofften]

It works, thanks a lot.

Maybe you have a solution for getEntityID and horse properties ?

Also this :

fontRenderer.drawStringWithShadow(
                                index + " (" + EntityList.getEntityStringFromClass(EntityList.getClassFromID(Integer.parseInt(index))) + "): " + val,
                                leftAlign, 2 + 9 * lineNumber, 0xFFFFFF);

 

getEntityStringFromClass is undefined for the type EntityList (in eu.ha3.matmos.game.user.VisualDebugger)

Edited March 29, 2017 by Sofften

[loordgek]

no

[Sofften]

Maybe someone have a solution for the things that still don't work :

- EntityList.getEntityID() corrected, it was in Entity and not in EntityList

 

- EntityHorse.getType()  corrected by deleting it, Undead (Skeleton and Zombie) is no longer a Type for Horse but new Entities (EntityZombieHorse  and EntitySkeletonHorse)

- EntityHorse.isChested() corrected with this :

		EntityHorse ride = (EntityHorse) xride;
		AbstractChestHorse chest = (AbstractChestHorse) xride;
		
		setValue("jumping", ride.isHorseJumping()); // functional ?
		setValue("rearing", ride.isRearing());
		setValue("saddled", ride.isHorseSaddled());
		setValue("leashed", ride.getLeashed());
		setValue("chested", chest.hasChest());
		setValue("tame", ride.isTame());

- EntityHorse.getHasReproduced() deleted for now, lets see if it works

 

 

Edited March 30, 2017 by Sofften

[Sofften]

Please Help me for this :

EntityList.GetEntityStringFromClass() this Method no longer exist in EntityList, I'm trying to use GetEntityString instead but i cant figure out which Entity it's trying to get the String of, as it's a really disgusting code :

		fontRenderer.drawStringWithShadow(
			index + " (" + EntityList.getEntityStringFromClass(EntityList.getClassFromID(Integer.parseInt(index))) + "): " + val,
			leftAlign, 2 + 9 * lineNumber, 0xFFFFFF);

So please correct me if it's wrong, but if I understand correctly it's trying to get the String of an Entity by its Class (with Method 'getEntityStringFromClass'), then it's trying to get the Class from an ID (with method 'getClassFromID'), and then it's trying to get the ID converting a String (index) to an int (like an ID is)  (with 'parseInt').

What I do not understand is what is index, which String is it refering to. If i know that I could use instead 'GetEntityString', as I need the Entity pointed here to use that.

'index' is refering to :

		for (String index : sort)

Then 'sort' is refering to :

		List<String> sort = new ArrayList<String>(sheet.keySet());

... then 'sheet' is refering to :

	private void debugScanWithSheet(final Sheet sheet, boolean isDeltaPass)

... So i'm lost, help please

 

 

Here is the source code :     

 

 

VisualDebugger.java

Edited March 30, 2017 by Sofften

[jabelar]

The problem with updating to new versions is that there are multiple types of changes. Some are simply changes of names, but some are changes in prototype (like methods now take additional parameters), and some are major changes in functionality. You need to be good at Java and also experienced with modding to be able to clear out all the issues.