Item crafted does not persist, but when taken from creative it persists

[ctbe]

I hope this is not a silly question. For a staff I created in my mod, I added a crafting recipe using GameRegistry.addShapedRecipe(). I passed it a new ItemStack with the item, as well as the other parameters to build the recipe. The recipe works. It gets registered and you can craft the staff in a crafting table, but when you close the world, or the whole minecraft game, and open it again, the staff disappears!

 

The staff is added to the creative tab and you can get the item from creative. When you do get the item from creative, it persists across world closes and opening. But when you craft it, you get the item only for the time the world is open. If you close the world with Save and quit to title, or close the whole minecraft game, the item disapears from your inventory. It does not persist.

 

Is there anything else one has to do for when items are crafted in a crafting table to be saved?

[Matryoshika]

Show your recipe code.

[ctbe]

Sure.

 

 GameRegistry.addShapedRecipe(new ItemStack(modItems.itemStaff),
      "XRX",
      "XSX",
      "XSX",
      'R'.asInstanceOf[Character], Items.REDSTONE, 'S'.asInstanceOf[Character], Items.STICK)

 

modItems contains the staff item in a variable called itemStaff. I debugged and the item is present and initialized at the moment the crafting recipe is added.

[Geometrically]

You have never defined the character X, if you want to not make it an item you would do this:

 

 GameRegistry.addShapedRecipe(new ItemStack(modItems.itemStaff),
      " R ",
      " S ",
      " S ",
      'R'.asInstanceOf[Character], Items.REDSTONE, 'S'.asInstanceOf[Character], Items.STICK)

 

[ctbe]

Thanks. I fixed it to look like that now, but it still disappears from the inventory when I quit the game.

[Geometrically]

If you can craft it that's fine.

 

That problem may persist of a bug or the item isn't being registered when it was crafted in game.

[ctbe]

Yes, I can craft it. And use it. My staff does what I programmed it to do.

 

Is there any way I can test if the item the player is holding on hand is registered? Like a method that gives you information about the item the user is holding or something similar. I ask to see if I can somehow debug it.

 

While debugging in the IDE I can see the item modItems.itemStaff has been registered using events as per the documentation recommendations, and exists. It is properly initialized and it has the unlocalized and registry names registered too.

 

Edit: To add more information, I am looking through the logs and when I reopen the world, it says nothing about a missing item or an item being deleted. It just reopens the world without the item in the inventory. When I close it doesn't say anything either about an item failing to save or something similar. Nor when I craft the item. No message is thrown whatsoever.

Edited April 12, 2017 by ctbe
Adding information

[Matryoshika]

1 hour ago, ctbe said:

.asInstanceOf[Character]

The class that implements these recipes, is it made in Scala?

Because that's Scala casting, and I believe the objects has to be pure Java to work properly. JsonTweaker (Scala mod, is on GitHub) faces this issue, and solved it by invoking a custom Java method that took the ItemStack & object[] and returned the recipe.

[ctbe]

1 hour ago, Matryoshika said:

The class that implements these recipes, is it made in Scala?

 

Yes, my mod is made in Scala.

 

But it's okay. I got it working. The object I was passing to it (modItems.itemStaff) did exist, was initialized and everything was correct, but it wasn't the same object instance I used in the RegistryEvent (RegistryEvent.Register[Item]) to register the item before preInit. The instance of the Item you must pass to new ItemStack when adding a recipe must be the same instance used in the RegistryEvent for the item. If you create a new instance just for the sake of registering a recipe, it will give the impression it works, you will be able to craft and use the item, etc., but it will not persist when you close the world. When you open the world again, the item will disappear from your inventory.

 

I ran into this because I was trying to avoid the use of statics as much as possible. But it's fixed now.

 

For those who might face the same problem, make sure the instance of the item you pass to the ItemStack when registering the recipe with

 GameRegistry.addShapedRecipe

or similar methods from GameRegistry, is the same instance used to register the item in the RegistryEvent before preInit.

 

Thanks for your prompt replies, everyone.

Edited April 12, 2017 by ctbe
Formatting the text

[Draco18s]

5 hours ago, ctbe said:

For those who might face the same problem, make sure the instance of the item you pass to the ItemStack when registering the recipe with GameRegistry.addShapedRecipe or similar methods from GameRegistry, is the same instance used to register the item in the RegistryEvent before preInit.

Uh. Yes.  That's....kind of how things work.

[ctbe]

Nice. I report your post on your dim mockery and nothing happens. I love it. That certainly leaves a lot to say.

 

I faced a problem here and you didn't even try to help. When the problem was solved and the thread could have died with the conclusion of a solution, you reply. Not to help, but to make dim mockery and try to make yourself look like you have so much common sense knowledge on the forge platform. Your reply contributes nothing, but dim mockery and helps no one. The problem was already solved, your reply is out of place. I'd love to see anyone pointing out how your reply is helpful in any aspect and/or helps solve the problem. For it to be so evident, I didn't see you pointing out the so evident solution. I had more to say about some observations I have seen that are meretricious at best, but I'll leave it at that. After all humans like that tend to be described by society with certain words. The behavior has been already studied, well documented, and is somewhat predictable on certain levels.

[Draco18s]

3 minutes ago, ctbe said:

I faced a problem here and you didn't even try to help.

With the amount of code you posted it was impossible for anyone here to have spotted your error.  All you posted was your crafting recipe line. That's it.

 

It's an obvious error to literally everyone that you have to pass in the same object to the recipe as to the game registry because if you don't how is the game supposed to know they're the same object? You created two different objects.

 

So yeah, you'll get undefined behavior when you try to do something that was never intended to be done.

[ctbe]

Look, I modestly (without arrogance) tell you that I will not argue anymore past this reply. The problem is solved and the thread can fall into forgotten. Here's the thing. That is exactly one of the many kinds of behavior I talk that has been already studied and well documented in texts and academic text books. That last reply was predictable. Try to look for a loophole in what one person has said, then paint the person in bad light with that mistake to justify your actions. The rest of the arguments of the person that committed the mistake will disappear in the eyes of the others. Like they never existed. Nothing they say after will be listened to. The action is very old and documented in newspapers and probably history books. Humans have been doing that for centuries. One person makes fun of another, the other person says "hey, please, stop making fun of me, I don't like it", and the person may stop it, but not before trying to justify its past actions by telling the other person that he/she did wrong first. "But look what this person did first." or "But it's true. Look at this..." That's the kind of arguments.

That it was impossible for anyone to help doesn't justify the reply. I am not going to use sarcasm, insult or even make fun of you. Nor will I try to paint you in bad light or try to make it look like I'm better. I'll simply not do it. I'll just say that when I don't understand the question of another person and need more information to help, I query by telling them to provide more information instead of making a statement of "obviousness" that dimly makes fun of the person. I am not telling you to do the same. I'm just saying what I do when I face similar situations and it's not to make you look bad or make it look like I'm better. That's not the point.

Since the problem was solved and I am not going to argue past this post about that reply I'd like to lastly make emphasis that I did mentioned above that they were not two different objects. They were the same and contained the exact bytes in memory. 22 bytes to be precise according to the heap dump. They were different instances, which is a different concept. If I compare the objects with the equals() methods, the JVM will return true. Making them not two different objects. Just different instances.

[Leomelonseeds]

@ctbeTurn signatures on and read Draco18s' signature. You will then understand.

 

In case you are lazy, here it is:

"

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

"

 

Draco18s i hope you do not have any objections to this.

[Draco18s]

7 hours ago, Leomelonseeds said:

Draco18s i hope you do not have any objections to this.

Hardly.