[1.11.2] Custom Enchantments on Custom Items

[RainbowLuigi281]

Hello.

I have created a custom item, and I would like to be able to enchant that item with a custom enchantment I created.  Even though the item can get the enchantment through the "/enchant" command, I would like to have it be obtainable through an enchantment table.  However, I am having trouble with that.

 

I have registered my item and my enchantment, and have created a new type of EnumEnchantmentType that supports my item.

 

I am using forge version 13.20.0.2279.

 

Enchantment Registry Code:

Spoiler

@EventBusSubscriber
public class ModEnchantments {

	public static final EnumEnchantmentType COOL = EnumHelper.addEnchantmentType("COOL", (item) -> item instanceof ItemUniverseRing);
	
	public static final List<Enchantment> ENCHANTMENTS = new ArrayList<Enchantment>();
	
	public static final Enchantment BEHEADING = addEnchantment(new EnchantmentBeheading(), "beheading");
	
	private static Enchantment addEnchantment(Enchantment enchantment, String name) {
		ENCHANTMENTS.add(enchantment);
		return enchantment.setRegistryName(name).setName(name);
	}
	
	@SubscribeEvent
	public static void registerEnchantments(Register<Enchantment> event) {
		for(Enchantment enchantment: ENCHANTMENTS)
			event.getRegistry().register(enchantment);
	}
}

 

 

Enchantment Code:

Spoiler

public class EnchantmentBeheading extends Enchantment {

	public EnchantmentBeheading() {
		super(Rarity.RARE, ModEnchantments.COOL, new EntityEquipmentSlot[] {EntityEquipmentSlot.MAINHAND});
	}

	@Override
    public int getMinEnchantability(int enchantmentLevel) {
        return 1;
    }

    @Override
    public int getMaxEnchantability(int enchantmentLevel) {
        return this.getMinEnchantability(enchantmentLevel) + 40;
    }
}

 

Item Code:

Spoiler

public class ItemUniverseRing extends Item {
	
	public ItemUniverseRing() {
		this.setMaxStackSize(1);
	}
	
	@Override
    public int getItemEnchantability() {
        return 22;
    }
  
  //...The Rest Of My Code Probably Isn't Relevant...
}

 

 

I looked at the source code for ExNihlo 2 to see how this would be done, but the author used code that works for 1.10.2, but not 1.11.2.

EnchantmentHelper.mapEnchantmentData(this.getItemEnchantability(), new ItemStack(this));

If you could help, that would be greatly appreciated. 

Edited April 13, 2017 by RainbowLuigi281

[Draco18s]

With a min-enchantability of 41! it'll almost never get picked, as generally speaking the highest enchantment possible that can show up on an item is ~30.

You should also override canApplyAtEnchantingTable and canApply.

[RainbowLuigi281]

According to the code, the MAX-enchantability is 41, while the min-enchantability is 1.  Even after I switched those values, it still wouldn't work.  I did override canApplyAtEnchantingTable and canApply, but that also didn't work.

When I say it's not working, I mean that the enchantment levels don't show up when I put my item in, as shown below.

[Draco18s]

Is that Ring classified as a MainHand item?

[RainbowLuigi281]

I don't know exactly what classifies a "MainHand item", but I do have attributes on the item that check if the slot is equal to EntityEquipmentSlot.MAINHAND before applying them.  The ring is intended to be used as a weapon you use in your main hand, so I am assuming that the ring is classified as a "MainHand item".

 

Perhaps the key to solving the problem is to find what replaced

EnchantmentHelper.mapEnchantmentData(this.getItemEnchantability(), new ItemStack(this));

 

Edited April 13, 2017 by RainbowLuigi281
typo

[RainbowLuigi281]

I figured it out, the enchantment table calls ItemStack#isItemEnchantable, which in turn calls Item#isItemTool.  Since my item used the default implementation, it return false and not work, but after I override it to return true, it worked.