Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Best way to mod a mod?

vemacs

By vemacs
in Modder Support

 Share

Recommended Posts

vemacs Tree Puncher

vemacs

Posted
Posted

I've been trying to mod Fihgu's protection mod all morning (basically trying to change some strings), and so far, I have the deobfuscated source from BON and JD-Gui, and have modified a single class (EventHandler.java).

 

However, I'm having serious issues compiling. I've added the deobfuscated and recompiled minecraft.jar from MCP, fihgu's core mod, Forge (both src+universal), all the imports in mcp /lib to the classpath, and for the life of me, still can't get it to compile (see http://www.minecraftforge.net/forum/index.php/topic,5536.0.html).

 

Am I completely doing it wrong, and if so, how would I do it properly? I honestly don't think that reinventing the wheel is needed just to modify a single .class.

 

Thanks in advance.

 

(sorry for not providing more details, a generic answer would be preferred)

Mazetar World Shaper

Mazetar

Posted
Posted

Well generally decompilling other peoples mod's / classes is kinda something people tend to look down upon, at least if the intention is to do more than just look and learn :P

 

If it's Fihgu's mod's you are trying to decompile and modify why don't you contact him?

As far as I can see on the MC forums he is active there and you could PM him and ask for the source you need, if you explain your reasons and ask polite and nicely maybe he will help you out by giving you the part you need to look at or help you inn some other way? Generally having the permission of the mod author to decompile and play around with his source code is more accepted and thereby you would easier get help the problems you are facing while doing so :)

 

what exactly are you trying to accomplish by decompiling the files? :)

If you guys dont get it.. then well ya.. try harder...

vemacs Tree Puncher

vemacs

Posted
  • Author
Posted

Well generally decompilling other peoples mod's / classes is kinda something people tend to look down upon, at least if the intention is to do more than just look and learn :P

 

If it's Fihgu's mod's you are trying to decompile and modify why don't you contact him?

As far as I can see on the MC forums he is active there and you could PM him and ask for the source you need, if you explain your reasons and ask polite and nicely maybe he will help you out by giving you the part you need to look at or help you inn some other way? Generally having the permission of the mod author to decompile and play around with his source code is more accepted and thereby you would easier get help the problems you are facing while doing so :)

 

what exactly are you trying to accomplish by decompiling the files? :)

 

Thanks, I've PMed him, but I'm just patching some exploits related to the /lock function. I'm also patching some vulnerabilities in the login mod.

I've PMed him my patches (which should fix the issues), and I'm going to ask him for the source.

 

However, assuming that I did get the source, and the source is the exact same as the decompiled version, what would I be doing wrong if it isn't compiling?

Mazetar World Shaper

Mazetar

Posted
Posted

No the source would not be the same as the recompiled version, it will be the same as how he wrote it before he compiled it.

The difference being that you won't have any errors because of things lost or wrongly interpreted during the decompiling of the file(s).

You will get the source as he wrote it, which means since his mod is working it will work (with the MCP and Forge version he used at least) :)

 

 

If you guys dont get it.. then well ya.. try harder...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Frenchythefry
      Processor failed, invalid outputs

      By Frenchythefry · Posted

      I have no idea why it sent twice im really sorry
    • Frenchythefry
      Processor failed, invalid outputs

      By Frenchythefry · Posted

      Was launching forge for the first time and it crashed: Processor failed, invalid outputs: /home/frenchy/.local/share/PrismLauncher/libraries/net/minecraft/client/1.20.1-20230612.114412/client-1.20.1-20230612.114412-slim.jar Expected: de86b035d2da0f78940796bb95c39a932ed84834 Actual: a8fb49bc364562847d6e7e6775e3a1b3f6b2bb05 /home/frenchy/.local/share/PrismLauncher/libraries/net/minecraft/client/1.20.1-20230612.114412/client-1.20.1-20230612.114412-extra.jar Expected: 8c5a95cbce940cfdb304376ae9fea47968d02587 Actual: cf941ba69e11f5a9de15d0c319d61854c456a116 No idea why I think it's because I'm on linux or something  
    • Frenchythefry
      Processor failed, invalid outputs

      By Frenchythefry · Posted

      Game crashed on launch with:  Processor failed, invalid outputs: /home/user/.local/share/PrismLauncher/libraries/net/minecraft/client/1.20.1-20230612.114412/client-1.20.1-20230612.114412-slim.jar Expected: de86b035d2da0f78940796bb95c39a932ed84834 Actual: a8fb49bc364562847d6e7e6775e3a1b3f6b2bb05 /home/user/.local/share/PrismLauncher/libraries/net/minecraft/client/1.20.1-20230612.114412/client-1.20.1-20230612.114412-extra.jar Expected: 8c5a95cbce940cfdb304376ae9fea47968d02587 Actual: cf941ba69e11f5a9de15d0c319d61854c456a116 No idea why, but im on linux which might matter
    • Xios
      Le Meilleur Pixelmon FR

      By Xios · Posted

      PixelmonGo est un incroyable serveur Pixelmon disponible grâce à notre launcher en version 1.16.5 Ce serveur accepte les joueurs premiums comme les cracks ! Un gameplay unique vous attend.. Rejoignez nous dès maintenant ! Site: https://pixelmongo.fr/ Launcher: https://pixelmongo.fr/launcher/ Discord: https://discord.gg/pixelmongo Découvrez notre serveur minecraft Pixelmon moddé basé sur un univers mélangeant Minecraft et Pokémon. Plus de 900 Pokémon à capturer ainsi que des fusions unique au serveur, un hôtel des ventes, un monde aventure reproduisant l'aventure de sinnoh, Explorez des donjons de chaque team maléfique au début de votre aventure, accomplissez des quêtes et remportez des récompenses quotidiennes. Revivez vos meilleurs souvenirs Pokémon au sein d'une communauté multijoueur dynamique. Rejoignez le meilleur serveur minecraft pixelmon français des maintenant en téléchargeant notre launcher. Pixelmongo est la référence en serveur pixelmon en France ! Présentation Amenez votre Minecraft dans le monde des Pokémon, ou des Pokémon dans votre monde Minecraft ! Avec Pixelmon, découvrez votre monde Minecraft sous un nouvel angle. Pixelmon est un mod populaire pour Minecraft qui permet aux joueurs d'attraper, d'entraîner et de combattre des Pokémon dans le monde de Minecraft. Développé par un groupe de fans dévoués, le mod ajoute une large gamme de créatures Pokémon au jeu. Il possède des fonctionnalités et des mécanismes uniques qui en font une expérience amusante et engageante pour les joueurs de tous âges. Le mod Pixelmon est disponible pour les mondes Minecraft solo et multijoueur et peut être téléchargé et installé à l'aide de divers lanceurs et modpacks. Une fois installé, les joueurs peuvent explorer le monde et rencontrer des Pokémon dans la nature, se battre avec d'autres entraîneurs et créer leur propre équipe de créatures puissantes. L'une des fonctionnalités clés de Pixelmon est la possibilité de capturer et d'entraîner des Pokémon en utilisant diverses méthodes. Les joueurs peuvent fabriquer des Pokéballs et les utiliser pour capturer des Pokémon sauvages, qui peuvent ensuite être entraînés et améliorés au fil du temps. Chaque Pokémon a des capacités et des mouvements uniques, ce qui rend important pour les joueurs de choisir la bonne équipe de créatures pour chaque combat. Capturez des Pokémons, constituez une équipe, entraînez-les et remportez des combats contre d'autres joueurs ! Dans un univers reprenant les standards du jeu Nintendo original : Dresseurs, centres Pokémon, mais aussi fossiles et matériaux divers. Les Pokémon comme dans le jeu original sont classés par type (Insecte, Ténèbres, Dragon, Électrique, Combat, Feu, Vol, Spectre, Plante, Sol, Glace, Normal, Poison, Psy, Pierre, Acier, Eau), ce qui définira les faiblesses et les spécificités des Pokémons. Par exemple, un Pokémon de type Feu subira deux fois plus de dégâts si l'attaque du Pokémon ennemi est de type Glace. Le mod possède 900 Pokémon différents plus ou moins rares qui apparaîtront en fonction de leur environnement (jour, nuit et biomes). Les Pokémon évoluent en fonction de leur niveau (jusqu'à 100). Plus leur niveau est élevé, plus ils seront forts et auront des attaques plus puissantes. Pour augmenter le niveau de votre Pokémon, et ainsi évoluer, vous devrez combattre d'autres Pokémon et les vaincre. Plus vos adversaires sont forts, plus ils vous rapporteront de l'expérience. Les Pokémons ont également leurs propres statistiques (attaque, défense, vitesse, vitesse d'attaque et vitesse de défense). Ils peuvent également avoir des tailles et des formes différentes, et peuvent occasionnellement vous donner des objets une fois tués. Pour les capturer, vous devrez utiliser des pokéballs, qui selon leur forme seront plus ou moins efficaces. Pixelmon est un mod amusant et engageant pour Minecraft qui ajoute une touche unique et passionnante au jeu. Avec sa large gamme de fonctionnalités et de mécanismes, il offre aux joueurs des possibilités infinies d'exploration et de plaisir, ce qui en fait un choix populaire pour les fans de Minecraft et de Pokemon.  
    • OppenDev
      Trying shadow a dependency with runClient configuration

      By OppenDev · Posted

      Hi all,  I have the following issue: I'd like to parse some json using gson and rely on the (somewhat new) java record types. This is supported in gson 2.10+. Gson is already a dependency used by minecraft, however it's 2.8.x for 1.19.2 which I'm targeting at the moment. My idea was to include the newer version of the library in my mod and then shadow it so it gets used inside the scope of my mod instead of the older 2.8. This works fine for building the jar: If I decompile my mod.jar, I can see that it's correctly using the shadowed classes. However obviously when using the runClient intellj config, the shadowing doesn't get invoked. Is there any way of invoking shadow when using runClient, or am I on the wrong track and there's a better way of doing this entirely?   Thanks in advance!   Edit: After some further thinking, I've come up with this abomination:   build.gradle // New task for extracting the result of shadowJar into the classes directory // This includes our shadowed gson jar tasks.register("extractShadowJar", Copy) { // Depend on shadowJar so we always use the up to date version of the shadowed content dependsOn shadowJar from(zipTree(shadowJar.archiveFile)) { // filter to copy only our code (and ignore assets, META-INF, etc) // Also copies gson as it gets shadowed into com.oppendev.shadow.gson include "com/**" } duplicatesStrategy(DuplicatesStrategy.INCLUDE) into("$buildDir/classes/java/main") // Extract into the classes directory } // Tell gradle to invoke our new task before executing any java code. This way we ensure that we use the shadowed gson tasks.withType(JavaExec).configureEach { dependsOn(extractShadowJar) } // Shadow config shadowJar { relocate 'com.google.gson', 'com.oppendev.shadow.gson' configurations = [project.configurations.runtimeClasspath] zip64 true dependencies { include(dependency('com.google.code.gson:gson')) } } Is this a reasonable thing to do? Is this completely cursed and I should burn in dev ops hell? Is there a better way to do this? Feel free to grill me in the replies

  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept