[1.11.2] onBlockActivated() Not Working

[admiralmattbar]

Hi all,

 

I'm having trouble with my mod getting the onBlockActivated() method to do anything. With the code I have right clicking on the block does nothing. I would like to make a bush that gives you brian_jerky when you right click on it and turns into an empty bush. I figured using onBlockActivated would be the best method to do this. I added the chat as a means of testing whether or not the method activates at all. So far nothing happens when I right click on the bush.

 

package org.educraft.brianface.blockclasses;

import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.util.text.TextComponentString;
import org.educraft.brianface.init.ModBlocks;
//import org.educraft.brianface.init.ModBlocks;
import org.educraft.brianface.init.ModItems;

import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

import static sun.audio.AudioPlayer.player;

public class BlockBrianBushFull extends BlockBrianBushEmpty {
	public BlockBrianBushFull(){
		super();
		this.setTickRandomly(false); //Stops random growth
	}
	
	public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, ItemStack heldItem,
									EnumFacing side, float hitX, float hitY, float hitZ){
		
		//This makes it work on server side.
		if(!worldIn.isRemote) {

			return true;
		}
		else
		{
			EntityItem brian_jerky = new EntityItem(worldIn, playerIn.posX, playerIn.posY, playerIn.posZ,
					new ItemStack(ModItems.brian_jerky));
			brian_jerky.setNoPickupDelay();
			worldIn.spawnEntity(brian_jerky);
			playerIn.sendMessage(new TextComponentString("picking"));

			//Now the bush has no more jerky
			worldIn.setBlockState(pos, ModBlocks.brian_bush_empty.getDefaultState(), 2);
			
			return true;
		}
		
	}
}

 

Sorry if this is obvious, but I'm at a loss as to what I'm doing wrong.

[Choonster]

Your onBlockActivated method doesn't override a super method, so it will never be called unless you do so yourself. If you'd annotated the method with @Override, you would have gotten a compilation error telling you this.

 

Use your IDE to auto-generate override methods with the correct signature and annotation.

[admiralmattbar]

Thanks for the reply Choonster. The resources you've made available have been super helpful to me when I got into modding. I added the @Override method that IntelliJ recommended using ctrl-O and selecting the method from Block.java, tried the same thing in Eclipse with ctrl-space. I still have the same problem. Is this a problem with my IDE's? 

Edited May 9, 2017 by admiralmattbar

[Choonster]

10 minutes ago, admiralmattbar said:

Thanks for the reply Choonster. The resources you've made available have been super helpful to me when I got into modding.

I'm glad they've helped.

 

10 minutes ago, admiralmattbar said:

I added the @Override method that IntelliJ recommended using ctrl-O and selecting the method from Block.java, tried the same thing in Eclipse with ctrl-space. I still have the same problem. Is this a problem with my IDE's? 

Post your new code.

[MFMods]

i trust you'll fix the method signature so let me note some other details:

 

isRemote means client. just return true on client (invert the condition). create and spawn your item on the server side; call setBlockState on the server side.

 

you're clearly someone who knows this programming trade and appreciates elegance. but inheritance isn't always the way to go. you used two block ids for something that could be easily done with one block and a few states. be economical with those ids, at least for a while.

[admiralmattbar]

Hello,

 

Thanks for the help. I completely took out the isRemote check and it started working. Here's my new code. I'm still working on getting the entity to disappear when I collect the item.

 

package org.educraft.brianface.blockclasses;

import net.minecraft.util.EnumHand;
import net.minecraft.util.text.TextComponentString;
import org.educraft.brianface.init.ModBlocks;
import org.educraft.brianface.init.ModItems;

import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class BlockBrianBushFull extends BlockBrianBushEmpty {
	public BlockBrianBushFull(){
		super();
		this.setTickRandomly(false); //Stops random growth
	}

	@Override
	public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
		EntityItem brian_jerky = new EntityItem(worldIn, playerIn.posX, playerIn.posY, playerIn.posZ,
				new ItemStack(ModItems.brian_jerky));
		brian_jerky.setNoPickupDelay();
		worldIn.spawnEntity(brian_jerky);
		playerIn.sendMessage(new TextComponentString("picking"));

		//Now the bush has no more jerky
		worldIn.setBlockState(pos, ModBlocks.brian_bush_empty.getDefaultState(), 2);

		return true;
	}

}

 

[Abastro]

Now you are spawning the item on both side. You shouldn't do that, only spawn it on server thread, check if World::isRemote is false for that.

(So basically invert World::isRemote check)

[admiralmattbar]

Hello,

 

Thanks for all the help. Here's the code that works properly without spawning on both sides.

 

package org.educraft.brianface.blockclasses;

import net.minecraft.util.EnumHand;
import org.educraft.brianface.init.ModBlocks;
import org.educraft.brianface.init.ModItems;

import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class BlockBrianBushFull extends BlockBrianBushEmpty {
	public BlockBrianBushFull(){
		super();
		this.setTickRandomly(false); //Stops random growth
	}

	@Override
	public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) {
        //This makes it work on server side.
        if(worldIn.isRemote) {

            return true;
        }
        else {
            EntityItem brapple = new EntityItem(worldIn, playerIn.posX, playerIn.posY, playerIn.posZ,
                    new ItemStack(ModItems.brapple));
            brapple.setNoPickupDelay();
            worldIn.spawnEntity(brapple);

            //Now the bush has no more jerky
            worldIn.setBlockState(pos, ModBlocks.brian_bush_empty.getDefaultState(), 2);

            return true;
        }
	}

}

 

And @MFMods, I'll start working on doing this with one blockID.