Jump to content

Recommended Posts

Posted

This is help for my friend and these are his words. 

Basically, I'm trying to make it so that when I place a block, it places down 3 others which each have their own part property. So then I can save and load the part states and load up the model from blockstates properly.

Posted (edited)

@Jay Avery Says he already knows that. He wants to know how to "load up multiple properties with meta data."

 

Edit: He basically wants to know how to get the other 3 blocks of his four block "block" to break when one is broken. He's bad at explaining and I should have done this before.

Edited by Espeonstar
Posted

What exactly do you mean by "as a group"? There are a lot of different things involved in blocks - placing, breaking, activating, associated items, etc. All of those things happen independently, so have to be handled differently depending on exactly what you want to achieve.

 

I'm not frustrated, but slightly confused - why isn't your friend posting here? It would be a lot easier to give help if we could see the current code and get precise details on what isn't (and is) working as intended.

Posted

He doesn't have internet, so he texts me to search for things. Rarely he manages to get internet by going with his mother to work. He's replying now, and his texts take a while to send.

Posted (edited)

His words. "Hey, I am not posting since I am not online. But here is the break down of what I'm trying to do. Consider a bed. You have two blocks that are codependent each other. I am trying to do this, but with 4 blocks instead. Each block "part" will have a direction IProperty and a part IProperty. What I am trying to do is load up the part correctly through meta data so that I can essentially have it as it was when I placed it. I have basically no idea how metadata should be handled although I kind of get the math behind it. If I can figure out this, I can in turn do the rest of what I need (simultaneous block breaking, same inventory use, blah blah). Currently only saving the direction metadata but I have no clue on how to add my part metadata to that."

 

Edit: If you want, I can just completely copy and paste all your answers and his replies so it's less, stupid, with me in the mix. :P

Edited by Espeonstar
Posted

Okay, so he needs to learn how to use blockstates and metadata to save them. Start with the forge docs. Then inspect the vanilla code for blocks which store similar kinds of state information (hint: beds, doors).

 

Ultimately there isn't any maths involved in metadata. It's just a way of representing the different possible states of the block in the form of a single number (between 0 and 16). If you want, you can manually translate them by checking individual conditions: "if this particular state, return 5, if that particular state, return 6", and so on (and the same in reverse). That's just slightly awkward and verbose, so it's more concise to use some simple multiplication and bitwise operations to do the same thing if possible - but if that's confusing them start by doing it the verbose way so you can understand what you're doing.

 

Also note that if you have more than 16 different possible states, you won't be able to store them in metadata - you'd have to use a TileEntity to store them instead.

Posted
"I tried using Tile Entities but I wasn't sure when the data saved, since it always seemed to reset my data. Also, I've been looking at fences and beds to understand how they save the metadata, but I don't understand fully how it works. Blockststes I understand, it's just the metadata hell I don't get. Any links where I can understand it more?"
Posted

I gave a link to the forge docs. I'm not sure what else to explain about metadata. It's just a way of translating from a blockstate to a number and back again, it's essentially a simple shorthand. There are two methods you need to override: getStateFromMeta and getMetaFromState. In the first one, you get a number and return a blockstate, in the second you get a blockstate and return a number. All you need to do is make sure that those two methods do the inverse of each other: that if you get X number in getStateFromMeta and return state Y, then if you get state Y in getMetaFromState you return number X. You can use whatever technique you like to translate your states to numbers and back again, it just needs to be self-consistent in order for the blocks to be saved and loaded correctly.

Posted
"Ah OK, that makes sense haha. Then if I want to do more than 16 states, I would use TileEntities and their writeToNBT()? If so, when does that get called? Guessing on game end, but if it does, the state I saved to it never changes even when written to NBT as a string. Most LIKELY did it wrong or set it wrong. :/"
Posted

Yes, if you store information in a TileEntity you'll need to use writeToNBT and readFromNBT to store and retrieve the data. It's saved when the world is saved/quit, and reloaded with the world. If you want the TE data to influence the block's actual state in the world (e.g. for rendering purposes), you'll also need to override getActualState in the block class. In that method, you retrieve the information stored in your TE, and return the applicable blockstate based on that.

Posted

One last thing @Jay Avery

"OK so, successfully saved and loaded the states with metadata! Woot! But now I am seeing about how to set the TileEntity data so I can use more states later. I am unsure of how to access the TileEntity of a block I create (I place a block down and it auto creates the 3 other blocks). I have a reference to the tile entity in the block, but how can I access that to change the data?"
Posted

You shouldn't store a reference to the TE in the block - a block is a singleton so there's only ever one instance, but a new TE instance is created for every block of that type in the world. To get a TE at a certain position you just use world#getTileEntity.

Posted

Assuming that the TileEntity data is properly synced with the client.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
    • Hi here is an update. I was able to fix the code so my mod does not crash Minecraft. Please understand that I am new to modding but I honestly am having a hard time understanding how anyone can get this to work without having extensive programming and debugging experience as well as searching across the Internet, multiple gen AI bots (claude, grok, openai), and examining source code hidden in the gradle directory and in various github repositories. I guess I am wrong because clearly there are thousands of mods so maybe I am just a newbie. Ok, rant over, here is a step by step summary so others can save the 3 days it took me to figure this out.   1. First, I am using forge 54.1.0 and Minecraft 1.21.4 2. I am creating a mod to add a shotgun to Minecraft 3. After creating the mod and compiling it, I installed the .jar file to the proper directory in Minecraft and used 1.21.4-forge-54.1.0 4. The mod immediately crashed with the error: Caused by: java.lang.NullPointerException: Item id not set 5. Using the stack trace, I determined that the Exception was being thrown from the net.minecraft.world.item.Item.Properties class 6. It seems that there are no javadocs for this class, so I used IntelliJ which was able to provide a decompiled version of the class, which I then examined to see the source of the error. Side question: Are there javadocs? 7. This method, specifically, was the culprit: protected String effectiveDescriptionId() {      return this.descriptionId.get(Objects.requireNonNull(this.id, "Item id not set"));  } 8. Now my quest was to determine how to set this.id. Looking at the same source file, I determined there was another method:  public Item.Properties setId(ResourceKey<Item> pId) {             this.id = pId;             return this;   } 9. So now, I need to figure out how to call setId(). This required working backwards a bit. Starting from the constructor, I stubbed out the variable p which is of type Item.Properties public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); Rather than putting this all on one line, I split it up for readability like this: private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); Here is was the missing function, setId(), which takes a type of ResourceKey<Item>. My next problem is that due to the apparent lack of documentation (I tried searching the docs on this site) I could not determine the full import path to ResourceKey. I did some random searching on the Internet and stumbled across a Github repository which gave two clues: import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; Then I created the rk variable like this: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); And now putting it all together in order: private static ResourceKey<Item> rk = ResourceKey.create(Registries.ITEM, ResourceLocation.parse("modid:shotgunmod")); private static final Item.Properties p = new Item.Properties().useItemDescriptionPrefix().setId(rk); public static final RegistryObject<Item> SHOTGUN = ITEMS.register("shotgun", () -> new ShotgunItem(p)); This compiled and the mod no longer crashes. I still have more to do on it, but hopefully this will save someone hours. I welcome any feedback and if I missed some obvious modding resource or tutorial that has this information. If not, I might suggest we add it somewhere for people trying to write a mod that doesn't crash. Thank you !!!  
    • I will keep adding to this thread with more information in case anyone can help, or at the very least I can keep my troubleshooting organized. I decided to downgrade to 54.1.0 in the hopes that this would fix the issue but it didn't. At least now I am on a "recommended" version. The crash report did confirm my earlier post that the Exception is coming from effectiveDescriptionId(). I'll continue to see if I can find a way to set the ID manually.   Caused by: java.lang.NullPointerException: Item id not set         at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item$Properties.effectiveDescriptionId(Item.java:465) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/net.minecraft.world.item.Item.<init>(Item.java:111) ~[forge-1.21.4-54.1.0-client.jar!/:?]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ShotgunItem.<init>(ShotgunItem.java:19) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/com.example.shotgunmod.ModItems.lambda$static$0(ModItems.java:15) ~[shotgunmod-1.0.0.jar!/:1.0.0]         at TRANSFORMER/[email protected]/net.minecraftforge.registries.DeferredRegister$EventDispatcher.lambda$handleEvent      
    • It just randomly stop working after a rebooted my dedicated server PLEASE HELP!   com.google.gson   Failed to start the minecraft server com.google.gson.JsonSyntaxException: Expected a com.google.gson.JsonObject but was com.google.gson.JsonPrimitive; at path $  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.