I want to change Event Listener of glass bottle. This EL does glass bottle turn into exp bottle. I have already write code, but it isn't works.

protected ItemStack turnBottleIntoItem(ItemStack originalstack, EntityPlayer player, ItemStack stack)
    {
		originalstack.shrink(1);

        if (p_185061_1_.isEmpty())
        {
            return stack;
        }
        else
        {
            if (!player.inventory.addItemStackToInventory(stack))
            {
                player.dropItem(stack, false);
            }

            return originalstack;
        }
    }
	
	@EventHandler
	public void onItemRightClick(PlayerInteractEvent.RightClickItem event){
		Notifier.info("Event Called", "Bottle");
		if(event.getItemStack() == new ItemStack(Items.GLASS_BOTTLE)){
			if(event.getEntityPlayer().experienceLevel >= 1){
				event.getEntityPlayer().removeExperienceLevel(1);
				event.getEntityPlayer().setHealth(event.getEntityPlayer().getHealth()-0.5f);
				turnBottleIntoItem(event.getItemStack(), event.getEntityPlayer(), new ItemStack(Items.EXPERIENCE_BOTTLE, 4));
			}else{
				event.getEntityPlayer().setHealth(event.getEntityPlayer().getHealth()-0.5f);
			}
		}
	}

 

Please help me!

Edited June 13, 20178 yr by IvanSteklow
Solved

Take a look at the forge documentation on events. For a non-static event handler method, you need the @SubscribeEvent annotation, and to register an instance on the MinecraftForge.EVENT_BUS. The @EventHandler annotation is only for FML lifecycle events (preInit, init, etc) in your main @Mod class.

@Mod.EventHandler is only for FML lifecycle events that extend net.minecraftforge.fml.common.event.FMLEvent, e.g. FMLPreInitializationEvent or FMLServerStartedEvent and only works in your @Mod class.

 

@SubscribeEvent is used for gameplay events that extend net.minecraftforge.fml.common.eventhandler.Event, e.g. PlayerInteractEvent.RightClickItem or TickEvent.ServerTickEvent.

 

Forge's documentation explains events in more detail here.

 

The ItemStack returned by PlayerInteractEvent#getItemStack will never be reference equal to an ItemStack you've just created, because they're not the same object (which is what the == operator checks). To compare ItemStacks, either get the Item, metadata, etc. and compare those or use the static equality methods in the ItemStack class. Since you're only checking the Item, use ItemStack#getItem to get the Item and check if it's equal to (==) Items.GLASS_BOTTLE.

Edited June 13, 20178 yr by Choonster

7 minutes ago, Choonster said:

@Mod.EventHandler is only for FML lifecycle events that extend net.minecraftforge.fml.common.event.FMLEvent, e.g. FMLPreInitializationEvent or FMLServerStartedEvent and only works in your @Mod class.

 

@SubscribeEvent is used for gameplay events that extend net.minecraftforge.fml.common.eventhandler.Event, e.g. PlayerInteractEvent.RightClickItem or TickEvent.ServerTickEvent.

 

Forge's documentation explains events in more detail here.

 

The ItemStack returned by PlayerInteractEvent#getItemStack will never be reference equal to an ItemStack you've just created, because they're not the same object (which is what the == operator checks). To compare ItemStacks, either get the Item, metadata, etc. and compare those or use the static equality methods in the ItemStack class. Since you're only checking the Item, use ItemStack#getItem to get the Item and check if it's equal to (==) Items.GLASS_BOTTLE.

 

I changed code, but it doesn't work

 

EventListener.java

public class EventListener {

	protected ItemStack turnBottleIntoItem(ItemStack originalstack, EntityPlayer player, ItemStack stack)
    {
		originalstack.shrink(1);

        if (originalstack.isEmpty())
        {
            return stack;
        }
        else
        {
            if (!player.inventory.addItemStackToInventory(stack))
            {
                player.dropItem(stack, false);
            }

            return originalstack;
        }
    }
	
	@SubscribeEvent
	public void onItemRightClick(PlayerInteractEvent.RightClickItem event){
		Notifier.info("Event Called", "Bottle");
		if(event.getItemStack().getItem() == Items.GLASS_BOTTLE){
			if(event.getEntityPlayer().experienceLevel >= 1){
				event.getEntityPlayer().removeExperienceLevel(1);
				event.getEntityPlayer().setHealth(event.getEntityPlayer().getHealth()-0.5f);
				turnBottleIntoItem(event.getItemStack(), event.getEntityPlayer(), new ItemStack(Items.EXPERIENCE_BOTTLE, 4));
			}else{
				event.getEntityPlayer().setHealth(event.getEntityPlayer().getHealth()-0.5f);
				event.getEntityPlayer().sendMessage(new TextComponentString("Not enough levels! Minimum: 1").setStyle(new Style().setColor(TextFormatting.YELLOW)));
			}
		}
	}
	
}

 

ModCore.java

@EventHandler
	public void preInit(FMLPreInitializationEvent e){
		Notifier.info("Pre Initialization event started successfully", Refs.NAME);
		MinecraftForge.EVENT_BUS.register(new EventListener().getClass());
	}

 

What's wrong?

Just now, IvanSteklow said:

What's wrong?

 

You're registering the Class with the event bus, but your event handler method isn't static. If you register the Class, you need to use a static method. If you register an instance, you need to use an instance method. The documentation explains this.

 

There's no reason to create a new object of a known class and immediately call Object#getClass on it, just use a class literal.

23 minutes ago, Choonster said:

 

You're registering the Class with the event bus, but your event handler method isn't static. If you register the Class, you need to use a static method. If you register an instance, you need to use an instance method. The documentation explains this.

 

There's no reason to create a new object of a known class and immediately call Object#getClass on it, just use a class literal.

Thank you!