[1.11.2] Rotate player arms

[fcelon]

Hello,

Is there any way how to rotate player arms without creating custom player model? I am sure there has to be some way, because I think Quark mod does exactly that during emote animations. I already tried this:

@SideOnly(Side.CLIENT)
@SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)
public void onEvent(RenderPlayerEvent.Post event)
{
	EntityPlayer player = event.getEntityPlayer();
	if (player.getActiveItemStack().getItem() instanceof ItemSpear)
	{
		event.getRenderer().getMainModel().bipedRightArm.rotateAngleX = 5;
	}
}

It seems everything is right, but it does not do anything.

Thanks for help.

Edited June 23, 2017 by fcelon
Forgot to write game version

[ctbe]

Did you manage to solve it? I am also interested in knowing how to achieve this.

 

I did notice that the comparison with instanceof always yields false since you are asking if Item (what is returned) is an instance of ItemSpear. It is not. ItemSpear may be an instance of Item, not the other way around. Meaning the code inside the if will never run. However, I tried by making a comparison with an item's unlocalized name and the code ran, yet it didn't do anything like you said.

 

I don't understand why rotateAngleX, or rotateAngleY, or rotateAngleZ do nothing. The method renderWithRotation does nothing either. Only when one modifies the offsetX, offsetY, or offsetZ fields one sees the arm offsetting away, but not rotating.

 

Edit: Fix your code in the if statement. Use

 

player.getHeldItem(EnumHand.MAIN_HAND).getUnlocalizedName().toLowerCase().contains("ItemSpear".toLowerCase())

 

and replace "ItemSpear" with the unlocalized name of your item. Then the code inside the if will run. But like I said, the code still does nothing. It does not rotate the player's arm.

 

 

Edited June 25, 2017 by ctbe

[Choonster]

19 hours ago, ctbe said:

I did notice that the comparison with instanceof always yields false since you are asking if Item (what is returned) is an instance of ItemSpear. It is not. ItemSpear may be an instance of Item, not the other way around. Meaning the code inside the if will never run. However, I tried by making a comparison with an item's unlocalized name and the code ran, yet it didn't do anything like you said.

 

ItemSpear is (presumably) a subclass of Item, so it's entirely possible for a method with Item as the return type to return an instance of ItemSpear. Checking if an ItemSpear is an instance of Item is pointless, since it will always be true.

 

That part of the OP's code is correct. Using unlocalised names for anything except translation/display purposes is a bad idea, since they're not unique and can change at any time.

Edited June 26, 2017 by Choonster

[ctbe]

Thanks for the information. I will not use the unlocalized name for it then.

 

After debugging deeper I take that what you say is correct. While debugging I get that player.getActiveItemStack().getItem() is returning an object of class ItemAir. No matter what item the player has in in the active hand or in the rest of the inventory. Don't know why.

 

I am sad no one knows how to achieve the rotation of the arm. I have tried so many things with no success. Modifying the offset works, but modifying the rotation doesn't. At one point I don't even know how, but I got all the mobs to float in the air and swing as the player walked. They were moving with the same rotation of the player's arm as it walked. It was funny to watch the sheeps float and swing in the air in synchrony as I walked. But the player's arm where unaffected.

Edited June 27, 2017 by ctbe
typo in code

[Guest]

What happens if you set the rotation in RenderPlayerEvent.Pre and set it back to the original value in RenderPlayerEvent.Post?

[ctbe]

3 hours ago, XFactHD said:

What happens if you set the rotation in RenderPlayerEvent.Pre and set it back to the original value in RenderPlayerEvent.Post?

Finished trying. Nothing happens :(.

 

But thanks to that tip I debugged on both events, Pre and Post and noticed that once one sets the rotation to whatever value, as soon as the event ends, the rotation value that one had set gets overridden by the Minecraft animation. When the player stands stills the arms sort of move a little. It is that small almost unnoticeable movement that is overriding the values one sets manually.

[fcelon]

I made sme progress in it.

@SideOnly(Side.CLIENT)
	@SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)
	public void onEvent(RenderPlayerEvent.Post event)
	{
		EntityPlayer player = event.getEntityPlayer();
		if (player.getHeldItemMainhand() == ItemStack.EMPTY)
		{
			event.getRenderer().getMainModel().bipedRightArm.isHidden=false;
			event.getRenderer().getMainModel().bipedRightArm.rotateAngleX = X;
			event.getRenderer().getMainModel().bipedRightArm.rotateAngleY = Y;
			event.getRenderer().getMainModel().bipedRightArm.rotateAngleZ = Z;
			event.getRenderer().getMainModel().bipedRightArm.renderWithRotation(0.0625F);
		}
	}
	
	@SideOnly(Side.CLIENT)
	@SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)
	public void onEvent(RenderPlayerEvent.Pre event)
	{
		EntityPlayer player = event.getEntityPlayer();
		if (player.getHeldItemMainhand() == ItemStack.EMPTY)
		{
			event.getRenderer().getMainModel().bipedRightArm.isHidden=true;
		}
	}

Now it seems I can mess with the angles. Unfortunately, the arm is being rendered in wrong spot and I don't know, how to fix it.

[fcelon]

I have tried messing with the values and it seems the arm now renders in the right spot.

@SideOnly(Side.CLIENT)
	@SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)
	public void onEvent(RenderPlayerEvent.Pre event)
	{
		event.getRenderer().getMainModel().bipedRightArm.isHidden=true;
	}

@SideOnly(Side.CLIENT)
	@SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)
	public void onEvent(RenderPlayerEvent.Post event)
	{
		EntityPlayer player = event.getEntityPlayer();
		event.getRenderer().getMainModel().bipedRightArm.isHidden=false;
		event.getRenderer().getMainModel().bipedRightArm.rotationPointZ = -MathHelper.sin((float) Math.toRadians(player.renderYawOffset)) * 5.0F;
		event.getRenderer().getMainModel().bipedRightArm.rotationPointY = 20;
		event.getRenderer().getMainModel().bipedRightArm.rotationPointX = -MathHelper.cos((float) Math.toRadians(player.renderYawOffset)) * 5.0F;
		event.getRenderer().getMainModel().bipedRightArm.rotateAngleX = (float) X;
		event.getRenderer().getMainModel().bipedRightArm.rotateAngleY = (float) -Math.toRadians(player.renderYawOffset);
		event.getRenderer().getMainModel().bipedRightArm.rotateAngleZ = (float) Z;
		event.getRenderer().getMainModel().bipedRightArm.renderWithRotation(0.0625F);
		event.getRenderer().getMainModel().bipedRightArm.rotationPointY = 2;
	}

However, it only works if player's hand is empty. If player is holding any item, texture of the arm starts to look realy wierd.

[Pokegamer129]

I have a question similar to this. Is there any way to be able to make a mod with a player's arms adjusted when they are idle? I would like a pose for my friend, but I don't know how. She likes fashion, so the idle would look like this. I would also know how to do this in McCreator.

Edited April 9, 2018 by Pokegamer129

[Pokegamer129]

Oh, and just so you know, this is an armor stand command, it won't work on players. And along with the mod help, can you make it look like real life as well?

[Draco18s]

27 minutes ago, Pokegamer129 said:

can you make it look like real life

What does this even mean

[Pokegamer129]

I mean, Minecraft in real life. Imagine that. That is what I mean.

[Draco18s]

1 minute ago, Pokegamer129 said:

I mean, Minecraft in real life. Imagine that. That is what I mean.

That still doesn't make any sense.

[Pokegamer129]

- _ - I mean making Minecraft like the world you see! Not blocky, looking like real life humans!

[Draco18s]

No, that can't be done easily.

[Pokegamer129]

Yeah, that would take time, but there might be a way...

[Pokegamer129]

I know how Python, Java, and Javascript work.

[Pokegamer129]

And who quoted that "You should get off the internet and grab a creeper plushy because you're 7 years old"? And who was he/she saying that to? Because if it was for me, I'm not 7 years old. How would I know this if I was 7? 

[Pokegamer129]

And also, that's an invalid code. You forgot the console.log() and the else in the if code. Why else would it be called the if else statement?

[Pokegamer129]

I know that pic was a joke.

[desht]

17 hours ago, diesieben07 said:

Unfortunately this is not how programming works:

Minecraft.enablePhotoRealisiticGraphics()

 

See also:

Damn, I knew the PneumaticCraft drone code was more complex than it needed to be.  This'll make the mod way smaller!