[1.12] How to register models for items with meta?

[WildHeart]

Hello, I encountered a problem when migrating to 1.12, something seems to have happened with the registration of the options the subject with metadata. I use:

ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName() + "_" + name, "inventory"));
ModelBakery.registerItemVariants(item, new ResourceLocation(Reference.MODID, item.getRegistryName() + "_" + name));

for register models. How to fix?

[Choonster]

This hasn't changed. If it's not working, there should be an error in the FML log telling you what went wrong.

 

If you can't figure it out, post your code and the FML log.

 

One thing that has changed is the order of events: Registry events are now fired after preInit instead of before preInit. If you register everything in the appropriate registry event, you shouldn't need to worry about this.

 

Side note: ModelLoader.setCustomModelResourceLocation automatically calls ModelBakery.registerItemVariants, you don't need to call it yourself.

[WildHeart]

  On 6/29/2017 at 10:54 AM, Choonster said:

This hasn't changed. If it's not working, there should be an error in the FML log telling you what went wrong.

 

If you can't figure it out, post your code and the FML log.

 

One thing that has changed is the order of events: Registry events are now fired after preInit instead of before preInit. If you register everything in the appropriate registry event, you shouldn't need to worry about this.

 

Side note: ModelLoader.setCustomModelResourceLocation automatically calls ModelBakery.registerItemVariants, you don't need to call it yourself.

Expand  

So, i use my old code:

Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, meta, new ModelResourceLocation(item.getRegistryName() + "_" + name, "inventory"));
ModelBakery.registerItemVariants(item, new ResourceLocation(item.getRegistryName() + "_" + name));

And he not work. 1.11.2 in this code works and is already on 1.12 no. latest.log

[Jay Avery]

Where are you calling your model registration code? Is it actually being executed?

[WildHeart]

  On 6/29/2017 at 2:09 PM, Jay Avery said:

Where are you calling your model registration code? Is it actually being executed?

Expand  

In init method. Yes the code is runs.

[larsgerrits]

You should register models in the ModelRegistryEvent.

[WildHeart]

  On 6/29/2017 at 2:25 PM, larsgerrits said:

You should register models in the ModelRegistryEvent.

Expand  

What if you the old-fashioned way?

[larsgerrits]

  On 6/29/2017 at 2:26 PM, WildHeart said:

What if you the old-fashioned way?

Expand  

You should update to the registry events.

[Choonster]

  On 6/29/2017 at 1:18 PM, WildHeart said:

So, i use my old code:

Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, meta, new ModelResourceLocation(item.getRegistryName() + "_" + name, "inventory"));
ModelBakery.registerItemVariants(item, new ResourceLocation(item.getRegistryName() + "_" + name));

And he not work. 1.11.2 in this code works and is already on 1.12 no. latest.log

Expand  

 

The FML log is fml-client-latest.log, not latest.log.

 

ModelLoader methods need to be called in ModelRegistryEvent (or preInit, but that's not recommended). They won't work if called in init or later.

 

If you want help, post more of your code. We need to see when you're registering your models.

Edited June 29, 2017 by Choonster

[WildHeart]

  On 6/29/2017 at 2:57 PM, Choonster said:

 

The FML log is fml-client-latest.log, not latest.log.

 

ModelLoader methods need to be called in ModelRegistryEvent (or preInit, but that's not recommended). They won't work if called in init or later.

 

If you want help, post more of your code. We need to see when you're registering your models.

Expand  

Im not have a fml-client-latest.log

 

Code in ItemsInit class:

    public void renderRegister()
    {
        for(final EnumType type : EnumType.values())
        {
            this.setRender(new ItemGreen(), type.getMeta(), type.getName());
        }
    }

    @SideOnly(Side.CLIENT)
    private void setRender(Item item, final int meta, final String name)
    {
        Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, meta, new ModelResourceLocation(item.getRegistryName() + "_" + name, "inventory"));
        ModelBakery.registerItemVariants(item, new ResourceLocation(item.getRegistryName() + "_" + name));
    }

 

Code in ClientProxy class:

ItemsInit.INSTANCE.renderRegister();

 

Code in Main class:

    @Mod.EventHandler
    private void init(final FMLInitializationEvent e)
    {
        proxy.init(e);
    }

 

Edited June 29, 2017 by WildHeart

[Choonster]

  On 6/29/2017 at 3:09 PM, WildHeart said:

Im not have a fml-client-latest.log

Expand  

 

That's strange. I'm not sure why the FML log wouldn't be created.

 

If you use ModelLoader.setCustomModelResourceLocation in ModelRegistryEvent, do you get any model errors in the log? Do your items render as the missing model (pink and black cube with the model location string overlayed) or as the desired model with the missing texture (pink and black squares)?

 

Edit: I just noticed you're creating multiple new ItemGreen instances in the renderRegister method, don't do this. Items (like other IForgeRegistryEntry singletons) need to be created once and registered in RegistryEvent.Register<Item>. You need to use the same Item instance that you registered when registering models.

 

This is probably the source of your problems.

Edited June 29, 2017 by Choonster

[WildHeart]

  On 6/29/2017 at 3:20 PM, Choonster said:

 

That's strange. I'm not sure why the FML log wouldn't be created.

 

If you use ModelLoader.setCustomModelResourceLocation in ModelRegistryEvent, do you get any model errors in the log? Do your items render as the missing model (pink and black cube with the model location string overlayed) or as the desired model with the missing texture (pink and black squares)?

Expand  

By the way, another bug, does not display the text object(which was introduced in 1.11). The model uses variation

[Choonster]

If you missed it, please see the edit to my previous post. You're registering models for multiple instances of ItemGreen instead of the single instance you registered.

[WildHeart]

  On 6/29/2017 at 3:32 PM, Choonster said:

If you missed it, please see the edit to my previous post. You're registering models for multiple instances of ItemGreen instead of the single instance you registered.

Expand  

There is progress, put this code in the event and my items and variations began to appear.

    @SubscribeEvent
    public void model(ModelRegistryEvent e)
    {
        for(final EnumType type : EnumType.values())
        {
            ModelLoader.setCustomModelResourceLocation(ItemsInit.GREEN, type.getMeta(), new ModelResourceLocation(ItemsInit.GREEN.getRegistryName() + "_" + type.getName(), "inventory"));
        }
    }

About the new instance, I accidentally ordered new ItemGreen when I added the code here. And so I have everything as it should be, in a variable.

 

Edit:

But still for me the innovation in the form of adding models into the event as it is not very practical, I would like the old-fashioned register.

Edited June 29, 2017 by WildHeart

[Choonster]

So it's working now?

[WildHeart]

  On 6/29/2017 at 3:38 PM, Choonster said:

So it's working now?

Expand  

If that's the event then Yes, but if the normal registration no. Check the edit to my previous post.

[Alpvax]

  On 6/29/2017 at 3:37 PM, WildHeart said:

But still for me the innovation in the form of adding models into the event as it is not very practical, I would like the old-fashioned register.

Expand  

 

What is not practical about it? It is the new method for a reason, the old one was rather buggy and often didn't work correctly.

[WildHeart]

  On 6/29/2017 at 3:50 PM, Alpvax said:

 

What is not practical about it? It is the new method for a reason, the old one was rather buggy and often didn't work correctly.

Expand  

Maybe...