Jump to content

[1.12] How to register models for items with meta?


WildHeart

Recommended Posts

Hello, I encountered a problem when migrating to 1.12, something seems to have happened with the registration of the options the subject with metadata. I use:

ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(item.getRegistryName() + "_" + name, "inventory"));
ModelBakery.registerItemVariants(item, new ResourceLocation(Reference.MODID, item.getRegistryName() + "_" + name));

for register models. How to fix?

Link to comment
Share on other sites

This hasn't changed. If it's not working, there should be an error in the FML log telling you what went wrong.

 

If you can't figure it out, post your code and the FML log.

 

One thing that has changed is the order of events: Registry events are now fired after preInit instead of before preInit. If you register everything in the appropriate registry event, you shouldn't need to worry about this.

 

Side note: ModelLoader.setCustomModelResourceLocation automatically calls ModelBakery.registerItemVariants, you don't need to call it yourself.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

2 hours ago, Choonster said:

This hasn't changed. If it's not working, there should be an error in the FML log telling you what went wrong.

 

If you can't figure it out, post your code and the FML log.

 

One thing that has changed is the order of events: Registry events are now fired after preInit instead of before preInit. If you register everything in the appropriate registry event, you shouldn't need to worry about this.

 

Side note: ModelLoader.setCustomModelResourceLocation automatically calls ModelBakery.registerItemVariants, you don't need to call it yourself.

So, i use my old code:

Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, meta, new ModelResourceLocation(item.getRegistryName() + "_" + name, "inventory"));
ModelBakery.registerItemVariants(item, new ResourceLocation(item.getRegistryName() + "_" + name));

And he not work. 1.11.2 in this code works and is already on 1.12 no. latest.log

Link to comment
Share on other sites

You should register models in the ModelRegistryEvent.

  • Like 1

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

1 minute ago, WildHeart said:

What if you the old-fashioned way?

You should update to the registry events.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

1 hour ago, WildHeart said:

So, i use my old code:


Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, meta, new ModelResourceLocation(item.getRegistryName() + "_" + name, "inventory"));
ModelBakery.registerItemVariants(item, new ResourceLocation(item.getRegistryName() + "_" + name));

And he not work. 1.11.2 in this code works and is already on 1.12 no. latest.log

 

The FML log is fml-client-latest.log, not latest.log.

 

ModelLoader methods need to be called in ModelRegistryEvent (or preInit, but that's not recommended). They won't work if called in init or later.

 

If you want help, post more of your code. We need to see when you're registering your models.

Edited by Choonster

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

16 minutes ago, Choonster said:

 

The FML log is fml-client-latest.log, not latest.log.

 

ModelLoader methods need to be called in ModelRegistryEvent (or preInit, but that's not recommended). They won't work if called in init or later.

 

If you want help, post more of your code. We need to see when you're registering your models.

Im not have a fml-client-latest.log

 

Code in ItemsInit class:

    public void renderRegister()
    {
        for(final EnumType type : EnumType.values())
        {
            this.setRender(new ItemGreen(), type.getMeta(), type.getName());
        }
    }

    @SideOnly(Side.CLIENT)
    private void setRender(Item item, final int meta, final String name)
    {
        Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, meta, new ModelResourceLocation(item.getRegistryName() + "_" + name, "inventory"));
        ModelBakery.registerItemVariants(item, new ResourceLocation(item.getRegistryName() + "_" + name));
    }

 

Code in ClientProxy class:

ItemsInit.INSTANCE.renderRegister();

 

Code in Main class:

    @Mod.EventHandler
    private void init(final FMLInitializationEvent e)
    {
        proxy.init(e);
    }

 

Screenshot_2.png

Edited by WildHeart
Link to comment
Share on other sites

11 minutes ago, WildHeart said:

Im not have a fml-client-latest.log

 

That's strange. I'm not sure why the FML log wouldn't be created.

 

If you use ModelLoader.setCustomModelResourceLocation in ModelRegistryEvent, do you get any model errors in the log? Do your items render as the missing model (pink and black cube with the model location string overlayed) or as the desired model with the missing texture (pink and black squares)?

 

Edit: I just noticed you're creating multiple new ItemGreen instances in the renderRegister method, don't do this. Items (like other IForgeRegistryEntry singletons) need to be created once and registered in RegistryEvent.Register<Item>. You need to use the same Item instance that you registered when registering models.

 

This is probably the source of your problems.

Edited by Choonster

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

5 minutes ago, Choonster said:

 

That's strange. I'm not sure why the FML log wouldn't be created.

 

If you use ModelLoader.setCustomModelResourceLocation in ModelRegistryEvent, do you get any model errors in the log? Do your items render as the missing model (pink and black cube with the model location string overlayed) or as the desired model with the missing texture (pink and black squares)?

By the way, another bug, does not display the text object(which was introduced in 1.11). The model uses variation

2017-06-29_18.27.59.png

Link to comment
Share on other sites

If you missed it, please see the edit to my previous post. You're registering models for multiple instances of ItemGreen instead of the single instance you registered.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

8 minutes ago, Choonster said:

If you missed it, please see the edit to my previous post. You're registering models for multiple instances of ItemGreen instead of the single instance you registered.

There is progress, put this code in the event and my items and variations began to appear.

    @SubscribeEvent
    public void model(ModelRegistryEvent e)
    {
        for(final EnumType type : EnumType.values())
        {
            ModelLoader.setCustomModelResourceLocation(ItemsInit.GREEN, type.getMeta(), new ModelResourceLocation(ItemsInit.GREEN.getRegistryName() + "_" + type.getName(), "inventory"));
        }
    }

About the new instance, I accidentally ordered new ItemGreen when I added the code here. And so I have everything as it should be, in a variable.

 

Edit:

But still for me the innovation in the form of adding models into the event as it is not very practical, I would like the old-fashioned register.

Edited by WildHeart
Link to comment
Share on other sites

12 minutes ago, WildHeart said:

But still for me the innovation in the form of adding models into the event as it is not very practical, I would like the old-fashioned register.

 

What is not practical about it? It is the new method for a reason, the old one was rather buggy and often didn't work correctly.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello there! I am trying to make custom dimensions for a modpack I am making in an older minecraft version, 1.16.5. I like that version and it has a few other mods that have not been updated that I would still like to use. Anyway, I am having a terrible time with getting my dimension to work and have tried using code from other peoples projects to at least figure out what I'm supposed to be doing but it has not been as helpful as I would have liked. If anyone could help that would be greatly appreciated! Here is my github with all the code as I am using it: https://github.com/BladeColdsteel/InvigoratedDimensionsMod I have also included the last log, https://pastebin.com/zX9vsDSq, I had when I tried to load up a world, let me know if there is anything else I should send though, thank you!
    • Whether you are a fan of Hypixel Bedwars, SkyWars and PvP gamemodes like that, well you would enjoy this server! We have a very fun and unique style of PvP that a lot of our players really enjoy and we want to bring this server to more players like you! Yes you reading this post haha. Introducing, the Minezone Network, home of SUPER CRAFT BLOCKS. We've been working on this server for over 4 years now. Here is what we have to offer: SUPER CRAFT BLOCKS: This has 3 different gamemodes you can play, Classic, Duels and Frenzy. Each mode offers over 60 kits to choose from, along with a total of over 60 maps, allowing for various different playstyles on each map. There are also random powerups that spawn on the map which can include Health Pots, Bazookas, Nukes, Extra Lives and way way more! There is also double jump in this gamemode as well, which makes PvP a lot more fun & unique. You only need a minimum of 2 players to start any mode! Classic: Choose a kit, 5 lives for each player, fight it out and claim the #1 spot! Look out for lightning as they can spawn powerups to really give you an advantage in the game! Duels: Fight against another random player or one of your friends and see who is the best! Frenzy: Your kit is randomly selected for you, each life you will have a different kit. You can fight with up to 100 players in this mode and lets see who will be the best out of that 100! All the other stuff from Classic/Duels apply to this mode as well like powerups. We have 2 ranks on this server too, VIP and CAPTAIN which has a bunch of different perks for SCB and other things like Cosmetics and more.   SERVER IP: If this server has caught your interest in any way, please consider joining and you will NOT regret it! Bring some of your friends online for an even better experience and join in on the fun at: IP: minezone.club Hope to see you online!   SERVER TRAILER: https://www.youtube.com/watch?v=0phpMgu1mH0
    • The mod give new blocks  
    • I will a Mode for 1.21 in this Mod give new block, items and dimensions   
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.