Jump to content
View in the app

A better way to browse. Learn more.
Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.
Currently supported: All versions

Fire RegistryEvent.Register<IRecipe> after loading JSON recipes

cad97
in Suggestions

Featured Replies

Posted

If my debug-crawling through the startup code is accurate, the current order is something like (trimmed to relevant items):

Quote
  • beginMinecraftLoading
    • LoaderState.PREINITIALIZATION
    • GameData::fireRegistryEvents
      • RegistryEvent.Register<Block>
      • RegistryEvent.Register<Item>
      • RegistryEvent.Register<IRecipe>
  • finishMinecraftLoading
    • "Initializing mods Phase 2"
      • CraftingHelper::loadRecipes -- loads in mod JSON recipes
      • LoaderState.INITIALIZATION

The effect of this is that during the IRecipe registration event, vanilla JSON recipes are in the registry but forge-loaded ones are not.

It would be more consistent to load all JSON recipes before firing the programmatic registration event.

 

What's the reason I want this?

During the recipe registration event, it is possible to remove vanilla JSON recipes: 

@SubscribeEvent
public static void registerRecipes(RegistryEvent.Register<IRecipe> event)
{
  ((IForgeRegistryModifiable<IRecipe>)event.getRegistry()).remove(new ResourceLocation("minecraft:anvil"));
}

With this listener registered, the minecraft:anvil recipe disappears without a trace.

Unfortunately, because mod JSON recipes' loading is far off at this point, it is not possible to remove those, because they don't exist yet.

 

Note that doing this during FMLInitializationEvent (via ForgeRegistries.RECIPES of course) removes the recipe but leads to a game crash when trying to render the recipe book.

Spoiler 

[16:58:39] [main/FATAL]: Reported exception thrown!
net.minecraft.util.ReportedException: Updating screen events
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1874) ~[Minecraft.class:?]
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1171) ~[Minecraft.class:?]
	at net.minecraft.client.Minecraft.run(Minecraft.java:436) [Minecraft.class:?]
	at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_121]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_121]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_121]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_121]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_121]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_121]
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
	at GradleStart.main(GradleStart.java:26) [start/:?]
Caused by: java.lang.IndexOutOfBoundsException: bitIndex < 0: -1
	at java.util.BitSet.get(BitSet.java:623) ~[?:1.8.0_121]
	at net.minecraft.stats.RecipeBook.containsRecipe(RecipeBook.java:35) ~[RecipeBook.class:?]
	at net.minecraft.client.gui.recipebook.RecipeList.canCraft(RecipeList.java:44) ~[RecipeList.class:?]
	at net.minecraft.client.gui.recipebook.GuiRecipeBook.lambda$updateCollections$0(GuiRecipeBook.java:176) ~[GuiRecipeBook.class:?]
	at java.util.ArrayList.forEach(ArrayList.java:1249) ~[?:1.8.0_121]
	at net.minecraft.client.gui.recipebook.GuiRecipeBook.updateCollections(GuiRecipeBook.java:174) ~[GuiRecipeBook.class:?]
	at net.minecraft.client.gui.recipebook.GuiRecipeBook.initVisuals(GuiRecipeBook.java:111) ~[GuiRecipeBook.class:?]
	at net.minecraft.client.gui.inventory.GuiCrafting.actionPerformed(GuiCrafting.java:142) ~[GuiCrafting.class:?]
	at net.minecraft.client.gui.GuiScreen.mouseClicked(GuiScreen.java:494) ~[GuiScreen.class:?]
	at net.minecraft.client.gui.inventory.GuiContainer.mouseClicked(GuiContainer.java:360) ~[GuiContainer.class:?]
	at net.minecraft.client.gui.inventory.GuiCrafting.mouseClicked(GuiCrafting.java:124) ~[GuiCrafting.class:?]
	at net.minecraft.client.gui.GuiScreen.handleMouseInput(GuiScreen.java:611) ~[GuiScreen.class:?]
	at net.minecraft.client.gui.GuiScreen.handleInput(GuiScreen.java:576) ~[GuiScreen.class:?]
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1861) ~[Minecraft.class:?]
	... 15 more
[16:58:39] [main/INFO] [STDOUT]: [net.minecraft.init.Bootstrap:printToSYSOUT:629]: ---- Minecraft Crash Report ----
// Oh - I know what I did wrong!

Time: 7/7/17 4:58 PM
Description: Updating screen events

java.lang.IndexOutOfBoundsException: bitIndex < 0: -1
	at java.util.BitSet.get(BitSet.java:623)
	at net.minecraft.stats.RecipeBook.containsRecipe(RecipeBook.java:35)
	at net.minecraft.client.gui.recipebook.RecipeList.canCraft(RecipeList.java:44)
	at net.minecraft.client.gui.recipebook.GuiRecipeBook.lambda$updateCollections$0(GuiRecipeBook.java:176)
	at java.util.ArrayList.forEach(ArrayList.java:1249)
	at net.minecraft.client.gui.recipebook.GuiRecipeBook.updateCollections(GuiRecipeBook.java:174)
	at net.minecraft.client.gui.recipebook.GuiRecipeBook.initVisuals(GuiRecipeBook.java:111)
	at net.minecraft.client.gui.inventory.GuiCrafting.actionPerformed(GuiCrafting.java:142)
	at net.minecraft.client.gui.GuiScreen.mouseClicked(GuiScreen.java:494)
	at net.minecraft.client.gui.inventory.GuiContainer.mouseClicked(GuiContainer.java:360)
	at net.minecraft.client.gui.inventory.GuiCrafting.mouseClicked(GuiCrafting.java:124)
	at net.minecraft.client.gui.GuiScreen.handleMouseInput(GuiScreen.java:611)
	at net.minecraft.client.gui.GuiScreen.handleInput(GuiScreen.java:576)
	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1861)
	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1171)
	at net.minecraft.client.Minecraft.run(Minecraft.java:436)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:26)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Client thread
Stacktrace:
	at java.util.BitSet.get(BitSet.java:623)
	at net.minecraft.stats.RecipeBook.containsRecipe(RecipeBook.java:35)
	at net.minecraft.client.gui.recipebook.RecipeList.canCraft(RecipeList.java:44)
	at net.minecraft.client.gui.recipebook.GuiRecipeBook.lambda$updateCollections$0(GuiRecipeBook.java:176)
	at java.util.ArrayList.forEach(ArrayList.java:1249)
	at net.minecraft.client.gui.recipebook.GuiRecipeBook.updateCollections(GuiRecipeBook.java:174)
	at net.minecraft.client.gui.recipebook.GuiRecipeBook.initVisuals(GuiRecipeBook.java:111)
	at net.minecraft.client.gui.inventory.GuiCrafting.actionPerformed(GuiCrafting.java:142)
	at net.minecraft.client.gui.GuiScreen.mouseClicked(GuiScreen.java:494)
	at net.minecraft.client.gui.inventory.GuiContainer.mouseClicked(GuiContainer.java:360)
	at net.minecraft.client.gui.inventory.GuiCrafting.mouseClicked(GuiCrafting.java:124)
	at net.minecraft.client.gui.GuiScreen.handleMouseInput(GuiScreen.java:611)
	at net.minecraft.client.gui.GuiScreen.handleInput(GuiScreen.java:576)

-- Affected screen --
Details:
	Screen name: net.minecraft.client.gui.inventory.GuiCrafting

-- Affected level --
Details:
	Level name: MpServer
	All players: 1 total; [EntityPlayerSP['CAD97'/120, l='MpServer', x=206.76, y=73.00, z=340.80]]
	Chunk stats: MultiplayerChunkCache: 605, 605
	Level seed: 0
	Level generator: ID 00 - default, ver 1. Features enabled: false
	Level generator options: 
	Level spawn location: World: (222,64,354), Chunk: (at 14,4,2 in 13,22; contains blocks 208,0,352 to 223,255,367), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,0,0 to 511,255,511)
	Level time: 46123 game time, 6000 day time
	Level dimension: 0
	Level storage version: 0x00000 - Unknown?
	Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)
	Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: false
	Forced entities: 51 total; [EntityPlayerSP['CAD97'/120, l='MpServer', x=206.76, y=73.00, z=340.80], EntityBat['Bat'/22, l='MpServer', x=133.25, y=18.10, z=299.87], EntitySkeleton['Skeleton'/23, l='MpServer', x=150.22, y=20.00, z=287.53], EntitySkeleton['Skeleton'/25, l='MpServer', x=132.50, y=51.00, z=407.28], EntitySkeleton['Skeleton'/26, l='MpServer', x=129.48, y=52.00, z=411.74], EntityCreeper['Creeper'/27, l='MpServer', x=140.25, y=50.00, z=402.64], EntitySkeleton['Skeleton'/28, l='MpServer', x=141.50, y=51.00, z=402.70], EntityCreeper['Creeper'/34, l='MpServer', x=151.42, y=34.00, z=267.80], EntityCreeper['Creeper'/35, l='MpServer', x=147.41, y=35.00, z=278.16], EntitySpider['Spider'/36, l='MpServer', x=148.98, y=34.00, z=268.01], EntitySpider['Spider'/37, l='MpServer', x=148.13, y=20.00, z=286.56], EntitySkeleton['Skeleton'/38, l='MpServer', x=159.45, y=44.00, z=360.69], EntityBat['Bat'/39, l='MpServer', x=157.25, y=48.10, z=369.75], EntityCreeper['Creeper'/40, l='MpServer', x=154.39, y=52.00, z=396.85], EntityCreeper['Creeper'/41, l='MpServer', x=148.80, y=52.00, z=397.53], EntityCreeper['Creeper'/42, l='MpServer', x=146.70, y=37.00, z=419.83], EntityBat['Bat'/44, l='MpServer', x=151.88, y=37.00, z=413.09], EntitySkeleton['Skeleton'/48, l='MpServer', x=162.45, y=44.00, z=325.75], EntityEnderman['Enderman'/49, l='MpServer', x=178.51, y=38.00, z=341.71], EntitySkeleton['Skeleton'/50, l='MpServer', x=160.82, y=56.00, z=395.58], EntityCreeper['Creeper'/51, l='MpServer', x=173.16, y=42.00, z=407.59], EntityBat['Bat'/52, l='MpServer', x=175.56, y=52.10, z=410.75], EntityCreeper['Creeper'/57, l='MpServer', x=184.18, y=31.00, z=334.51], EntitySkeleton['Skeleton'/58, l='MpServer', x=181.47, y=47.00, z=320.27], EntityBat['Bat'/186, l='MpServer', x=233.59, y=23.10, z=287.42], EntityBat['Bat'/59, l='MpServer', x=189.70, y=33.10, z=342.75], EntityBat['Bat'/187, l='MpServer', x=239.45, y=29.28, z=290.68], EntityCreeper['Creeper'/60, l='MpServer', x=176.16, y=32.00, z=343.39], EntityBat['Bat'/61, l='MpServer', x=187.75, y=56.10, z=341.25], EntityBat['Bat'/62, l='MpServer', x=183.73, y=58.10, z=346.25], EntityCreeper['Creeper'/63, l='MpServer', x=188.83, y=56.00, z=349.62], EntityZombie['Zombie'/64, l='MpServer', x=200.92, y=55.00, z=348.51], EntityCreeper['Creeper'/65, l='MpServer', x=185.38, y=50.15, z=340.49], EntityCreeper['Creeper'/66, l='MpServer', x=188.70, y=53.00, z=340.30], EntityCreeper['Creeper'/67, l='MpServer', x=187.59, y=46.00, z=380.49], EntityBat['Bat'/68, l='MpServer', x=159.66, y=44.04, z=369.87], EntitySkeleton['Skeleton'/69, l='MpServer', x=187.53, y=50.00, z=400.80], EntitySkeleton['Skeleton'/70, l='MpServer', x=181.02, y=58.00, z=410.50], EntitySkeleton['Skeleton'/71, l='MpServer', x=180.30, y=58.00, z=410.49], EntitySkeleton['Skeleton'/73, l='MpServer', x=198.76, y=61.00, z=342.50], EntityBat['Bat'/74, l='MpServer', x=205.17, y=30.10, z=387.93], EntityZombie['Zombie'/76, l='MpServer', x=220.69, y=17.00, z=264.77], EntityCreeper['Creeper'/77, l='MpServer', x=215.04, y=20.00, z=280.30], EntityCreeper['Creeper'/78, l='MpServer', x=212.78, y=19.00, z=276.43], EntityCreeper['Creeper'/79, l='MpServer', x=218.20, y=24.00, z=273.55], EntityCreeper['Creeper'/80, l='MpServer', x=215.70, y=20.00, z=281.00], EntityBat['Bat'/84, l='MpServer', x=232.38, y=20.10, z=285.37], EntityEnderman['Enderman'/86, l='MpServer', x=245.50, y=20.00, z=285.56], EntitySkeleton['Skeleton'/87, l='MpServer', x=240.72, y=22.00, z=295.50], EntitySkeleton['Skeleton'/88, l='MpServer', x=250.77, y=25.00, z=303.53], EntitySkeleton['Skeleton'/89, l='MpServer', x=276.91, y=48.00, z=282.54]]
	Retry entities: 0 total; []
	Server brand: fml,forge
	Server type: Integrated singleplayer server
Stacktrace:
	at net.minecraft.client.multiplayer.WorldClient.addWorldInfoToCrashReport(WorldClient.java:456)
	at net.minecraft.client.Minecraft.addGraphicsAndWorldToCrashReport(Minecraft.java:2863)
	at net.minecraft.client.Minecraft.run(Minecraft.java:457)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:26)

-- System Details --
Details:
	Minecraft Version: 1.12
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 1.8.0_121, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 843080520 bytes (804 MB) / 1253048320 bytes (1195 MB) up to 3801088000 bytes (3625 MB)
	JVM Flags: 0 total; 
	IntCache: cache: 1, tcache: 1, allocated: 12, tallocated: 94
	FML: MCP 9.40 Powered by Forge 14.21.1.2387 7 mods loaded, 7 mods active
	States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
	UCHIJAAAA	minecraft{1.12} [Minecraft] (minecraft.jar) 
	UCHIJAAAA	mcp{9.19} [Minecraft Coder Pack] (minecraft.jar) 
	UCHIJAAAA	FML{8.0.99.99} [Forge Mod Loader] (forgeSrc-1.12-14.21.1.2387.jar) 
	UCHIJAAAA	forge{14.21.1.2387} [Minecraft Forge] (forgeSrc-1.12-14.21.1.2387.jar) 
	UCHIJAAAA	forgelin{1.4.2} [Shadowfacts' Forgelin] (Forgelin-1.5.0.jar) 
	UCHIJAAAA	spawnercraftkt{<%version%>} [SpawnerCraft] (SpawnerCraft_main) 
	UCHIJAAAA	jei{4.7.1.69} [Just Enough Items] (jei_1.12-4.7.1.69.jar) 
	Loaded coremods (and transformers): 
ForgelinPlugin (Forgelin-1.5.0.jar)
  
	GL info: ' Vendor: 'NVIDIA Corporation' Version: '4.5.0 NVIDIA 382.05' Renderer: 'GeForce GTX 860M/PCIe/SSE2'
	Launched Version: 1.12
	LWJGL: 2.9.4
	OpenGL: GeForce GTX 860M/PCIe/SSE2 GL version 4.5.0 NVIDIA 382.05, NVIDIA Corporation
	GL Caps: Using GL 1.3 multitexturing.
Using GL 1.3 texture combiners.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Shaders are available because OpenGL 2.1 is supported.
VBOs are available because OpenGL 1.5 is supported.

	Using VBOs: Yes
	Is Modded: Definitely; Client brand changed to 'fml,forge'
	Type: Client (map_client.txt)
	Resource Packs: 
	Current Language: English (US)
	Profiler Position: N/A (disabled)
	CPU: 8x Intel(R) Core(TM) i7-4810MQ CPU @ 2.80GHz

(Forgelin is a language adapter for Kotlin, NOT a coremod.)

 

A feature to properly remove JSON loaded recipes programmatically (based on config settings) would render this unnecessary.

 

I have a reputation for text walls. If you ask me a question I will most likely explain it in the most wordy way possible. -0 characters left

  • Quote

    It is not intended to allow you to remove recipes during the Register event. It is intended to be json driven. It just hasn't been implemented yet.

    But yes, the Register<IRecipe> event will eventually be fired multiple times, as it sits the current state is not determined and you should only REGISTER your shit in that event not remove others.

    I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
    Consider supporting the team on Patreon

  • Quote
    • Like 1

    Join the conversation

    You can post now and register later. If you have an account, sign in now to post with your account.
    Note: Your post will require moderator approval before it will be visible.

    Guest
    Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
    Reply to this topic...
    Go to topic listing

    Important Information

    By using this site, you agree to our Terms of Use.

    I accept

    Configure browser push notifications
    Chrome (Android)
    1. Tap the lock icon next to the address bar.
    2. Tap Permissions → Notifications.
    3. Adjust your preference.
    Chrome (Desktop)
    1. Click the padlock icon in the address bar.
    2. Select Site settings.
    3. Find Notifications and adjust your preference.