[1.12][SOLVED] NullpointerExeption when registering blocks

[inifire201]

I am updating my mod to 1.12(registry), until i hit a wall when my game crashed with:

java.lang.NullPointerException: Can't use a null-name for the registry, object net.minecraft.item.ItemBlock@73ae7ce4.

 

While debugging i also found that the ArrayList was filled but with null blocks.

 

I did the same thing for items and that's working fine.

Thanks in advance.

 

(full crash log)

My code:

@Mod.EventBusSubscriber(modid = Ref.MODID)
public class BlockHandler {
    public static List<Block> BLOCKS = new ArrayList<Block>();

    public static Block test_block = new BlockTestBlock(Material.ROCK, "test_block", CreativeTabHandler.tabMW, 5f, 15f, 3, "pickaxe");

    public static Block shard_ore_orange = new BlockShardOre(Material.ROCK, "shard_ore_orange", CreativeTabHandler.tabMW, 4f, 10f, 2,"pickaxe", ItemHandler.orangeShard, "orange");
    public static Block shard_ore_green = new BlockShardOre(Material.WOOD, "shard_ore_green", CreativeTabHandler.tabMW, 4f, 10f, 2, "axe", ItemHandler.greenShard, "green");
    public static Block shard_ore_white = new BlockShardOre(Material.ROCK, "shard_ore_white", CreativeTabHandler.tabMW, 4f, 10f, 2, "pickaxe" ,ItemHandler.whiteShard, "white");
    public static Block shard_ore_purple = new BlockShardOre(Material.ROCK, "shard_ore_purple", CreativeTabHandler.tabMW, 4f, 10f, 2, "pickaxe" , ItemHandler.purpleShard, "purple");

    public static Block trinket_maker = new BlockTrinketMaker(Material.WOOD, "trinket_maker", CreativeTabHandler.tabMW, 4f, 10f, 3,"axe", true);


    //TODO Fix this, error: nullpointer exeption. added blocks are null.
    @SubscribeEvent
    public static void registerBlocks(RegistryEvent.Register<Block> event){
        BLOCKS.add(test_block);

        BLOCKS.add(shard_ore_green);
        BLOCKS.add(shard_ore_orange);
        BLOCKS.add(shard_ore_purple);
        BLOCKS.add(shard_ore_white);

        BLOCKS.add(trinket_maker);

        for(Block block : BLOCKS){
            event.getRegistry().register(block);
        }
    }

    @SubscribeEvent
    public static void registerItemBlocks(RegistryEvent.Register<Item> event){

        for(Block block : BLOCKS){
            ItemBlock itemBlock = new ItemBlock(block);
            event.getRegistry().register(itemBlock);
        }
    }

    @SideOnly(Side.CLIENT)
    @SubscribeEvent
    public static void registerModels(ModelRegistryEvent event){
        for(Block block: BLOCKS){
            ModelLoader.setCustomModelResourceLocation(Item.getItemFromBlock(block), 0, new ModelResourceLocation(block.getRegistryName(), "inventory"));
        }
    }
}

 

(edit) Solution:

Registry name wasn't set, code:

    @SubscribeEvent
    public static void registerBlocks(RegistryEvent.Register<Block> event){
        BLOCKS.add(test_block);

        BLOCKS.add(shard_ore_green);
        BLOCKS.add(shard_ore_orange);
        BLOCKS.add(shard_ore_purple);
        BLOCKS.add(shard_ore_white);

        BLOCKS.add(trinket_maker);
        for(Block block : BLOCKS){
            event.getRegistry().register(block);
        }
    }

    @SubscribeEvent
    public static void registerItemBlocks(RegistryEvent.Register<Item> event){

        for(Block block: BLOCKS){
            event.getRegistry().register(new ItemBlock(block).setRegistryName(block.getRegistryName()));
        }

    }

 

Edited July 30, 2017 by inifire201
Added solution into post.

[V0idWa1k3r]

30 minutes ago, inifire201 said:

ItemBlock itemBlock = new ItemBlock(block);

You need to set the registry name for the itemblock you are creating too.

You are not using the new registry system correctly. You should not put anything into the fields(blocks/items) and let ObjectHolders do that for you.

ModelLoader is a client-only side class and references to it should be performed at a client-only class aswell. The SideOnly annotation is not something to be trusted.

[MrBendelScrolls]

3 minutes ago, V0idWa1k3r said:

You should not put anything into the fields(blocks/items) and let ObjectHolders do that for you.

But why not? What's the difference?

[V0idWa1k3r]

Just now, MrBendelScrolls said:

But why not? What's the difference?

1. The substitution system will work with ObjectHolders, but won't with straight up declared fields. Think about the mess that would be created if someone creates a substitution for your block/item/registry entry but you are still using the old reference that won't even be in the registry! At best all you equality checks will fail. At worst you will have crashes all over the place.
2. At forge's git Lex mentioned the possibility of dynamically reloading all registries, including blocks and items. Plain fields references won't work good with this idea either. Yes technically it won't matter too much. However if you are referencing another field in your constructor(like ItemSeeds for example) - yet again, practically N1.
3. It is just the preferred way of doing it.

[inifire201]

ObjectHolders are ATM not my problem, in don't think that has anything to do with this. My problem is that when i try to register my ItemBlocks is that i get:

"java.lang.NullPointerException: Can't use a null-name for the registry, object net.minecraft.item.ItemBlock@73ae7ce4."

 

When i debug the item that is put in it has a registry name, but i still get that exeption.

[Draco18s]

32 minutes ago, V0idWa1k3r said:

You need to set the registry name for the itemblock you are creating too. 

*cough*

[RedBullSlurpie]

I've got this issue as well. Pretty sure it's the same issue, my items are registered in game fine, but blocks give me this error upon launching Minecraft, you say to also set the registry name for the Itemblock, but im not sure how to do that, here is my code, if I need to do the same thing, would someone help me?

Main class where the registration handler is- https://pastebin.com/CUvW9429

My sapphire ore class- https://pastebin.com/vptv0c9k

My blocks class- https://pastebin.com/zWjCRuDr

Crash log also- https://pastebin.com/KvnuZPKh

[V0idWa1k3r]

7 minutes ago, RedBullSlurpie said:

you say to also set the registry name for the Itemblock, but im not sure how to do that

%youritemblocklocalnamehere%.setRegistryName(%yourblockfieldnamehere%.getRegistryName());

[RedBullSlurpie]

Did that, but now I am getting java.lang.IllegalStateException: Attempted to set registry name with existing registry name! New: slurpiesdongles:sapphire_ore Old: slurpiesdongles:sapphire_ore

 

Added my new line here 

package com.rbs.slurpiesdongles.init;

import com.rbs.slurpiesdongles.blocks.BlockSapphireOre;
import net.minecraft.block.Block;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraftforge.registries.IForgeRegistry;

/**
 * Created by Consular on 7/19/2017.
 */
public class SDBlocks {

    public static BlockSapphireOre oreSapphire = new BlockSapphireOre("sapphire_ore").setCreativeTab(CreativeTabs.MATERIALS);

    public static void register(IForgeRegistry<Block> registry) {
        registry.registerAll(
                oreSapphire,
                oreSapphire.setRegistryName(oreSapphire.getRegistryName())
        );

    }

    public static void registerItemBlocks(IForgeRegistry<Item> registry) {
        registry.registerAll(
                oreSapphire.createItemBlock()
        );

    }

    public static void registerModels() {
        oreSapphire.registerItemModel((ItemBlock) Item.getItemFromBlock(oreSapphire));

    }
}

 

Crash log here- https://pastebin.com/zpQ2WYD2

[Draco18s]

        registry.registerAll(
                oreSapphire,
                oreSapphire.setRegistryName(oreSapphire.getRegistryName())
        );

 

This is equal to block.setRegistryName(block.getRegistryName()) and wrong. You should be doing item.setRegistryName(block.getRegistryName())

[RedBullSlurpie]

Got it working, tyvm

[inifire201]

Got it working here as well, thanks for helping out.