[1.12] Replacing one vanilla sound wipes out others

[DarkMorford]

I have the following sounds.json file in my mod's src/main/resources/assets/minecraft directory:

{
	"entity.endermen.stare": {
		"replace": true,
		"sounds": ["btweagles:beejdrop"]
	},
	"entity.endermen.scream": {
		"replace": true,
		"sounds": ["btweagles:beejdrop"]
	}
}

 

As I understand it, every mod is also a resource pack, and according to the official wiki, "unlike most other files in resource packs, sounds.json will merge sound information from packs below the top pack, rather than each sounds.json file overriding the previous completely." Given that, I would expect that only the two SoundEvents I have listed would be replaced, and all other vanilla sounds would be unaffected.

However, this does not appear to be the case. Instead, I'm met with a litany of warnings when Minecraft starts up:

[main/WARN]: Missing sound for event: minecraft:ambient.cave
[main/WARN]: Missing sound for event: minecraft:block.anvil.break
[main/WARN]: Missing sound for event: minecraft:block.anvil.destroy
[main/WARN]: Missing sound for event: minecraft:block.anvil.fall
[main/WARN]: Missing sound for event: minecraft:block.anvil.hit
[main/WARN]: Missing sound for event: minecraft:block.anvil.land
[main/WARN]: Missing sound for event: minecraft:block.anvil.place
[main/WARN]: Missing sound for event: minecraft:block.anvil.step
...

And indeed no sounds play except for those I've explicitly defined in my sounds.json file.

Does this mean I have to replicate the entire vanilla sounds.json in order to replace just a few sound files, or is there a more modder-friendly way to do it?

[DarkMorford]

I was under the impression that it had to be in the "minecraft" domain in order to affect vanilla SoundEvents. Is that not correct?

[Draco18s]

Vanilla is already supplying a sounds.json at that location.

[Choonster]

SoundHandler#onResourceManagerReload explicitly iterates through every copy of sounds.json for each domain (using IResourceManager#getAllResources), it doesn't just use first one it finds (using IResourceManager#getResource) like most other places in the code do.

 

Looking at the code, it should only replace the sounds present in each sounds.json file (that opt-in to replace existing sounds); I'm not sure why the other sounds are being removed.

 

Try setting a breakpoint in SoundHandler#onResourceManagerReload and stepping through the code.

[DarkMorford]

Hm, interesting. Assuming I'm understanding this correctly, it appears that DefaultResourcePack#getResourceStream is somehow finding a copy of my sounds.json file (located at file:/H:/projects/BetterThanWeagles/out/production/BetterThanWeagles_main/assets/minecraft/sounds.json) instead of the vanilla one. This is causing my sounds.json to get loaded twice (redundantly) and the vanilla sounds to not load at all.

Edited August 8, 2017 by DarkMorford

[Abastro]

I guess it shouldn't be in minecraft domain. It should under the domain for your own mod, i.e. assets/(modid)/sounds.json.

Because the assets folder is to be merged.