Jump to content

[1.11.2] Item model not rendering


TrekkieCub314

Recommended Posts

Hi, I've been trying to get back into modding, but I'm having some problems with some basic stuff.  I'm trying to add an item and the item model is not rendering correctly.  I've tried using some tutorials, but either they are wrong or (more likely) things have changed between versions and I failed to account for this.

 

Here's my main class:

package com.trekkiecub.oddsandends;

import com.trekkiecub.oddsandends.init.ItemInit;
import com.trekkiecub.oddsandends.proxy.CommonProxy;
import com.trekkiecub.oddsandends.util.FUNC;

import net.minecraft.init.Blocks;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.Mod.Instance;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;

@Mod(modid = Reference.MODID, name = Reference.NAME, version = Reference.VERSION)
public class Mod_OddsAndEnds
{
	
	///
	///  Instance and Proxies
	///
	
    @Instance
    public static Mod_OddsAndEnds instance;
    
    @SidedProxy(serverSide = Reference.SERVER_PROXY, clientSide = Reference.CLIENT_PROXY)
    public static CommonProxy proxy;
 
    ///
    ///  Initialization Events
    ///
    
    // Pre-Init Event
    @EventHandler
    public void preInit(FMLInitializationEvent event)
    {
    	ItemInit.init();
    	ItemInit.register();
    	
    	proxy.registerRenders();
    	
    	FUNC.getLogger().info("Pre-Init Completed");
    }
    
    // Init Event
    @EventHandler
    public void init(FMLInitializationEvent event)
    {
        // some example code
        System.out.println("DIRT BLOCK >> "+Blocks.DIRT.getUnlocalizedName());
    }
    
    // Post-Init Event
    @EventHandler
    public void postInit(FMLInitializationEvent event)
    {
    	
    }
}

 

 

ItemInit:

package com.trekkiecub.oddsandends.init;

import java.util.logging.Logger;

import com.trekkiecub.oddsandends.Mod_OddsAndEnds;
import com.trekkiecub.oddsandends.Reference;
import com.trekkiecub.oddsandends.items.Item_Base;
import com.trekkiecub.oddsandends.util.FUNC;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.common.registry.GameRegistry;
import scala.actors.threadpool.helpers.Utils;

public class ItemInit {
	
	public static Item beach_apple;
	
	public static void init()
	{
		beach_apple = new Item_Base("beach_apple", "beach_apple");
	}
	
	public static void register()
	{
		registerItem(beach_apple);
	}
	
	public static void registerRenders()
	{
		registerRender(beach_apple);
	}
	
	public static void registerItem(Item item)
	{
		GameRegistry.register(item);
	}
	
	public static void registerRender(Item item)
	{
		ModelResourceLocation location = new ModelResourceLocation(item.getRegistryName(), "inventory");
		ModelLoader.setCustomModelResourceLocation(item, 0, location);
	}

}

 

ItemBase:

package com.trekkiecub.oddsandends.items;

import com.trekkiecub.oddsandends.Reference;

import net.minecraft.item.Item;

public class Item_Base extends Item {
	
	public Item_Base(String UnlocName, String ResName)
	{
		this.setUnlocalizedName(UnlocName);
		this.setRegistryName(Reference.MODID, ResName);
	}

}

 

ClientProxy:

package com.trekkiecub.oddsandends.proxy;

import com.trekkiecub.oddsandends.init.ItemInit;

public class ClientProxy extends CommonProxy
{
	@Override
	public void registerRenders() {
		ItemInit.registerRenders();
	}

}

 

beach_apple.json:

{
	"parent": "item/generated",
	"textures": {
		"layer0": "tc_oddsandends:items/beach_apple"
	}
}

 

Assets directory as follows:

assets

---tc_oddsandends

------lang

------models

---------item

------------beach_apple.json

------textures

---------items

------------beach_apple.png

 

latest log:

https://gist.github.com/anonymous/179b61dcc6fefaac340255b5e71ce1e5

Link to comment
Share on other sites

Tutorials that you're using are outdated. You should use registry events now.

 

Complicated things simple:

  • Items must be registered inside RegistryEvent.Register<IForgeRegistryEntry> with event::getRegistry()::register()
    public static void registerItems(RegistryEvent.Register<Item> event) {
      event.getRegistry().register(item);
    }

     

  • Models must be registered inside ModelRegistryEvent with ModelLoader::setCustomResourceLocation()
    public static void registerModels(ModelRegistryEvent event) {
      ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory"));
    }

     

Don't forget to separate event subscribers with common RegistryEvent and client ModelRegistryEvent, otherwise crashes may happen.

Edited by MrBendelScrolls
Link to comment
Share on other sites

ModelLoader is a client-side class, any references to it must be in your client proxy.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.