Jump to content

[1.12] Crash when trying to use ObjectHolders


That_Martin_Guy

Recommended Posts

I haven't used ObjectHolders before, but I've seen a lot of people both use and recommend them, so I tried to use them myself. I am not very experienced with these, though, and I am currently crashing with an IllegalStateException.

 

Crash log

ModBlocks
ModItems

 

The linked files are the only files containing the ObjectHolder annotation.

 

Link to comment
Share on other sites

Uh.

You're not using them correctly.

http://mcforge.readthedocs.io/en/latest/concepts/registries/#injecting-registry-values-into-fields

 

public static final Block diamond_block = null; // public static final is required.
                                                    // Type Block means that the Block registry will be queried.
                                                    // diamond_block is the field name, and as the field is not annotated it is taken to be the resource path.
                                                    // As there is no explicit domain, "minecraft" is inherited from the class.
                                                    // Object to be injected: "minecraft:diamond_block" from the Block registry.

Notice how the field is null.

Notice how the field is of type Block.

Notice how the field name equals the registry name.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

7 minutes ago, That_Martin_Guy said:

How do I instantiate it if the field is null? I want to have multiple instances of BlockHardenedOre with different values in its constructor.

That's what the ObjectHolder annotation is for!

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Local variables.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

BlockBase (which BlockHardenedOre inherits from) sets the registry name in it's constructor as the first parameter like this:

 

    public BlockBase(String name, @Nullable CreativeTabs creativeTab, Material materialIn)
    {
      ...
        this.setName(name);
      ...
    }

    private void setName(String name)
    {
        this.setRegistryName(name);
        super.setUnlocalizedName(this.getRegistryName().toString());
    }

. So in this case the hardened coal's registry name is blockhardenedcoal. Is this incorrect?

Link to comment
Share on other sites

I thought I said that...

17 hours ago, Draco18s said:

Notice how the field name equals the registry name.

Oh, I did.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.