Jump to content

[1.12] Butcher Harvesting Meat Doesn't do Anything


OrangeVillager61

Recommended Posts

Hello! I am trying to get a butcher to go to mobs and "harvest" a meat out of them. More specifically, the butcher goes up to the mob, gets one meat, type depending on the mob and then goes to another after 10 secs. However, my butcher does nothing and the first println doesn't go off.

 

public class VillagerAIHarvestMeat extends EntityAIBase
{
	public final double VilPerDoor = Config.VilPerDoor;
    private final IvVillager villagerObj;
    private EntityAnimal animal;
    int mateAgain;
    protected Random rand = new Random();
    private World world;
    String animal_type;
    int delayCounter;

    public VillagerAIHarvestMeat(IvVillager villagerIn)
    {
        this.villagerObj = villagerIn;
        this.world = villagerIn.world;
        this.setMutexBits(3);
    }

    /**
     * Returns whether the EntityAIBase should begin execution.
     */
    public boolean shouldExecute()
    {
    	if (this.villagerObj.getWorkTicks() > 0)
    	{
    		return false;
    	}
        if (this.villagerObj.getGrowingAge() != 0)
        {
            return false;
        }
        if (this.villagerObj.wantsMoreFood() == false)
        {
        	return false;
        }
        if (this.villagerObj.getProfession() != 4)
        {
        	return false;
        }
        else
        {
            EntityAnimal entity = (EntityAnimal) this.world.findNearestEntityWithinAABB(EntityAnimal.class, this.villagerObj.getEntityBoundingBox().expand(100.0D, 7.0D, 100.0D), this.villagerObj);

            if (entity == null)
            {
                 return false;
            }
            if (this.villagerObj.world.getWorldTime() - entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() < 24000 || entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() == 0)
			{
				return false;
			}
            if (entity.getGrowingAge() < 0)
            {
            	return false;
            }
            if (entity instanceof EntityCow)
            {
            	this.animal_type = "Cow";
            	return true;
            }
            else if (entity instanceof EntityPig)
            {
            	this.animal_type = "Pig";
            	return true;
            }
            else if (entity instanceof EntitySheep)
            {
            	this.animal_type = "Sheep";
            	return true;
            }
            else if (entity instanceof EntityChicken)
            {
            	this.animal_type = "Chicken";
            	return true;
            }
            else
            {
            	return false;
            }            
        }
    }
    /**
     * Execute a one shot task or start executing a continuous task
     */
    public void startExecuting()
    {
        System.out.println("Butcher task approved.");
        this.delayCounter = 0;
    }
    /**
     * Returns whether an in-progress EntityAIBase should continue executing
     */
    public boolean continueExecuting()
    {
        if (this.animal.getGrowingAge() < 0)
        {
            return false;
        }
        else if (!this.animal.isEntityAlive())
        {
            return false;
        }
        else
        {
            System.out.println("Butcher task allowed to continue.");
        	return true;
        }
    }
    /**
     * Resets the task
     */
    public void resetTask()
    {
        this.animal = null;
    }
    /**
     * Updates the task
     */
    public void updateTask()
    {
        System.out.println("Butcher to animal.");
        if (this.villagerObj.getDistanceSqToEntity(this.animal) > 2.25D)
        {
            if (--this.delayCounter <= 0)
            {
                this.delayCounter = 10;
                this.villagerObj.getNavigator().tryMoveToEntityLiving(this.animal, 0.53D);
            }
        }
        else
        {
        	this.getMeat();
        }
    }

    private void getMeat()
    {
    	if (this.animal_type == "Cow")
    	{
    		this.animal.dropItem(Items.COOKED_BEEF, 1);
    	}
    	else if (this.animal_type == "Pig")
    	{
    		this.animal.dropItem(Items.COOKED_PORKCHOP, 1);
    	}
    	else if (this.animal_type == "Sheep")
    	{
    		this.animal.dropItem(Items.COOKED_MUTTON, 1);
    	}
    	else if (this.animal_type == "Chicken")
    	{
    		this.animal.dropItem(Items.COOKED_CHICKEN, 1);
    	}
        System.out.println("Butcher got the meat.");
    	this.villagerObj.setWorkTicks(200);
    	this.animal.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).setTime(this.animal.world.getWorldTime());
    }


}
public class HarvestTimeUser implements IHarvestTime{
	
	private long time = 0;
	
	@Override
	public void setTime(long l)
	{
		this.time = l;
	}

	@Override
	public long get_time() {
		return time;
	}

}

 

Link to comment
Share on other sites

Why did you only put one print statement? If you want to debug you should put a print in every if statement to figure out which path is executing.

 

Without thinking too much about it, I expect your shouldExecute() is always returning false. So add print statements in each if within that method and check if any of those are triggering and returning false.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

18 hours ago, jabelar said:

Why did you only put one print statement? If you want to debug you should put a print in every if statement to figure out which path is executing.

 

Without thinking too much about it, I expect your shouldExecute() is always returning false. So add print statements in each if within that method and check if any of those are triggering and returning false.

Alright, I added printlns throughout my code and fixed many issues but I'm reaching a major issue where shouldExecute doesn't start at all according to my printlns.

public boolean shouldExecute()
    {
    	System.out.println("Should Execute started."); //Doesn't fire
        if (this.villagerObj.getGrowingAge() != 0)
        {
    		System.out.println("Isn't adult");
            return false;
        }
        else if (this.villagerObj.wantsMoreFood() == false)
        {
    		System.out.println("Doesn't want food");
        	return false;
        }
        else if (this.villagerObj.getProfession() != 4)
        {
    		System.out.println("Is not a butcher");
        	return false;
        }
        else
        {
            EntityAnimal entity = (EntityAnimal) this.world.findNearestEntityWithinAABB(EntityAnimal.class, this.villagerObj.getEntityBoundingBox().expand(100.0D, 7.0D, 100.0D), this.villagerObj);

            if (entity == null)
            {
        		System.out.println("Entity is null");
                return false;
            }
            if (this.villagerObj.world.getWorldTime() - entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() < 24000 && entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() != 0)
			{
        		System.out.println("Entity has been harvested");
				return false;
			}
            if (entity.getGrowingAge() < 0)
            {
        		System.out.println("Entity is not adult");
            	return false;
            }
            if (entity instanceof EntityCow)
            {
            	this.animal_type = "Cow";
            	return true;
            }
            else if (entity instanceof EntityPig)
            {
            	this.animal_type = "Pig";
            	return true;
            }
            else if (entity instanceof EntitySheep)
            {
            	this.animal_type = "Sheep";
            	return true;
            }
            else if (entity instanceof EntityChicken)
            {
            	this.animal_type = "Chicken";
            	return true;
            }
            else
            {
        		System.out.println("Entity is not harvestable");
            	return false;
            }            
        }
    }

 

Link to comment
Share on other sites

Forgot to put where it was being called:

 

protected void setAdditionalAItasks()
    {
        if (!this.areAdditionalTasksSet)
        {
            this.areAdditionalTasksSet = true;

            if (this.isChild())
            {
                this.tasks.addTask(8, new EntityAIPlay(this, 0.32D));
            }
            else if (this.getProfessionForge() == PROFESSION_FARMER || this.getProfession() == 0)
            {
                this.tasks.addTask(6, new EntityAIHarvestFarmland(this, 0.6D));
            }
            else if (this.getProfession() == 4 || this.getProfessionForge() == PROFESSION_BUTCHER)
            {
                this.tasks.addTask(6, new VillagerAIHarvestMeat(this));
            }
            if (this.getHired())
            {
                this.tasks.addTask(6, new VillagerFollowOwner(this, 0.9D, 6.0F, 1.5F));
            }
        }
    }

 

Link to comment
Share on other sites

You should keep going with the print statements. For example are you sure that the add task is even being called? Put a print statement there.

 

If you're confident that that the AI task is actually being properly added to the entity, then it may be that the mutex bits are set wrong, or maybe if they are set right but another AI task is already running. The mutex bits prevent two AI from running at the same time that might conflict with each other. So if a higher priority AI task is already running, the shouldExecute() for your AI task won't ever be called.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

2 hours ago, jabelar said:

You should keep going with the print statements. For example are you sure that the add task is even being called? Put a print statement there.

 

If you're confident that that the AI task is actually being properly added to the entity, then it may be that the mutex bits are set wrong, or maybe if they are set right but another AI task is already running. The mutex bits prevent two AI from running at the same time that might conflict with each other. So if a higher priority AI task is already running, the shouldExecute() for your AI task won't ever be called.

What are the mutex bits?

Link to comment
Share on other sites

In your code posted above, in the constructor of your AI class you call the setMutexBits(3) method. Which means you set the mutex bits to value of 3. "Mutex" is short for "mutually exclusive" and works sort of like a mask. 

 

I have a tutorial on making entity AI which discusses mutex bits about 1/3rd way down the page: http://jabelarminecraft.blogspot.com/p/minecraft-forge-1721710-custom-entity-ai.html

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Link to comment
Share on other sites

13 hours ago, jabelar said:

In your code posted above, in the constructor of your AI class you call the setMutexBits(3) method. Which means you set the mutex bits to value of 3. "Mutex" is short for "mutually exclusive" and works sort of like a mask. 

 

I have a tutorial on making entity AI which discusses mutex bits about 1/3rd way down the page: http://jabelarminecraft.blogspot.com/p/minecraft-forge-1721710-custom-entity-ai.html

Hmm, I changed the MutexBits and it didn't do anything. Also, the AI is crashing the game when ever I relog at the updateTask at this line:

        if (this.villagerObj.getDistanceSqToEntity(this.animal) > 2.25D)

However, it is not giving me the println that I put at the start of updateTask, it doesn't make sense. 

Link to comment
Share on other sites

On 8/20/2017 at 2:05 PM, jabelar said:

You should keep going with the print statements. For example are you sure that the add task is even being called? Put a print statement there.

 

If you're confident that that the AI task is actually being properly added to the entity, then it may be that the mutex bits are set wrong, or maybe if they are set right but another AI task is already running. The mutex bits prevent two AI from running at the same time that might conflict with each other. So if a higher priority AI task is already running, the shouldExecute() for your AI task won't ever be called.

Okay, it looks like the addTask isn't being called. I can't find the issue though.

	protected void setAdditionalAItasks()
    {
        if (!this.areAdditionalTasksSet)
        {
            this.areAdditionalTasksSet = true;

            if (this.isChild())
            {
                this.tasks.addTask(8, new EntityAIPlay(this, 0.32D));
            }
            else if (this.getProfessionForge() == PROFESSION_FARMER || this.getProfession() == 0)
            {
                this.tasks.addTask(5, new EntityAIHarvestFarmland(this, 0.6D));
            }
            else if (this.getProfession() == 4 || this.getProfessionForge() == PROFESSION_BUTCHER)
            {
                this.tasks.addTask(5, new VillagerAIHarvestMeat(this));
                System.out.println("Villager will now harvest meat.");
            }
            if (this.getHired())
            {
                this.tasks.addTask(5, new VillagerFollowOwner(this, 0.9D, 6.0F, 1.5F));
            }
        }
    }

I know that the function is being called since the farming task is working fine.

Link to comment
Share on other sites

Hmm, after further testing. MC tries to run the AI after a relog but it crashes on the attempt to do so:

 

public class VillagerAIHarvestMeat extends EntityAIBase
{
    private final IvVillager villagerObj;
    private EntityAnimal animal;
    int mateAgain;
    protected Random rand = new Random();
    private World world;
    String animal_type;
    int delayCounter;

    public VillagerAIHarvestMeat(IvVillager villagerIn)
    {
        this.villagerObj = villagerIn;
        this.world = villagerIn.world;
        this.setMutexBits(1);
    }

    /**
     * Returns whether the EntityAIBase should begin execution.
     */
    public boolean shouldExecute()
    {
    	System.out.println("Should Execute started.");
        if (this.villagerObj.getGrowingAge() != 0)
        {
    		System.out.println("Isn't adult");
            return false;
        }
        else if (this.villagerObj.wantsMoreFood() == false)
        {
    		System.out.println("Doesn't want food");
        	return false;
        }
        else if (this.villagerObj.getProfession() != 4)
        {
    		System.out.println("Is not a butcher");
        	return false;
        }
        else
        {
            EntityAnimal entity = (EntityAnimal) this.world.findNearestEntityWithinAABB(EntityAnimal.class, this.villagerObj.getEntityBoundingBox().expand(100.0D, 7.0D, 100.0D), this.villagerObj);

            if (entity == null)
            {
        		System.out.println("Entity is null");
                return false;
            }
            if (this.villagerObj.world.getWorldTime() - entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() < 24000 && entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() != 0)
			{
        		System.out.println("Entity has been harvested");
				return false;
			}
            if (entity.getGrowingAge() < 0)
            {
        		System.out.println("Entity is not adult");
            	return false;
            }
            if (entity instanceof EntityCow)
            {
            	this.animal_type = "Cow";
            	entity = this.animal;
            	return true;
            }
            else if (entity instanceof EntityPig)
            {
            	this.animal_type = "Pig";
            	entity = this.animal;
            	return true;
            }
            else if (entity instanceof EntitySheep)
            {
            	this.animal_type = "Sheep";
                entity = this.animal;
            	return true;
            }
            else if (entity instanceof EntityChicken)
            {
            	this.animal_type = "Chicken";            	
            	entity = this.animal;
            	return true;
            }
            else
            {
        		System.out.println("Entity is not harvestable");
            	return false;
            }            
        }
    }
    /**
     * Execute a one shot task or start executing a continuous task
     */
    public void startExecuting()
    {
        System.out.println("Butcher task approved.");
        this.delayCounter = 0;
    }
    /**
     * Returns whether an in-progress EntityAIBase should continue executing
     */
    public boolean continueExecuting()
    {
    	if (!this.animal.isEntityAlive())
        {
            return false;
        }
    	else if (this.villagerObj.getNavigator().noPath())
    	{
    		return false;
    	}
        else
        {
            System.out.println("Butcher task allowed to continue.");
        	return true;
        }
    }
    /**
     * Resets the task
     */
    public void resetTask()
    {
        this.villagerObj.getNavigator().clearPathEntity();
        this.delayCounter = 5;
    }
    /**
     * Updates the task
     */
    public void updateTask()
    {
        System.out.println(this.animal);
        if (this.villagerObj.getDistanceSqToEntity(this.animal) > 2.25D)
        {
            if (--this.delayCounter <= 0)
            {
                this.delayCounter = 10;
                this.villagerObj.getNavigator().tryMoveToEntityLiving(this.animal, 0.53D);
            }
        }
        else
        {
        	this.getMeat();
        }
    }

    private void getMeat()
    {
    	if (this.animal_type == "Cow")
    	{
    		this.animal.dropItem(Items.COOKED_BEEF, 1);
    	}
    	else if (this.animal_type == "Pig")
    	{
    		this.animal.dropItem(Items.COOKED_PORKCHOP, 1);
    	}
    	else if (this.animal_type == "Sheep")
    	{
    		this.animal.dropItem(Items.COOKED_MUTTON, 1);
    	}
    	else if (this.animal_type == "Chicken")
    	{
    		this.animal.dropItem(Items.COOKED_CHICKEN, 1);
    	}
        System.out.println("Butcher got the meat.");
    	this.villagerObj.setWorkTicks(200);
    	this.animal.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).setTime(this.animal.world.getWorldTime());
    }


}

 

Edited by OrangeVillager61
Link to comment
Share on other sites

Forgot to post crash report:

 

[22:25:54] [Server thread/INFO] [STDOUT]: [orangeVillager61.ImprovedVillagers.Entities.IvVillager:setAdditionalAItasks:806]: Villager will now harvest meat.
[22:25:54] [Server thread/INFO]: Preparing spawn area: 53%
[22:25:54] [Server thread/INFO] [STDOUT]: [orangeVillager61.ImprovedVillagers.Entities.AI.VillagerAIHarvestMeat:shouldExecute:46]: Should Execute started.
[22:25:54] [Server thread/INFO] [STDOUT]: [orangeVillager61.ImprovedVillagers.Entities.AI.VillagerAIHarvestMeat:startExecuting:113]: Butcher task approved.
[22:25:54] [Server thread/INFO] [STDOUT]: [orangeVillager61.ImprovedVillagers.Entities.AI.VillagerAIHarvestMeat:updateTask:149]: Butcher to animal.
[22:25:54] [Server thread/ERROR]: Encountered an unexpected exception
net.minecraft.util.ReportedException: Ticking entity
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:842) ~[MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:740) ~[MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) ~[IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:589) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_121]
Caused by: java.lang.NullPointerException
	at net.minecraft.entity.Entity.getDistanceSqToEntity(Entity.java:1627) ~[Entity.class:?]
	at orangeVillager61.ImprovedVillagers.Entities.AI.VillagerAIHarvestMeat.updateTask(VillagerAIHarvestMeat.java:150) ~[VillagerAIHarvestMeat.class:?]
	at net.minecraft.entity.ai.EntityAITasks.onUpdateTasks(EntityAITasks.java:114) ~[EntityAITasks.class:?]
	at net.minecraft.entity.EntityLiving.updateEntityActionState(EntityLiving.java:843) ~[EntityLiving.class:?]
	at net.minecraft.entity.EntityLivingBase.onLivingUpdate(EntityLivingBase.java:2565) ~[EntityLivingBase.class:?]
	at net.minecraft.entity.EntityLiving.onLivingUpdate(EntityLiving.java:647) ~[EntityLiving.class:?]
	at net.minecraft.entity.EntityAgeable.onLivingUpdate(EntityAgeable.java:201) ~[EntityAgeable.class:?]
	at orangeVillager61.ImprovedVillagers.Entities.IvVillager.onLivingUpdate(IvVillager.java:619) ~[IvVillager.class:?]
	at net.minecraft.entity.EntityLivingBase.onUpdate(EntityLivingBase.java:2381) ~[EntityLivingBase.class:?]
	at net.minecraft.entity.EntityLiving.onUpdate(EntityLiving.java:346) ~[EntityLiving.class:?]
	at net.minecraft.world.World.updateEntityWithOptionalForce(World.java:2141) ~[World.class:?]
	at net.minecraft.world.WorldServer.updateEntityWithOptionalForce(WorldServer.java:872) ~[WorldServer.class:?]
	at net.minecraft.world.World.updateEntity(World.java:2101) ~[World.class:?]
	at net.minecraft.world.World.updateEntities(World.java:1912) ~[World.class:?]
	at net.minecraft.world.WorldServer.updateEntities(WorldServer.java:644) ~[WorldServer.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:836) ~[MinecraftServer.class:?]
	... 4 more

 

Link to comment
Share on other sites

if (this.villagerObj.getDistanceSqToEntity(this.animal) > 2.25D) //Crashes here

No, it's crashing trying to calculate the distance. Inside this function.

There's only one object here that could be null:

this.animal

Do a search of your file for "animal =" and tell me what you find and if you still have a problem.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, I'm Richard, a doctor based in Texas, navigating the complexities of life as a single parent to my 7-year-old daughter. Recently, I decided to invest my pension funds with Coinberry, hoping to supplement my income from my medical practice. Little did I anticipate the tumultuous journey that awaited me. Initially, Coinberry seemed like a promising platform, offering opportunities to invest in cryptocurrencies such as Ethereum (ETH). Entrusting them with $38,000 worth of ETH, I envisioned a future where financial stability and security would complement my responsibilities as a healthcare provider and father. However, my optimism quickly turned to despair when Coinberry's actions took a sinister turn. I found myself on the brink of losing my entire investment—$38,000 worth of ETH—due to what appeared to be a series of manipulative maneuvers. The situation seemed dire, and I was at a loss for how to reclaim what was rightfully mine. Amidst the chaos and desperation, a ray of hope emerged in the form of RESILIENT SHIELD RECOVERY.. Recommended to me by others who had faced similar ordeals, I reached out to them with a flicker of optimism. Their response was nothing short of remarkable. RESILIENT SHIELD RECOVERY. swiftly embarked on a mission to trace the intricate path of my lost funds. Their expertise in blockchain analytics and forensic investigation proved invaluable as they meticulously tracked the movement of ETH across various soft wallets. Within a remarkably short span of three days, they achieved the seemingly impossible—they recovered a substantial portion of my funds. The relief and gratitude I felt cannot be overstated. RESILIENT SHIELD RECOVERY. not only restored my financial stability but also provided me with a renewed sense of security. Their professionalism and efficiency in handling my case were exemplary, guiding me through the intricate process of fund recovery with empathy and clarity. Beyond their role as financial saviors, RESILIENT SHIELD RECOVERY. imparted invaluable lessons on cybersecurity and risk management. They emphasized the importance of vigilance in the digital realm, advocating for measures such as two-factor authentication and secure password practices to safeguard against future threats. Their insights were not only practical but also empowering, equipping me with the knowledge to make informed decisions in my future financial endeavors. As I reflect on this challenging chapter in my life, I am reminded of the resilience inherent in the human spirit. My experience with Coinberry and subsequent salvation by RESILIENT SHIELD RECOVERY. has reinforced the importance of due diligence and caution in investment decisions. It has also underscored the critical role that trusted allies like RESILIENT SHIELD RECOVERY. play in navigating the complexities of financial fraud and cybercrime. To anyone facing similar challenges or contemplating investments in the digital realm, I offer a word of caution and encouragement. Trust your instincts, conduct thorough research, and seek guidance from reputable professionals like RESILIENT SHIELD RECOVERY. when needed. Their expertise and dedication are invaluable assets in safeguarding your financial future. While the scars of this experience may linger, I am grateful for the silver lining provided by RESILIENT SHIELD RECOVERY.. They have not only restored my faith in financial security but also empowered me to protect my daughter's future with renewed vigor and determination. Together, we forge ahead, fortified by hard-earned lessons.  
    • Fast Leaf Decay (by olafskiii) Rubidium (by Asek3) Artifacts (by ochotonida) Framework (by MrCrayfish) Max Health Fix (by DarkhaxDev) Embeddium/Rubidium Extras (by Txni) Essential Mod (by SparkUniverse_) Immersive Aircraft [Fabric/Forge] (by Conczin) Cherished Worlds (Fabric/Forge/NeoForge/Quilt) (by TheIllusiveC4) ExpandAbility (by florensie) Sophisticated Core (by P3pp3rF1y) Tinkers' Levelling Addon (by Pyre540) Better Advancements (by way2muchnoise) Immersive Melodies [Fabric/Forge] (by Conczin) Citadel (by sbom_xela) Vampirism - Become a vampire! (by maxanier) FerriteCore ((Neo)Forge) (by malte0811) CoroUtil (by Corosus) Create Big Cannons (by rbasamoyai) Controlling (by Jaredlll08) Cloth Config API (Fabric/Forge/NeoForge) (by shedaniel) Mekanism (by bradyaidanc) BetterF3 (by cominixo) Supplementaries (by MehVahdJukaar) Chest Cavity - Forge Port (by booneldanforever) ConnectedTexturesMod (by tterrag1098) NetherPortalFix (by BlayTheNinth) Spartan Weaponry (by ObliviousSpartan) Charm of Undying (Fabric/Forge/Quilt) (by TheIllusiveC4) Plushie Mod (by Link4real) JourneyMap (by techbrew) Farmer's Delight (by vectorwing) Connectivity[Forge/Fabric] (by someaddon) Create : Misc & Things (by To0pa) Create: Steam 'n' Rails (by IThundxr) Shutup Experimental Settings! (by Corgi_Taco) Alex's Mobs (by sbom_xela) Quark (by Vazkii) Tool Belt (by gigaherz) Just Enough Items (JEI) (by mezz) Bookshelf (by DarkhaxDev) FastWorkbench (by Shadows_of_Fire) Tinkers Construct (by mDiyo) Collective (by Serilum) Inventory HUD+ (by dmitrylovin) Explorer's Compass (by Chaosyr) playerAnimator (by KosmX) Size Devices (by DaFlame_rl) Jade 🔍 (by Snownee) Create Slice & Dice (by possible_triangle) Create Jetpack (by possible_triangle) Carry On (by Tschipp) Moonlight Lib (by MehVahdJukaar) Kotlin for Forge (by thedarkcolour) CraftTweaker (by Jaredlll08) Just Enough Resources (JER) (by way2muchnoise) AI Improvements (by QueenOfMissiles) Patchouli (by Vazkii) Catalogue (by MrCrayfish) Tool Stats (by DarkhaxDev) It Takes a Pillage (by izofar) JEITweaker (by Jaredlll08) Waystones (by BlayTheNinth) Vampires Need Umbrellas (by focamacho) Oculus (by Asek3) Mantle (by mDiyo) Mob Grinding Utils (by vadis365) Chiseled (by freepeopleworking) AutoRegLib (by Vazkii) Mystical Agriculture (by BlakeBr0) Embeddium/Rubidium Dynamic Lights (by Txni) Flywheel (Legacy) (by jozufozu) Builder's Delight (Forge) (by Tynoxs) Apotheosis (by Shadows_of_Fire) What Are They Up To (Watut) (by Corosus) Create: Interiors (by sudolev) FastFurnace (by Shadows_of_Fire) Balm (Forge Edition) (by BlayTheNinth) Clumps (by Jaredlll08) Iris & Oculus Flywheel Compat (by leon_mout) Configured (by MrCrayfish) Tinkers' Expansion (by Insane96) Crafting on a stick (by OfekN_) MrCrayfish's Gun Mod (by MrCrayfish) Create: Crystal Clear (by singularity_cyvack) FTB Library (Forge) (by FTB) AppleSkin (by squeek502) Curios API (Forge/NeoForge) (by TheIllusiveC4) Better Third Person (by Socolio) Caelus API (Forge/NeoForge) (by TheIllusiveC4) Sons Of Sins (by Furti_Two) SwingThroughGrass (by exidex) AttributeFix (by DarkhaxDev) Quests Additions (Forge) (by NaturaSpell) Building Gadgets (by Direwolf20) Enchantment Descriptions (by DarkhaxDev) Skin Layers 3D (Fabric/Forge) (by tr7zw) Bad Wither No Cookie - Reloaded (by Kreezxil) Placebo (by Shadows_of_Fire) FTB Teams (Forge) (by FTB) Mod Name Tooltip (by mezz) Enigmatic Graves (by Quarris) Sophisticated Backpacks (by P3pp3rF1y) GeckoLib (by Gecko) Builders Crafts & Additions (by MRHminer) Immersive Portals (for Forge) (by qouteall) Architectury API (Fabric/Forge/NeoForge) (by shedaniel) Lazy DataFixerUpper(LazyDFU) [FORGE] (by Corgi_Taco) Create Ore Excavation (by tom54541) Tinkers' Rapier (by sz0999312) Mowzie's Mobs (by bobmowzie) Better Combat [Fabric & Forge] (by daedelus_dev) Create Stuff & Additions (by Furti_Two) Cucumber Library (by BlakeBr0) FPS Reducer (by bre2el) Item Filters (by LatvianModder) FTB Quests (Forge) (by FTB) L_Ender 's Cataclysm (by mcl_ender) Starter Kit (by Serilum) Feature NBT Deadlock Be Gone (by telepathicgrunt) Materialis (by RCXcrafter) KleeSlabs (by BlayTheNinth) Pehkui (by Virtuoel) Grappling Hook Mod (by yyonne) Security Craft (by Geforce132) Ars Nouveau (by baileyholl2) Mouse Tweaks (by YaLTeR) Werewolves - Become a Beast! (by Cheaterpaul) Elytra Slot (Fabric/Forge/Quilt) (by TheIllusiveC4) Create (by simibubi) Budschie's Morph Mod (by budschie_) Ore Excavation (by Funwayguy) Create Confectionery (by Furti_Two)
    • Hello, im kind of a newbie on creating mods, and i been trying to make simples mods so far, Right now, i'm creating a mod which detect an specific type of mob and kill it if reach a certain number, by far the mod is detecting the mob and counting them but at the time it reach the limit number, it don't do anything. The Game don't tweak, don't crash, just i't don't run the method i call, which is kill().   public InteractionResultHolder<ItemStack> use(Level pLevel, Player pPlayer, InteractionHand pUsedHand) { final var TotalCows = pLevel.getNearbyEntities(Cow.class, TargetingConditions.forNonCombat(), pPlayer, pPlayer.getBoundingBox().inflate(5)); if(pLevel.isClientSide){ if(pPlayer.getItemInHand(InteractionHand.MAIN_HAND).getItem() == this.asItem()){ if(!TotalCows.isEmpty()){ if(TotalCows.get(0).isAlive()){ TotalCows.get(0).kill(); } }else{ pPlayer.sendSystemMessage(Component.literal("No hay vacas")); } } } The sendSystemMessage is get triggered, and when i change the method .kill() by any other like send a message it got called, can i get some tips, and a clue of what i'm missing
    • UPD: I DID IT   @Override public void applyEffectTick(LivingEntity livingEntity, int pAmplifier) { Level level = livingEntity.level(); if (!level.isClientSide()) { Holder<DamageType> entropyHolder = level .registryAccess() .registryOrThrow(Registries.DAMAGE_TYPE) .getHolderOrThrow(GTDamageTypes.ENTROPY_KEY); livingEntity.hurt(new DamageSource(entropyHolder), 1); } super.applyEffectTick(livingEntity, pAmplifier); }  
    • So I came to this public class ModDamageTypes{ public static void bootstrap(BootstapContext<DamageType> context) { context.register(GTDamageTypes.ENTROPY_KEY, new DamageType(GrimTales.MOD_ID + "_entropy", 0.1f)); } } public class GTDamageTypes implements DamageTypes { public static final ResourceKey<DamageType> ENTROPY_KEY = register("entropy"); private static ResourceKey<DamageType> register(String name) { return ResourceKey.create(Registries.DAMAGE_TYPE, new ResourceLocation(GrimTales.MOD_ID, name)); } } public class ModWorldGenProvider extends DatapackBuiltinEntriesProvider { public static final RegistrySetBuilder BUILDER = new RegistrySetBuilder() .add(Registries.DAMAGE_TYPE, ModDamageTypes::bootstrap); public ModWorldGenProvider(PackOutput output, CompletableFuture<HolderLookup.Provider> registries) { super(output, registries, BUILDER, Set.of(GrimTales.MOD_ID)); } But! I still have an issue that, I cannot just use Holder.direct, due to it will create error that "Required type:  Holder<DamageType>  Provided : Holder<ResourceKey<DamageType>>" And I still have no clue how to fix it
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.