[1.12] Butcher Harvesting Meat Doesn't do Anything

[OrangeVillager61]

Hello! I am trying to get a butcher to go to mobs and "harvest" a meat out of them. More specifically, the butcher goes up to the mob, gets one meat, type depending on the mob and then goes to another after 10 secs. However, my butcher does nothing and the first println doesn't go off.

 

public class VillagerAIHarvestMeat extends EntityAIBase
{
	public final double VilPerDoor = Config.VilPerDoor;
    private final IvVillager villagerObj;
    private EntityAnimal animal;
    int mateAgain;
    protected Random rand = new Random();
    private World world;
    String animal_type;
    int delayCounter;

    public VillagerAIHarvestMeat(IvVillager villagerIn)
    {
        this.villagerObj = villagerIn;
        this.world = villagerIn.world;
        this.setMutexBits(3);
    }

    /**
     * Returns whether the EntityAIBase should begin execution.
     */
    public boolean shouldExecute()
    {
    	if (this.villagerObj.getWorkTicks() > 0)
    	{
    		return false;
    	}
        if (this.villagerObj.getGrowingAge() != 0)
        {
            return false;
        }
        if (this.villagerObj.wantsMoreFood() == false)
        {
        	return false;
        }
        if (this.villagerObj.getProfession() != 4)
        {
        	return false;
        }
        else
        {
            EntityAnimal entity = (EntityAnimal) this.world.findNearestEntityWithinAABB(EntityAnimal.class, this.villagerObj.getEntityBoundingBox().expand(100.0D, 7.0D, 100.0D), this.villagerObj);

            if (entity == null)
            {
                 return false;
            }
            if (this.villagerObj.world.getWorldTime() - entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() < 24000 || entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() == 0)
			{
				return false;
			}
            if (entity.getGrowingAge() < 0)
            {
            	return false;
            }
            if (entity instanceof EntityCow)
            {
            	this.animal_type = "Cow";
            	return true;
            }
            else if (entity instanceof EntityPig)
            {
            	this.animal_type = "Pig";
            	return true;
            }
            else if (entity instanceof EntitySheep)
            {
            	this.animal_type = "Sheep";
            	return true;
            }
            else if (entity instanceof EntityChicken)
            {
            	this.animal_type = "Chicken";
            	return true;
            }
            else
            {
            	return false;
            }            
        }
    }
    /**
     * Execute a one shot task or start executing a continuous task
     */
    public void startExecuting()
    {
        System.out.println("Butcher task approved.");
        this.delayCounter = 0;
    }
    /**
     * Returns whether an in-progress EntityAIBase should continue executing
     */
    public boolean continueExecuting()
    {
        if (this.animal.getGrowingAge() < 0)
        {
            return false;
        }
        else if (!this.animal.isEntityAlive())
        {
            return false;
        }
        else
        {
            System.out.println("Butcher task allowed to continue.");
        	return true;
        }
    }
    /**
     * Resets the task
     */
    public void resetTask()
    {
        this.animal = null;
    }
    /**
     * Updates the task
     */
    public void updateTask()
    {
        System.out.println("Butcher to animal.");
        if (this.villagerObj.getDistanceSqToEntity(this.animal) > 2.25D)
        {
            if (--this.delayCounter <= 0)
            {
                this.delayCounter = 10;
                this.villagerObj.getNavigator().tryMoveToEntityLiving(this.animal, 0.53D);
            }
        }
        else
        {
        	this.getMeat();
        }
    }

    private void getMeat()
    {
    	if (this.animal_type == "Cow")
    	{
    		this.animal.dropItem(Items.COOKED_BEEF, 1);
    	}
    	else if (this.animal_type == "Pig")
    	{
    		this.animal.dropItem(Items.COOKED_PORKCHOP, 1);
    	}
    	else if (this.animal_type == "Sheep")
    	{
    		this.animal.dropItem(Items.COOKED_MUTTON, 1);
    	}
    	else if (this.animal_type == "Chicken")
    	{
    		this.animal.dropItem(Items.COOKED_CHICKEN, 1);
    	}
        System.out.println("Butcher got the meat.");
    	this.villagerObj.setWorkTicks(200);
    	this.animal.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).setTime(this.animal.world.getWorldTime());
    }


}

public class HarvestTimeUser implements IHarvestTime{
	
	private long time = 0;
	
	@Override
	public void setTime(long l)
	{
		this.time = l;
	}

	@Override
	public long get_time() {
		return time;
	}

}

 

[jabelar]

Why did you only put one print statement? If you want to debug you should put a print in every if statement to figure out which path is executing.

 

Without thinking too much about it, I expect your shouldExecute() is always returning false. So add print statements in each if within that method and check if any of those are triggering and returning false.

[OrangeVillager61]

18 hours ago, jabelar said:

Why did you only put one print statement? If you want to debug you should put a print in every if statement to figure out which path is executing.

 

Without thinking too much about it, I expect your shouldExecute() is always returning false. So add print statements in each if within that method and check if any of those are triggering and returning false.

Alright, I added printlns throughout my code and fixed many issues but I'm reaching a major issue where shouldExecute doesn't start at all according to my printlns.

public boolean shouldExecute()
    {
    	System.out.println("Should Execute started."); //Doesn't fire
        if (this.villagerObj.getGrowingAge() != 0)
        {
    		System.out.println("Isn't adult");
            return false;
        }
        else if (this.villagerObj.wantsMoreFood() == false)
        {
    		System.out.println("Doesn't want food");
        	return false;
        }
        else if (this.villagerObj.getProfession() != 4)
        {
    		System.out.println("Is not a butcher");
        	return false;
        }
        else
        {
            EntityAnimal entity = (EntityAnimal) this.world.findNearestEntityWithinAABB(EntityAnimal.class, this.villagerObj.getEntityBoundingBox().expand(100.0D, 7.0D, 100.0D), this.villagerObj);

            if (entity == null)
            {
        		System.out.println("Entity is null");
                return false;
            }
            if (this.villagerObj.world.getWorldTime() - entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() < 24000 && entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() != 0)
			{
        		System.out.println("Entity has been harvested");
				return false;
			}
            if (entity.getGrowingAge() < 0)
            {
        		System.out.println("Entity is not adult");
            	return false;
            }
            if (entity instanceof EntityCow)
            {
            	this.animal_type = "Cow";
            	return true;
            }
            else if (entity instanceof EntityPig)
            {
            	this.animal_type = "Pig";
            	return true;
            }
            else if (entity instanceof EntitySheep)
            {
            	this.animal_type = "Sheep";
            	return true;
            }
            else if (entity instanceof EntityChicken)
            {
            	this.animal_type = "Chicken";
            	return true;
            }
            else
            {
        		System.out.println("Entity is not harvestable");
            	return false;
            }            
        }
    }

 

[OrangeVillager61]

Forgot to put where it was being called:

 

protected void setAdditionalAItasks()
    {
        if (!this.areAdditionalTasksSet)
        {
            this.areAdditionalTasksSet = true;

            if (this.isChild())
            {
                this.tasks.addTask(8, new EntityAIPlay(this, 0.32D));
            }
            else if (this.getProfessionForge() == PROFESSION_FARMER || this.getProfession() == 0)
            {
                this.tasks.addTask(6, new EntityAIHarvestFarmland(this, 0.6D));
            }
            else if (this.getProfession() == 4 || this.getProfessionForge() == PROFESSION_BUTCHER)
            {
                this.tasks.addTask(6, new VillagerAIHarvestMeat(this));
            }
            if (this.getHired())
            {
                this.tasks.addTask(6, new VillagerFollowOwner(this, 0.9D, 6.0F, 1.5F));
            }
        }
    }

 

[OrangeVillager61]

Github link:

https://github.com/Orange1861/Improved-Villagers/tree/Orange1861-1.12_Version

[jabelar]

You should keep going with the print statements. For example are you sure that the add task is even being called? Put a print statement there.

 

If you're confident that that the AI task is actually being properly added to the entity, then it may be that the mutex bits are set wrong, or maybe if they are set right but another AI task is already running. The mutex bits prevent two AI from running at the same time that might conflict with each other. So if a higher priority AI task is already running, the shouldExecute() for your AI task won't ever be called.

[OrangeVillager61]

2 hours ago, jabelar said:

You should keep going with the print statements. For example are you sure that the add task is even being called? Put a print statement there.

 

If you're confident that that the AI task is actually being properly added to the entity, then it may be that the mutex bits are set wrong, or maybe if they are set right but another AI task is already running. The mutex bits prevent two AI from running at the same time that might conflict with each other. So if a higher priority AI task is already running, the shouldExecute() for your AI task won't ever be called.

What are the mutex bits?

[jabelar]

In your code posted above, in the constructor of your AI class you call the setMutexBits(3) method. Which means you set the mutex bits to value of 3. "Mutex" is short for "mutually exclusive" and works sort of like a mask. 

 

I have a tutorial on making entity AI which discusses mutex bits about 1/3rd way down the page: http://jabelarminecraft.blogspot.com/p/minecraft-forge-1721710-custom-entity-ai.html

[OrangeVillager61]

13 hours ago, jabelar said:

In your code posted above, in the constructor of your AI class you call the setMutexBits(3) method. Which means you set the mutex bits to value of 3. "Mutex" is short for "mutually exclusive" and works sort of like a mask. 

 

I have a tutorial on making entity AI which discusses mutex bits about 1/3rd way down the page: http://jabelarminecraft.blogspot.com/p/minecraft-forge-1721710-custom-entity-ai.html

Hmm, I changed the MutexBits and it didn't do anything. Also, the AI is crashing the game when ever I relog at the updateTask at this line:

        if (this.villagerObj.getDistanceSqToEntity(this.animal) > 2.25D)

However, it is not giving me the println that I put at the start of updateTask, it doesn't make sense. 

[OrangeVillager61]

Even though it still doesn't do anything but crash the game.

[OrangeVillager61]

On 8/20/2017 at 2:05 PM, jabelar said:

You should keep going with the print statements. For example are you sure that the add task is even being called? Put a print statement there.

 

If you're confident that that the AI task is actually being properly added to the entity, then it may be that the mutex bits are set wrong, or maybe if they are set right but another AI task is already running. The mutex bits prevent two AI from running at the same time that might conflict with each other. So if a higher priority AI task is already running, the shouldExecute() for your AI task won't ever be called.

Okay, it looks like the addTask isn't being called. I can't find the issue though.

	protected void setAdditionalAItasks()
    {
        if (!this.areAdditionalTasksSet)
        {
            this.areAdditionalTasksSet = true;

            if (this.isChild())
            {
                this.tasks.addTask(8, new EntityAIPlay(this, 0.32D));
            }
            else if (this.getProfessionForge() == PROFESSION_FARMER || this.getProfession() == 0)
            {
                this.tasks.addTask(5, new EntityAIHarvestFarmland(this, 0.6D));
            }
            else if (this.getProfession() == 4 || this.getProfessionForge() == PROFESSION_BUTCHER)
            {
                this.tasks.addTask(5, new VillagerAIHarvestMeat(this));
                System.out.println("Villager will now harvest meat.");
            }
            if (this.getHired())
            {
                this.tasks.addTask(5, new VillagerFollowOwner(this, 0.9D, 6.0F, 1.5F));
            }
        }
    }

I know that the function is being called since the farming task is working fine.

[OrangeVillager61]

Hmm, actually it is getting called. Still not working though.

 

To summarize my current issue, I can't figure out why my task is either not getting called (I may have fixed it) or the task stops before shouldExecute is called.

Edited August 22, 2017 by OrangeVillager61

[OrangeVillager61]

Hmm, after further testing. MC tries to run the AI after a relog but it crashes on the attempt to do so:

 

public class VillagerAIHarvestMeat extends EntityAIBase
{
    private final IvVillager villagerObj;
    private EntityAnimal animal;
    int mateAgain;
    protected Random rand = new Random();
    private World world;
    String animal_type;
    int delayCounter;

    public VillagerAIHarvestMeat(IvVillager villagerIn)
    {
        this.villagerObj = villagerIn;
        this.world = villagerIn.world;
        this.setMutexBits(1);
    }

    /**
     * Returns whether the EntityAIBase should begin execution.
     */
    public boolean shouldExecute()
    {
    	System.out.println("Should Execute started.");
        if (this.villagerObj.getGrowingAge() != 0)
        {
    		System.out.println("Isn't adult");
            return false;
        }
        else if (this.villagerObj.wantsMoreFood() == false)
        {
    		System.out.println("Doesn't want food");
        	return false;
        }
        else if (this.villagerObj.getProfession() != 4)
        {
    		System.out.println("Is not a butcher");
        	return false;
        }
        else
        {
            EntityAnimal entity = (EntityAnimal) this.world.findNearestEntityWithinAABB(EntityAnimal.class, this.villagerObj.getEntityBoundingBox().expand(100.0D, 7.0D, 100.0D), this.villagerObj);

            if (entity == null)
            {
        		System.out.println("Entity is null");
                return false;
            }
            if (this.villagerObj.world.getWorldTime() - entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() < 24000 && entity.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).get_time() != 0)
			{
        		System.out.println("Entity has been harvested");
				return false;
			}
            if (entity.getGrowingAge() < 0)
            {
        		System.out.println("Entity is not adult");
            	return false;
            }
            if (entity instanceof EntityCow)
            {
            	this.animal_type = "Cow";
            	entity = this.animal;
            	return true;
            }
            else if (entity instanceof EntityPig)
            {
            	this.animal_type = "Pig";
            	entity = this.animal;
            	return true;
            }
            else if (entity instanceof EntitySheep)
            {
            	this.animal_type = "Sheep";
                entity = this.animal;
            	return true;
            }
            else if (entity instanceof EntityChicken)
            {
            	this.animal_type = "Chicken";            	
            	entity = this.animal;
            	return true;
            }
            else
            {
        		System.out.println("Entity is not harvestable");
            	return false;
            }            
        }
    }
    /**
     * Execute a one shot task or start executing a continuous task
     */
    public void startExecuting()
    {
        System.out.println("Butcher task approved.");
        this.delayCounter = 0;
    }
    /**
     * Returns whether an in-progress EntityAIBase should continue executing
     */
    public boolean continueExecuting()
    {
    	if (!this.animal.isEntityAlive())
        {
            return false;
        }
    	else if (this.villagerObj.getNavigator().noPath())
    	{
    		return false;
    	}
        else
        {
            System.out.println("Butcher task allowed to continue.");
        	return true;
        }
    }
    /**
     * Resets the task
     */
    public void resetTask()
    {
        this.villagerObj.getNavigator().clearPathEntity();
        this.delayCounter = 5;
    }
    /**
     * Updates the task
     */
    public void updateTask()
    {
        System.out.println(this.animal);
        if (this.villagerObj.getDistanceSqToEntity(this.animal) > 2.25D)
        {
            if (--this.delayCounter <= 0)
            {
                this.delayCounter = 10;
                this.villagerObj.getNavigator().tryMoveToEntityLiving(this.animal, 0.53D);
            }
        }
        else
        {
        	this.getMeat();
        }
    }

    private void getMeat()
    {
    	if (this.animal_type == "Cow")
    	{
    		this.animal.dropItem(Items.COOKED_BEEF, 1);
    	}
    	else if (this.animal_type == "Pig")
    	{
    		this.animal.dropItem(Items.COOKED_PORKCHOP, 1);
    	}
    	else if (this.animal_type == "Sheep")
    	{
    		this.animal.dropItem(Items.COOKED_MUTTON, 1);
    	}
    	else if (this.animal_type == "Chicken")
    	{
    		this.animal.dropItem(Items.COOKED_CHICKEN, 1);
    	}
        System.out.println("Butcher got the meat.");
    	this.villagerObj.setWorkTicks(200);
    	this.animal.getCapability(HarvestTimeProvider.CAPABILITY_HARVEST_ANIMAL_TIME, null).setTime(this.animal.world.getWorldTime());
    }


}

 

Edited August 22, 2017 by OrangeVillager61

[OrangeVillager61]

Forgot to post crash report:

 

[22:25:54] [Server thread/INFO] [STDOUT]: [orangeVillager61.ImprovedVillagers.Entities.IvVillager:setAdditionalAItasks:806]: Villager will now harvest meat.
[22:25:54] [Server thread/INFO]: Preparing spawn area: 53%
[22:25:54] [Server thread/INFO] [STDOUT]: [orangeVillager61.ImprovedVillagers.Entities.AI.VillagerAIHarvestMeat:shouldExecute:46]: Should Execute started.
[22:25:54] [Server thread/INFO] [STDOUT]: [orangeVillager61.ImprovedVillagers.Entities.AI.VillagerAIHarvestMeat:startExecuting:113]: Butcher task approved.
[22:25:54] [Server thread/INFO] [STDOUT]: [orangeVillager61.ImprovedVillagers.Entities.AI.VillagerAIHarvestMeat:updateTask:149]: Butcher to animal.
[22:25:54] [Server thread/ERROR]: Encountered an unexpected exception
net.minecraft.util.ReportedException: Ticking entity
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:842) ~[MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:740) ~[MinecraftServer.class:?]
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:192) ~[IntegratedServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:589) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_121]
Caused by: java.lang.NullPointerException
	at net.minecraft.entity.Entity.getDistanceSqToEntity(Entity.java:1627) ~[Entity.class:?]
	at orangeVillager61.ImprovedVillagers.Entities.AI.VillagerAIHarvestMeat.updateTask(VillagerAIHarvestMeat.java:150) ~[VillagerAIHarvestMeat.class:?]
	at net.minecraft.entity.ai.EntityAITasks.onUpdateTasks(EntityAITasks.java:114) ~[EntityAITasks.class:?]
	at net.minecraft.entity.EntityLiving.updateEntityActionState(EntityLiving.java:843) ~[EntityLiving.class:?]
	at net.minecraft.entity.EntityLivingBase.onLivingUpdate(EntityLivingBase.java:2565) ~[EntityLivingBase.class:?]
	at net.minecraft.entity.EntityLiving.onLivingUpdate(EntityLiving.java:647) ~[EntityLiving.class:?]
	at net.minecraft.entity.EntityAgeable.onLivingUpdate(EntityAgeable.java:201) ~[EntityAgeable.class:?]
	at orangeVillager61.ImprovedVillagers.Entities.IvVillager.onLivingUpdate(IvVillager.java:619) ~[IvVillager.class:?]
	at net.minecraft.entity.EntityLivingBase.onUpdate(EntityLivingBase.java:2381) ~[EntityLivingBase.class:?]
	at net.minecraft.entity.EntityLiving.onUpdate(EntityLiving.java:346) ~[EntityLiving.class:?]
	at net.minecraft.world.World.updateEntityWithOptionalForce(World.java:2141) ~[World.class:?]
	at net.minecraft.world.WorldServer.updateEntityWithOptionalForce(WorldServer.java:872) ~[WorldServer.class:?]
	at net.minecraft.world.World.updateEntity(World.java:2101) ~[World.class:?]
	at net.minecraft.world.World.updateEntities(World.java:1912) ~[World.class:?]
	at net.minecraft.world.WorldServer.updateEntities(WorldServer.java:644) ~[WorldServer.class:?]
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:836) ~[MinecraftServer.class:?]
	... 4 more

 

[Draco18s]

if (this.villagerObj.getDistanceSqToEntity(this.animal) > 2.25D) //Crashes here

No, it's crashing trying to calculate the distance. Inside this function.

There's only one object here that could be null:

this.animal

Do a search of your file for "animal =" and tell me what you find and if you still have a problem.