[SOLVED] [1.11.2] Locking a Chest - Just Need Confirmation

[HalestormXV]

Hey everyone, in my mod I have added in the ability for players to "lock their chest", this is mainly for SMP so that chests owned by players cannot be broken or opened unless they are the player that locked the said chest. This was a relatively simple setup, but it felt as if it was almost too simple. Can someone maybe take a look at this code and tell me if anything is wrong with it? It seems to actually work in my Dev environment, but as we know the Dev environment is the Dev Environment. I wouldn't want to push this to live and then it turns out something was wrong with it from the start.

 

Furthermore, as you can see I commented out some lines

Specifically: tileTag.setString("divinationLock_k_pname", player.getPersistentID().toString()); (in the item class)

if (!tileTag.getUniqueId("divinationLock").equals(event.getEntityPlayer().getPersistentID())) (in my chest handler)

and I had

tileTag.setUniqueID("divinationLock_k_pname", player.getPersistentID());

in my item class I think, but I may have erased it. I mainly did those to add UUID support to the item in the event the player changes their name. Is that the correct way to do it? 

 

However the UUID support question is last on the prioirty. I just need to know if the code that i have now is accurate and looks as if it can work. And yes I did do debugging of course, but sometimes a fresh set of eyes works wonders.

 

https://pastebin.com/ZcLpgh7Y  - Item Class

https://pastebin.com/PJFJzqKn - Chest Handler

Edited August 29, 2017 by HalestormXV

[HalestormXV]

BUMP

[xCassyx]

Yeah, that's it. It seems all correct, but I would recommend testing your mod/plugin on single-player and on a server just to make sure.

Edited August 26, 2017 by xCassyx
Grammar

[HalestormXV]

Yeah it works on both but they are both Dev environment so before I push it live and then find out something is wrong (Which I know is sometimes the only way to do it) I wanted to ask here first.

 

Any thoughts on using the UUID instead of the player name? Would the setPersistentID and getPersistentID be the way to go about that?

[Draco18s]

3 hours ago, HalestormXV said:

Any thoughts on using the UUID instead of the player name? Would the setPersistentID and getPersistentID be the way to go about that?

UUID is the way to go. Never* use a reference to an entity other than by UUID.

 

*There are exceptions, but they're rare

Edited August 26, 2017 by Draco18s

[xCassyx]

Yeah, HalestormXV, persistent UUIDs are always the way to go. I was a little confused by your code, because it looked like in some places you were using UUIDs and in others, player names. Always use UUIDs when an entity may need to be referenced over multiple sessions. Another thing to note is that you will need to store the locked chest data in the world folder somewhere so you can reapply the locks when the server loads. I would recommend a custom NBT file.