NoSuchMethod: ClientCommandHandler.instance.registerCommand

[PlanetTeamSpeak]

I have made a client command command which I registered with 

ClientCommandHandler.instance.registerCommand(new Commandcalc());

which works fine in Eclipse but once compiled and loaded with forge it says NoSuchMethod, any ideas?

Edited August 28, 2017 by PlanetTeamSpeak

[Draco18s]

Show more of your code.

Where is your registration?

[PlanetTeamSpeak]

package com.ptsmods.morecommands;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Set;

import org.reflections.Reflections;

import com.ptsmods.morecommands.commands.chelp.Commandchelp;
import com.ptsmods.morecommands.commands.enchant.Commandenchant;
import com.ptsmods.morecommands.commands.fixTime.CommandfixTime;
import com.ptsmods.morecommands.miscellaneous.CommandBase;
import com.ptsmods.morecommands.miscellaneous.CommandType;
import com.ptsmods.morecommands.miscellaneous.IncorrectCommandType;
import com.ptsmods.morecommands.miscellaneous.Reference;
import com.ptsmods.morecommands.miscellaneous.Reference.LogType;

import net.minecraft.block.Block;
import net.minecraft.client.settings.KeyBinding;
import net.minecraft.command.ICommand;
import net.minecraft.init.Blocks;
import net.minecraftforge.client.ClientCommandHandler;
import net.minecraftforge.fml.client.registry.ClientRegistry;
import net.minecraftforge.fml.common.event.FMLServerStartingEvent;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public abstract class Initialize {

	public static void registerCommands(FMLServerStartingEvent event) {
		Reference.print(LogType.INFO, "Registering MoreCommands server sided commands.");

		ICommand[] nonRegistryCommands = new ICommand[] {new CommandfixTime(), new Commandenchant()};
		ICommand[] commands;
		try {
			commands = Reference.getCommandRegistry(CommandType.SERVER).toArray(new ICommand[0]);
		} catch (IncorrectCommandType e1) {
			e1.printStackTrace();
			return;
		}

		Integer counter = 0;
		Integer fails = 0;
		List<String> failList = new ArrayList<>();

		for (ICommand command : commands)
			try {
				event.registerServerCommand(command);
				counter += 1;
			} catch (Exception e) {fails += 1; failList.add(command.getName()); continue;}

		for (ICommand command : nonRegistryCommands)
			try {
				event.registerServerCommand(command);
				counter += 1;
			} catch (Exception e) {
				fails += 1;
				failList.add(command.getName());
				e.printStackTrace();
				continue;
			}

		Reference.print(LogType.INFO, "Successfully registered " + counter.toString() + " server sided commands, with " + fails.toString() + " fails.");
		if (!(failList.size() == 0)) Reference.print(LogType.INFO, "Failed to register " + CommandBase.joinNiceString(failList.toArray(new String[0])));
	}

	@SideOnly(Side.CLIENT)
	public static void registerClientCommands() {
		Reference.print(LogType.INFO, "Registering MoreCommands client sided commands.");

		ICommand[] nonRegistryCommands = new ICommand[] {new Commandchelp()};
		ICommand[] commands;
		try {
			commands = Reference.getCommandRegistry(CommandType.CLIENT).toArray(new ICommand[0]);
		} catch (IncorrectCommandType e1) {
			e1.printStackTrace();
			return;
		}

		Integer counter = 0;
		Integer fails = 0;
		List<String> failList = new ArrayList<>();

		for (ICommand command : commands)
			try {
				ClientCommandHandler.instance.registerCommand(command);
				counter += 1;
			} catch (Exception e) {fails += 1; failList.add(command.getName()); continue;}

		for (ICommand command : nonRegistryCommands)
			try {
				ClientCommandHandler.instance.registerCommand(command);
				counter += 1;
			} catch (Exception e) {
				fails += 1;
				failList.add(command.getName());
				e.printStackTrace();
				continue;
			}

		Reference.print(LogType.INFO, "Successfully registered " + counter.toString() + " client sided commands, with " + fails.toString() + " fails.");
		if (!(failList.size() == 0)) Reference.print(LogType.INFO, "Failed to register " + CommandBase.joinNiceString(failList.toArray(new String[0])));
	}

	public static void setupBlockLists() {
		Reference.print(LogType.INFO, "Setting up the MoreCommands block blacklist.");

		Block[] blacklist = {Blocks.AIR, Blocks.LAVA, Blocks.CACTUS, Blocks.MAGMA, Blocks.ACACIA_FENCE, Blocks.ACACIA_FENCE_GATE, Blocks.BIRCH_FENCE, Blocks.BIRCH_FENCE_GATE, Blocks.DARK_OAK_FENCE, Blocks.DARK_OAK_FENCE_GATE,
				Blocks.JUNGLE_FENCE, Blocks.JUNGLE_FENCE_GATE, Blocks.NETHER_BRICK_FENCE, Blocks.OAK_FENCE, Blocks.OAK_FENCE_GATE, Blocks.SPRUCE_FENCE, Blocks.SPRUCE_FENCE_GATE, Blocks.FIRE, Blocks.WEB, Blocks.MOB_SPAWNER,
				Blocks.END_PORTAL, Blocks.END_PORTAL_FRAME, Blocks.TNT, Blocks.IRON_TRAPDOOR, Blocks.TRAPDOOR, Blocks.BREWING_STAND};

		Integer counter = 0;

		for (Block element : blacklist) {
			Reference.addBlockToBlacklist(element);
			counter += 1;
		}

		Reference.print(LogType.INFO, "Successfully set up the block blacklist and added " + counter.toString() + " blocks.");
		Reference.print(LogType.INFO, "Setting up the MoreCommands block whitelist.");

		Block[] whitelist = {Blocks.AIR, Blocks.DEADBUSH, Blocks.VINE, Blocks.TALLGRASS, Blocks.ACACIA_DOOR, Blocks.BIRCH_DOOR, Blocks.DARK_OAK_DOOR, Blocks.IRON_DOOR, Blocks.JUNGLE_DOOR, Blocks.OAK_DOOR, Blocks.SPRUCE_DOOR,
				Blocks.DOUBLE_PLANT, Blocks.RED_FLOWER, Blocks.YELLOW_FLOWER, Blocks.BROWN_MUSHROOM, Blocks.RED_MUSHROOM, Blocks.WATERLILY, Blocks.BEETROOTS, Blocks.CARROTS, Blocks.WHEAT, Blocks.POTATOES, Blocks.PUMPKIN_STEM,
				Blocks.MELON_STEM, Blocks.SNOW_LAYER};

		counter = 0;

		for (Block element : whitelist) {
			Reference.addBlockToWhitelist(element);
			counter += 1;
		}

		Reference.print(LogType.INFO, "Successfully set up the block whitelist and added " + counter.toString() + " blocks.");
	}

	public static void setupCommandRegistry() {
		Set<Class<? extends CommandBase>> commands = new Reflections("com.ptsmods.morecommands.commands").getSubTypesOf(CommandBase.class);

		for (Class<? extends CommandBase> command : commands) {
			try {
				Reference.addCommandToRegistry(command.newInstance().getCommandType(), command.newInstance());
				command.newInstance().getPermission(); // just so it's registered in the permissions.
			} catch (IncorrectCommandType e) {
				e.printStackTrace();
			} catch (InstantiationException | IllegalAccessException e) {
				e.printStackTrace();
			} catch (NoClassDefFoundError e) {};
		}
	}

	@SideOnly(Side.CLIENT)
	public static void registerKeyBinds() {
		HashMap<String, KeyBinding> keyBindings = Reference.getKeyBindings();
		for (String keyBinding : keyBindings.keySet())
			ClientRegistry.registerKeyBinding(keyBindings.get(keyBinding));
	}

}

It's being called from postInit, it used to work just fine but I have been getting a lot of errors lately which idk where they came from.

[PlanetTeamSpeak]

It crashed the game when loading, not a server and thanks to the @SideOnly annotation, which the link you posted apparently says not to use, it only loads on the client.

[Choonster]

This probably isn't related to sides, though you should fix that as well.

 

CommandHandler#registerCommand is a vanilla method, which means it has a different name outside of the development environment. You need to use the build Gradle task to build your mod and reobfuscate it from MCP (deobfuscated) to SRG (obfuscated) names.

[PlanetTeamSpeak]

And how would I do that? I don't think I've ever had to that before.

[Choonster]

9 minutes ago, PlanetTeamSpeak said:

And how would I do that? I don't think I've ever had to that before.

 

If you're using an IDE with Gradle integration (e.g. IntelliJ IDEA), run the build task from the IDE's Gradle window. Otherwise open your mod directory in a command prompt/terminal and run gradlew build.

[PlanetTeamSpeak]

But that's exactly what didn't work, I built my mod, put it in %appdata%/.minecraft/mods, ran Minecraft and it said ClientCommandHandler.instance.registerCommand(ICommand) wasn't a function.

[Choonster]

15 minutes ago, PlanetTeamSpeak said:

But that's exactly what didn't work, I built my mod, put it in %appdata%/.minecraft/mods, ran Minecraft and it said ClientCommandHandler.instance.registerCommand(ICommand) wasn't a function.

 

Please post the full FML log (using Gist/Pastebin) from a run where this happens.

[PlanetTeamSpeak]

https://gist.github.com/PlanetTeamSpeakk/9886ec553ab5af1f6d9a1488ba19b1ff

[Choonster]

14 minutes ago, PlanetTeamSpeak said:

https://gist.github.com/PlanetTeamSpeakk/9886ec553ab5af1f6d9a1488ba19b1ff

 

You definitely built your mod with the build Gradle task and copied the built JAR from the build/libs directory?

 

If you open the JAR in a decompiler, are all of the other references to vanilla methods/fields obfuscated to SRG names like func_00211_a and field_02301_b?

[PlanetTeamSpeak]

According to javadecompilers.com, it doesn't. Maybe this is because I build it with a custom made gradle task? Which is

task renameJar(type: Jar) {
    manifest {
        attributes 'Implementation-Title': 'MoreCommands',
            'Implementation-Version': version,
            'Main-Class': 'com.ptsmods.morecommands.MoreCommands'
    }
    
    baseName = 'morecommands_' + version + '_mc1.11-1.12.1'
    from configurations.compile.collect { it.isDirectory() ? it : zipTree(it) }
    with jar
}

 

[Choonster]

1 minute ago, PlanetTeamSpeak said:

According to javadecompilers.com, it doesn't. Maybe this is because I build it with a custom made gradle task? Which is

task renameJar(type: Jar) {
    manifest {
        attributes 'Implementation-Title': 'MoreCommands',
            'Implementation-Version': version,
            'Main-Class': 'com.ptsmods.morecommands.MoreCommands'
    }
    
    baseName = 'morecommands_' + version + '_mc1.11-1.12.1'
    from configurations.compile.collect { it.isDirectory() ? it : zipTree(it) }
    with jar
}

 

 

That would probably be it. You need to tell ForgeGradle to reobfuscate the output of that task, like I do here.

 

[PlanetTeamSpeak]

After a while of trying to figuring out how, I managed to build the mod with shadowjar, but the problem is still here. According to javadecompilers.com it still says ClientCommandHandler.instance.registerCommand(ICommand). I built it with the command gradlew shadowJar (since gradlew build gave an error saying MISSING REPLACEMENT DATA FOR MAPPING_CHANNEL) with the following build.gradle:

buildscript {
    repositories {
        jcenter()
        maven {
            name = "forge"
            url = "http://files.minecraftforge.net/maven"
        }
    }
    dependencies {
        classpath 'net.minecraftforge.gradle:ForgeGradle:2.3-SNAPSHOT'
    }
}

plugins {
    id 'com.github.johnrengelman.shadow' version '1.2.4'
}

apply plugin: 'net.minecraftforge.gradle.forge'

version = "1.26.1"
group = "com.ptsmods.morecommands" // http://maven.apache.org/guides/mini/guide-naming-conventions.html
archivesBaseName = "MoreCommands"

sourceCompatibility = targetCompatibility = '1.8' // Need this here so eclipse task generates correctly.
compileJava {
    sourceCompatibility = targetCompatibility = '1.8'
}

minecraft {
    version = "1.12-14.21.1.2387"
    runDir = "run"
    mappings = "snapshot_20170624"
    makeObfSourceJar = false
}

dependencies {
    compile 'org.javassist:javassist:3.22.0-CR2'
    compile 'org.reflections:reflections:0.9.10'
    compile 'org.yaml:snakeyaml:1.18'
    compile 'com.google.guava:guava:23.0'
}

shadowJar {
    dependencies {
        include(dependency('org.javassist:javassist:3.22.0-CR2'))
        include(dependency('org.reflections:reflections:0.9.10'))
        include(dependency('org.yaml:snakeyaml:1.18'))
        include(dependency('com.google.guava:guava:23.0'))
    }

    classifier '' // Replace the default JAR
}

reobf {
    shadowJar {} // Reobfuscate the shadowed JAR
}

processResources {
    // this will ensure that this task is redone when the versions change.
    inputs.property "version", project.version
    inputs.property "mcversion", project.minecraft.version

    // replace stuff in mcmod.info, nothing else
    from(sourceSets.main.resources.srcDirs) {
        include 'mcmod.info'

        // replace version and mcversion
        expand 'version': project.version, 'mcversion': project.minecraft.version
    }

    // copy everything else, that's not the mcmod.info
    from(sourceSets.main.resources.srcDirs) {
        exclude 'mcmod.info'
    }
}

tasks.withType(JavaCompile) {
    options.encoding = 'UTF-8'
    options.compilerArgs.add('-Xlint:unchecked')
}

tasks.withType(Javadoc) {
    options.encoding = 'UTF-8'
}

task javadocJar(type: Jar, dependsOn: javadoc) {
    from javadoc.destinationDir
    classifier = 'javadoc'
}

artifacts {
    archives javadocJar
    archives shadowJar
}

 

[Choonster]

I'm not too sure what's going on, please post the full output from running the build task.

[PlanetTeamSpeak]

Apparently it was erroring because I didn't have 

sourceCompatibility = targetCompatibility = '1.8' // Need this here so eclipse task generates correctly.
compileJava {
    sourceCompatibility = targetCompatibility = '1.8'
}

in build.gradle, not sure why it needs it, but it works fine now and the NoSuchMethod error has been fixed.

Thanks for the help!