Hello,

I'm currently whriting on a basic mod for Minecraft.
While playing with the events of Minecraft i noticed, that the PlayerInteractEvent.RightClickBlock is fiered four times. Why?

Here is my Code:

package de.bestar.intensiveengineering.addons;

import de.bestar.intensiveengineering.Reference;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@Mod.EventBusSubscriber(modid = Reference.modId)
public class MyEventHandler {

    @SubscribeEvent
    public static void BlockRightClickEvent(PlayerInteractEvent.RightClickBlock event) {
        System.out.println("\n\nBlock\n");
    }

}

This is my Log:

 

[12:13:01] [main/INFO] [STDOUT]: [de.bestar.intensiveengineering.addons.MyEventHandler:BlockRightClickEvent:21]: 

Block

[12:13:01] [main/INFO] [STDOUT]: [de.bestar.intensiveengineering.addons.MyEventHandler:BlockRightClickEvent:21]: 

Block

[12:13:01] [Server thread/INFO] [STDOUT]: [de.bestar.intensiveengineering.addons.MyEventHandler:BlockRightClickEvent:21]: 

Block

[12:13:01] [Server thread/INFO] [STDOUT]: [de.bestar.intensiveengineering.addons.MyEventHandler:BlockRightClickEvent:21]: 

Block

 

2 times for the Client

and 2 times for the logical Server? Why?

6 minutes ago, BeStar said:

Hello,

I'm currently whriting on a basic mod for Minecraft.
While playing with the events of Minecraft i noticed, that the PlayerInteractEvent.RightClickBlock is fiered four times. Why?

Here is my Code:

package de.bestar.intensiveengineering.addons;

import de.bestar.intensiveengineering.Reference;
import net.minecraftforge.event.entity.player.PlayerInteractEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@Mod.EventBusSubscriber(modid = Reference.modId)
public class MyEventHandler {

    @SubscribeEvent
    public static void BlockRightClickEvent(PlayerInteractEvent.RightClickBlock event) {
        System.out.println("\n\nBlock\n");
    }

}

I think it's fired twice for CLIENT and twice for SERVER, add 

@SideOnly(Side.CLIENT)

above EventBusSubscriber

 

And make a counter of clicks, when the button is pressed, increase it by one and when it's 1, reset it to 0, only proceed when the counter is 0.

1 minute ago, diesieben07 said:

Once per logical side per hand.

 

No! No no no! Read this: http://mcforge.readthedocs.io/en/latest/concepts/sides/

 

No, even more no! Check PlayerInteractEvent::getHand.

Sorry for being wrong I guess...

4 hours ago, MGlolenstine said:

Sorry for being wrong I guess...

There's a reason this thread exists:

 

1 minute ago, Draco18s said:

There's a reason this thread exists:

 

Sorry didn't know that you others prefer Proxies

10 minutes ago, MGlolenstine said:

Sorry didn't know that you others prefer Proxies

It has nothing to do with preference, it has everything to do with logical sides vs. physical sides.

15 minutes ago, diesieben07 said:

Just to point this out, proxies are also the wrong tool here, as they check for physical side, just like @SideOnly.

and how do i fix it? I mean: How do i get the event just one time?

 

4 minutes ago, BeStar said:

and how do i fix it? I mean: How do i get the event just one time?

 

Did you not read that?

 

6 minutes ago, BeStar said:

and how do i fix it? I mean: How do i get the event just one time?

 

You don't. If you subscribe to it it will fire four times,but what you do is use the parameters passed with the event to test which side it is and which hand it is.

2 minutes ago, MrBendelScrolls said:

Did you not read that?

 

so: i just have to check event.getWorld().isRemote? (I mean it's cool because i can do different things for server or client)

2 minutes ago, jabelar said:

You don't. If you subscribe to it it will fire four times,but what you do is use the parameters passed with the event to test which side it is and which hand it is.

hm... sounds great

For example:

 

if (!event.getWorld().isRemote && event.getHand() == EnumHand.MAIN_HAND)

 

Will only execute once -- on the server with the main hand.

2 minutes ago, jabelar said:

For example:

 

if (!event.getWorld().isRemote && event.getHand() == EnumHand.MAIN_HAND)

 

Will only execute once -- on the server with the main hand.

great!

Finally i replaced it with:

 

@SubscribeEvent
public static void BlockRightClickEvent(PlayerInteractEvent.RightClickBlock event) {
    // client side
    if (event.getWorld().isRemote) {
        if (event.getHand().equals(EnumHand.MAIN_HAND)) {
        }
        else {
        }
    }
    // server side
    else {
        if (event.getHand().equals(EnumHand.MAIN_HAND)) {
        }
        else {
        }
    }
}