Search the Forums BEFORE making a new post.

[1.12]Custom ItemStack NBT not saving

Posted September 6, 20178 yr

As stated in title - code:

if (stack.getTagCompound() == null)
        {
            stack.setTagCompound(new NBTTagCompound());
        }
		stack.getTagCompound().setTag(tag, value);
	}

Quote

September 6, 20178 yr

Show more of your code. There are several reasons why this might fail, but in order to determine which one of those it is, we need to know where this code is.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

September 6, 20178 yr

Author

10 minutes ago, Draco18s said:

Show more of your code. There are several reasons why this might fail, but in order to determine which one of those it is, we need to know where this code is.

That bit of code is in my API, here it is from the item:

public static boolean isUsable(ItemStack stack) {
		return ((NBTTagInt) ItemData.getStackNBTTag(stack, "damag", new NBTTagInt(0))).getInt() > WingsConfig.detachableDamage ? false : true;
	}
	public static void useDamage(ItemStack stack) {
		int currDam = ((NBTTagInt) ItemData.getStackNBTTag(stack, "damag", new NBTTagInt(0))).getInt();
		if (isUsable(stack)) ItemData.setStackNBTTag(stack, "damag", new NBTTagInt(currDam + 1));
	}
	public boolean isDamageable() {
		return false;
	}
	
	public boolean getIsRepairable(ItemStack toRepair, ItemStack repair) {
		return repair.getItem() == Items.LEATHER;
	}
	
	public double getDurabilityForDisplay(ItemStack stack) {
		return (double)((NBTTagInt) ItemData.getStackNBTTag(stack, "damag", new NBTTagInt(0))).getInt() / WingsConfig.detachableDamage;
	}
	
	public boolean showDurabilityBar(ItemStack stack) {
		return getDurabilityForDisplay(stack) != 0;
	}

and what calls useDamage:

@SideOnly(Side.CLIENT)
	@SubscribeEvent
	public void check(TickEvent.PlayerTickEvent te) {
		try {if (WingsMod.getStateForPlayer(Minecraft.getMinecraft().player) != FlightState.HOVERING && WingsMod.tsc < 1 && Minecraft.getMinecraft().player.onGround) WingsMod.setFlightState(FlightState.NOT_FLYING);
		else if (WingsMod.tsc < 1 && Minecraft.getMinecraft().player.onGround) WingsMod.setFlightState(FlightState.GLIDING);;
		} catch(NullPointerException e) {}
		try {if (WingsMod.getStateForPlayer(te.player) == FlightState.HOVERING && !Minecraft.getMinecraft().player.capabilities.isFlying) Minecraft.getMinecraft().player.capabilities.isFlying = true;} catch(NullPointerException e) {}
		if (WingsMod.tsc > 0) WingsMod.tsc--;
		if (WingsMod.renderHoverVal < -0.5f || WingsMod.renderHoverVal > 0.5f) WingsMod.renderHoverDown = !WingsMod.renderHoverDown;
		if (WingsMod.renderHoverDown) {
			WingsMod.renderHoverVal = WingsMod.renderHoverVal - 0.05f;
		} else {
			WingsMod.renderHoverVal = WingsMod.renderHoverVal + 0.05f;
		}
		
		try {EntityPlayer p = Minecraft.getMinecraft().player;

		 //WingsCapability cap = player.getCapability(WingsCapability.Provider.WINGS_CAP, null);
		if (/*cap.hasWings() ||  */p.getItemStackFromSlot(EntityEquipmentSlot.CHEST).getItem() == WingsMod.wings && ItemDetatchableWings.isUsable(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST))) {
			KeyBinding incVelocity = Minecraft.getMinecraft().gameSettings.keyBindJump;
			
			if (WingsMod.getStateForPlayer(p) == FlightState.GLIDING && incVelocity.isKeyDown() && (p.motionX < 2.7) && (p.motionY < 2.7) && (p.motionZ < 2.7)) { // Fly Up/Increase Velocity
				float yaw = p.rotationYaw;
			    float pitch = p.rotationPitch;
			    float f = 0.02F;
			    double motionX = (double)(-MathHelper.sin(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionZ = (double)(MathHelper.cos(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionY = (double)(-MathHelper.sin((pitch) / 180.0F * (float)Math.PI) * f);
			    p.addVelocity(motionX, motionY, motionZ);
			    if (!p.getName().equals("GiantNuker")) {
				    p.getFoodStats().addExhaustion(WingsConfig.hunger_speedup);
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
			    }
			} else if (WingsMod.getStateForPlayer(p) == FlightState.NOT_FLYING && incVelocity.isKeyDown() && p.fallDistance > 3) {
				WingsMod.setFlightState(FlightState.GLIDING);
			} else if(WingsMod.getStateForPlayer(p) == FlightState.GLIDING && WingsKeyBinds.slow.isKeyDown() && (p.motionX > 0.1) && (p.motionY > 0.1) && (p.motionZ > 0.1)) { // Fly Down/Decrease Velocity
				float yaw = p.rotationYaw;
			    float pitch = p.rotationPitch;
			    float f = 0.04F;
			    double motionX = (double)(-MathHelper.sin(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionZ = (double)(MathHelper.cos(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionY = (double)(-MathHelper.sin((pitch) / 180.0F * (float)Math.PI) * f);
			    p.addVelocity(-motionX, -motionY, -motionZ);
			    if (!p.getName().equals("GiantNuker")) {
				    p.getFoodStats().addExhaustion(WingsConfig.hunger_slowdown);
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
			    }
			} else if(WingsKeyBinds.launch.isKeyDown() && p.onGround) {
				float yaw = p.rotationYaw; 
			    float pitch = p.rotationPitch;
			    float f = 0.8F;
			    double motionX = (double)(-MathHelper.sin(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionZ = (double)(MathHelper.cos(yaw / 180.0F * (float)Math.PI) * MathHelper.cos(pitch / 180.0F * (float)Math.PI) * f);
			    double motionY = (double)(-MathHelper.sin((pitch) / 180.0F * (float)Math.PI) * f);
			    WingsMod.setFlightState(FlightState.GLIDING);
			    p.addVelocity(motionX, motionY + 1F, motionZ);
			    if (!p.getName().equals("GiantNuker")) {
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
				    ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
				    p.getFoodStats().addExhaustion(WingsConfig.hunger_launch);
			    }
			} else if(WingsKeyBinds.hover.isPressed()) {
				WingsMod.setFlightState(WingsMod.getStateForPlayer(p) == FlightState.HOVERING ? FlightState.GLIDING : FlightState.HOVERING);
				if (WingsMod.getStateForPlayer(p) == FlightState.HOVERING && p.onGround) p.addVelocity(0, 0.5F, 0);
			}
			try {if (p.capabilities.isFlying && WingsMod.getStateForPlayer(p) != FlightState.HOVERING ) WingsMod.setFlightState(FlightState.NOT_FLYING);} catch (NullPointerException e) {}
			if (WingsMod.getStateForPlayer(p) == FlightState.GLIDING) if (!p.getName().equals("GiantNuker")) ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
			else if (WingsMod.getStateForPlayer(p) == FlightState.HOVERING) {
				if (!p.getName().equals("GiantNuker")) {
					ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
					ItemDetatchableWings.useDamage(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST));
					p.getFoodStats().addExhaustion(WingsConfig.hunger_hover);
				}
			}
			if (!ItemDetatchableWings.isUsable(p.getItemStackFromSlot(EntityEquipmentSlot.CHEST))) {
				WingsMod.setFlightState(FlightState.NOT_FLYING);
			}
		}} catch (NullPointerException e) {}
		
	}

Quote

September 6, 20178 yr

try {EntityPlayer p = Minecraft.getMinecraft().player;

You're doing everything on the client. The server then synchronizes everything and overwrites your changes.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

September 6, 20178 yr

Author

1 minute ago, Draco18s said:
try {EntityPlayer p = Minecraft.getMinecraft().player;
You're doing everything on the client. The server then synchronizes everything and overwrites your changes.

is there any way to do it without using packets though?

Quote

September 6, 20178 yr

Yes. Do whatever it is you're doing on the server thread.

If you can't, then no, you need packets.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

September 6, 20178 yr

Author

Just now, Draco18s said:

Yes. Do whatever it is you're doing on the server thread.

If you can't, then no, you need packets.

Oh well, I DON'T want to send a packet every time the player hits space so I will just damage based on activity(gliding, hovering) thanks anyway

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/60606-112custom-itemstack-nbt-not-saving/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to add my mob to another mod's biome in 1.20.1.

You can add mob spawns using Forge's Biome Modifiers feature. I won't go into details on how to use a data generator for them, but here's a simple example:
{ "type": "forge:add_spawns", // Required "biomes": "#namespace:biome_tag", // Accepts a biome id, [list of biome ids], or #namespace:biome_tag "spawners": { "type": "namespace:entity_type", // Type of mob to spawn "weight": 100, // int, spawn weighting "minCount": 1, // int, minimum pack size "maxCount": 4 // int, maximum pack size } }This JSON file would go somewhere like this: data/modid/forge/biome_modifier/your_biome_modifier.json

By Jonathing · 6 hours ago6 hr
How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted Yesterday at 12:07 AM1 day
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted Wednesday at 04:08 PM1 day
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · Wednesday at 10:34 AM1 day
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Wednesday at 04:14 AM2 days

There are no registered users currently online

Sign In

[1.12]Custom ItemStack NBT not saving

Featured Replies

Join the conversation

Posts

How to add my mob to another mod's biome in 1.20.1.

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Help with file conversion

Cobblemon invalid player data

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)