[1.10] Get drops when a BlockBreakHandler is used

[dakamojo]

My machine harvests the drop from a block without breaking it.  I'm using Block#getDrops to figure out what drops from each block.  However, some blocks implement a BlockBreakHandler (TechReborn for oreRuby is an example).  The drops from this are not getting return in getDrops.  How should I be getting the drops from a block as if it were broken?

[Draco18s]

BlockBreakHandler is not a Forge or vanilla class.

 

We need details.

[dakamojo]

My bad.  I guess the correct thing to say is a class that is registered for the HarvestDropsEvent event.

 

MinecraftForge.EVENT_BUS.register(new BlockBreakHandler());

 

public class BlockBreakHandler {


	@SubscribeEvent
	public void onBlockHarvest(BlockEvent.HarvestDropsEvent event) {
		if (!event.isSilkTouching() && OreDictUtils.isOre(event.getState(), "oreRuby")) {
			event.getDrops().add(ItemGems.getGemByName("red_garnet").copy());
		}
	}
}

 

[jabelar]

Events are fired across each mod in succession meaning that if you handle the event after another mod then you will have access to any changes it made to the drops for that event. A lot of people don't realize that you can change the priority of your subscribe so that it processes after or before other mods -- or at least has a better chance to (if other mod also sets the priority then it is a matter of which mod loads first I think so you would have to control the order the mods actually load).

 

So in your case you want it to load after. Plus you need to handle the case where the previous mod tries to cancel the event (which would normally prevent you from getting it) using the receive cancelled option.

 

Simply create an event handler annotated with @SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)

 

In that you can grab the event.getDrops() and do something with it.

Edited September 8, 2017 by jabelar

[dakamojo]

Let me clarify further.  I don't want to change what happens when the block breaks.  I don't want to break the block at all.  I want to know what would drop if the block were to break.

[Draco18s]

Event event = new BlockEvent.HarvestDropsEvent(...);
MinecraftForge.EVENT_BUS.fire(event);
event.getDrops()

 

[Draco18s]

1 hour ago, diesieben07 said:

A less accurate way is to call Block::getDrops and then fire the event manually, but I don't recommend that.

Whiiiich is what I suggested...

[Draco18s]

[Draco18s]

I was pointing out how to fire the event, not providing the entire solution

[dakamojo]

Quote

A less accurate way is to call Block::getDrops and then fire the event manually, but I don't recommend that.

 

This seems like something I can do rather than spawning the drops and capturing them.  What are the recommendations against this?

[jabelar]

5 hours ago, diesieben07 said:

What are you doing...

 

If you truly want to capture a block's drops, you will need to use internal mechanics. 

You will need to call Block::dropBlockAsItemWithChance. That however spawns entities directly into the world, so you need to use the captureDrops method in Block, which is protected, but can be accessed with some tricks.

 

I don't think you read the OP's problem carefully. He's not worried about vanilla blocks, he's handled that. He's worried about other mods that manipulate drops in the harvest event.

 

So I think you need to process the event further (as the methods you mentioned aren't relevant) after the other mod's manipulation.

 

I would basically find all the other mods' blocks in the registry and do a sort of test where I take a location in the world and during one tick successively place each block then break them and handle the harvest event with the low priority and receive canceled annotation I suggested.