Jump to content
View in the app

A better way to browse. Learn more.
Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.
Search the Forums BEFORE making a new post.
Currently supported: All versions

[Solved][1.12.1] Proper way to contribute pull requests to Forge

jabelar
in Modder Support

Featured Replies

Posted

So I figure I should give back to the Forge developer community who've made such an amazing thing from which I've derived years of a fun hobby of modding. So I have a very simple pull request idea to start with but I want to make sure that I go about the right process for the pull request. Since I've primarily been a solitary programmer, I haven't had to do a lot of working with other people who are collaborating; therefore I'm nervous that I might break things by creating a bad branch/fork/commit. So I have a few questions.  

 

1) Fork, branch or tree? I see some commits that seem to be on the main branch, but others are on a fork (which seems to be listed as a "tree"). Should I create a fork, a new branch, or just make commits to the main repository? Like should I be working in MinecraftForge/MinecraftForge or on jabelar/MinecraftForge?

 

2) How do you actually test it? Can you run it from the IDE or do you need to build it and apply it to a Minecraft installation? Once you clone the repository do you run some gradle commands to set up the workspace and make it more amenable to Eclipse? 

 

3) How do you make sure the IDE doesn't ripple a bunch of formatting through the entire codebase -- I have various "on save" features turned on in Eclipse to do things like update Javadoc, update licenses, and do various import cleanup, @Override cleanup, indent formatting and such. I wouldn't want to create a commit that has changes to every file in the repository, but I also want to keep Eclipse set up the way I like it for my other modding. Should I create a separate workspace or something to help manage this?

 

Sorry for the newbie questions...

Edited by jabelar

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

  • Quote

    https://github.com/MinecraftForge/MinecraftForge/wiki/If-you-want-to-contribute-to-Forge

    + I think it's better to create a new branch for the case when you make multiple PRs at once. Also, afaik it should be on new workspace.

    Edited by Abastro

    I. Stellarium for Minecraft: Configurable Universe for Minecraft! (WIP)

    II. Stellar Sky, Better Star Rendering&Sky Utility mod, had separated from Stellarium.

  • Quote

    • Join the conversation

    You can post now and register later. If you have an account, sign in now to post with your account.
    Note: Your post will require moderator approval before it will be visible.

    Guest
    Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
    Reply to this topic...
    Go to topic listing

    Important Information

    By using this site, you agree to our Terms of Use.

    I accept

    Configure browser push notifications
    Chrome (Android)
    1. Tap the lock icon next to the address bar.
    2. Tap Permissions → Notifications.
    3. Adjust your preference.
    Chrome (Desktop)
    1. Click the padlock icon in the address bar.
    2. Select Site settings.
    3. Find Notifications and adjust your preference.