[1.10]PlayerTickEvent only works on one client.

[oldcheese]

    @SubscribeEvent
    public void regenStats(TickEvent.PlayerTickEvent e) {
        if (!e.player.getEntityWorld().isRemote && e.phase == TickEvent.Phase.END) {
            if (ticks < 200) {
                ticks++;
            }
            if (ticks == 200) {
                final IBarHandler handler = getHandler(e.player);
                handler.addFatigue(25);
                ticks = 0;
                tinyRefresh(e.player); //updates client with server data.
            }
        }
    }

 

The loop is done kinda shittily at the moment, I originally had it doing different things at different ticks.

 

 

Anyway. The added fatigue only seems to process for the latest player to have logged in.

 

Is this a specific effect of this Event. It'd really be easier to use this event. My goal is to periodically 'regenerate' fatigue on every client. It doesn't have to be at once, but I do want there to be updates.

 

I guess I could use a ServerTickEvent or a WorldTickEvent, loop through all available players in the world and adjut their fatigue and refresh, which would work spotlessly. I'm just wondering what exactly is the deal with PlayerEvent. 

 

 

Edit: I've changed it succesfully to the code below: 

    @SubscribeEvent
    public void regenStats(TickEvent.WorldTickEvent e) {
        if(!e.world.isRemote && e.phase == TickEvent.Phase.END){
            if(ticks < 200){
                ticks++;
            }else{
                ticks = 0;
                List players = e.world.playerEntities;
                for(int i = 0; i < players.size(); i++){
                    EntityPlayer player = (EntityPlayer)players.get(i);
                    final IBarHandler handler = CustomDataHandlerBar.getHandler(player);
                    handler.addFatigue(25);
                    tinyRefresh(player);
                }
            }
        }
    }

 

but I'm still wondering why PlayerTicks don't work apart from the last player to join.

Edited September 27, 2017 by oldcheese
Added fixed code.

[Draco18s]

Well, you're clearly counting ticks as a global value, not a per-player value. This is bad.

Imagine you have 200 players logged in...

 

World ticks (time 1), all entities are ticked...

Player1 ticks, ticks is now 1.

Player2 ticks, ticks is now 2.

Player3 ticks, ticks is now 3.

Player4 ticks, ticks is now 4.

Player5 ticks, ticks is now 5.

Player6 ticks, ticks is now 6.

...

Player198 ticks, ticks is now 198.

Player199 ticks, ticks is now 199.

Player200 ticks, ticks is now 200, Player200 is fatigued.

World ticks (time 2), all entities are ticked...

Player1 ticks, ticks is now 1.

Player2 ticks, ticks is now 2...

Edited September 27, 2017 by Draco18s

[oldcheese]

Ah, that makes sense. I guess I could then assign a value to each player and tick them off, but at the same time it's a lot easier to just have one global value and use WorldTicks. It seems a little bit more efficient right now.

 

Thanks for the great answer. 

[Draco18s]

1 hour ago, oldcheese said:

but at the same time it's a lot easier to just have one global value and use WorldTicks. It seems a little bit more efficient right now.

If by "more efficient" you mean "as there are more players, everyone fatigues faster."

If you want to use world ticks, do world.getTotalWorldTime() % 200 == 0. The slight discrepancy of a player joining / leaving off-cycle will be pretty much unnoticeable.