Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

(SOLVED) [1.11.2] Names for Variant Blocks not Showing

saxon564

By saxon564
in Modder Support

 Share

Recommended Posts

saxon564 Diamond Finder

saxon564

Posted
Posted (edited)

I managed to get textures on my blocks working, and now I cannot get them to even show their name in my inventory and cannot find anything that is out of place. Does anyone have any ideas as to what the issue is?

 

All my code can be found here: https://github.com/saxon564/MoChickens

 

Specific classes for this are below:

 

BlockFeatherBlock.java

Spoiler 

				
			package com.saxon564.mochickens.blocks;				
			import java.util.List;				
			import com.saxon564.mochickens.MoChickens;
		import com.saxon564.mochickens.Reference;
		import com.saxon564.mochickens.enums.EnumHandler.*;				
			import net.minecraft.block.Block;
		import net.minecraft.block.SoundType;
		import net.minecraft.block.material.Material;
		import net.minecraft.block.properties.IProperty;
		import net.minecraft.block.properties.PropertyEnum;
		import net.minecraft.block.state.BlockStateContainer;
		import net.minecraft.block.state.IBlockState;
		import net.minecraft.creativetab.CreativeTabs;
		import net.minecraft.item.Item;
		import net.minecraft.item.ItemStack;
		import net.minecraft.util.ResourceLocation;
		import net.minecraftforge.fml.relauncher.Side;
		import net.minecraftforge.fml.relauncher.SideOnly;				
			public class BlockFeatherBlock extends Block {
		    
		    public static final PropertyEnum VARIANT = PropertyEnum.create("variant", EnumBlockTypes.class);
		    
		    public BlockFeatherBlock() {
		        
		        super(Material.ROCK);
		        setDefaultState(this.blockState.getBaseState().withProperty(VARIANT, EnumBlockTypes.CHICKEN));
		        setCreativeTab(MoChickens.moChickensTab);
		        this.setRegistryName(new ResourceLocation(Reference.MOD_ID, "feather_block"));
		        setUnlocalizedName("feather_block");
		        setSoundType(SoundType.CLOTH);
		    }
		    
		    public int damageDropped(IBlockState state)
		    {
		        return ((EnumBlockTypes)state.getValue(VARIANT)).getID();
		    }
		    
		    @SideOnly(Side.CLIENT)
		    public void getSubBlocks(Item itemIn, CreativeTabs tab, List list)
		    {
		        EnumBlockTypes[] aenumtype = EnumBlockTypes.values();
		        int i = aenumtype.length;				
			        for (int j = 0; j < i; ++j)
		        {
		            EnumBlockTypes enumtype = aenumtype[j];
		            list.add(new ItemStack(itemIn, 1, enumtype.getID()));
		        }
		    }
		    
		    public IBlockState getStateFromMeta(int meta)
		    {
		        return this.getDefaultState().withProperty(VARIANT, EnumBlockTypes.byID(meta));
		    }
		    public int getMetaFromState(IBlockState state)
		    {
		        return ((EnumBlockTypes)state.getValue(VARIANT)).getID();
		    }
		    
		    protected BlockStateContainer createBlockState()
		    {
		        return new BlockStateContainer(this, new IProperty[] {VARIANT});
		    }				
			}

 

ItemFeatherBlock.java

Spoiler 

				
			package com.saxon564.mochickens.items;				
			import java.util.List;				
			import com.saxon564.mochickens.Reference;
		import com.saxon564.mochickens.enums.EnumHandler.*;				
			import net.minecraft.block.Block;
		import net.minecraft.creativetab.CreativeTabs;
		import net.minecraft.item.Item;
		import net.minecraft.item.ItemBlock;
		import net.minecraft.item.ItemStack;
		import net.minecraft.util.ResourceLocation;
		import net.minecraftforge.fml.relauncher.Side;
		import net.minecraftforge.fml.relauncher.SideOnly;				
			public class ItemFeatherBlock extends ItemBlock {				
			    public ItemFeatherBlock(Block block) {
		        super(block);
		        this.setRegistryName(new ResourceLocation(Reference.MOD_ID, "feather_block"));
		        this.setMaxDamage(0);
		        this.setHasSubtypes(true);
		    }				
			    @Override
		    public int getMetadata(int metadata)
		    {
		      return metadata;
		    }
		    
		    @Override
		    public String getUnlocalizedName(ItemStack stack)
		    {
		        int metadata = stack.getMetadata();
		        int typeBits = metadata;
		        
		        EnumBlockTypes type = EnumBlockTypes.byID(typeBits);
		        return super.getUnlocalizedName(stack) + "." + type.getName();
		    }
		    
		    @SideOnly(Side.CLIENT)
		    public void getSubItems(Item item, CreativeTabs tab, List<ItemStack> subItems) {
		        for (EnumBlockTypes types : EnumBlockTypes.values()) {
		            
		            int typeBits = types.getID();
		            int metadata = typeBits;
		            ItemStack subItemStack = new ItemStack(item, 1, metadata);
		            subItems.add(subItemStack);
		            
		        }
		    }				
			}

 

ClientProxyMoChickens.java

Spoiler 

				
			package com.saxon564.mochickens.client;				
			import net.minecraft.client.Minecraft;				
			import net.minecraft.client.renderer.block.model.ModelBakery;
		import net.minecraft.client.renderer.block.statemap.StateMap;
		import net.minecraft.client.renderer.entity.RenderManager;
		import net.minecraft.item.Item;
		import net.minecraft.util.ResourceLocation;
		import net.minecraftforge.client.event.ModelRegistryEvent;
		import net.minecraftforge.client.model.ModelLoader;
		import net.minecraftforge.common.MinecraftForge;
		import net.minecraftforge.event.RegistryEvent;
		import net.minecraftforge.fml.client.registry.RenderingRegistry;
		import net.minecraftforge.fml.common.FMLCommonHandler;
		import net.minecraftforge.fml.common.Mod;
		import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;				
			import com.saxon564.mochickens.MoChickens;
		import com.saxon564.mochickens.Reference;
		import com.saxon564.mochickens.blocks.BlockChickenFireBlock;
		import com.saxon564.mochickens.entities.mobs.EntityBeefyChicken;
		import com.saxon564.mochickens.entities.mobs.EntityBlazingChicken;
		import com.saxon564.mochickens.entities.mobs.EntityClayChicken;
		import com.saxon564.mochickens.entities.mobs.EntityCoalChicken;
		import com.saxon564.mochickens.entities.mobs.EntityCookieChicken;
		import com.saxon564.mochickens.entities.mobs.EntityCreeperChicken;
		import com.saxon564.mochickens.entities.mobs.EntityDiamondChicken;
		import com.saxon564.mochickens.entities.mobs.EntityEmeraldChicken;
		import com.saxon564.mochickens.entities.mobs.EntityEnchantedChicken;
		import com.saxon564.mochickens.entities.mobs.EntityEnderChicken;
		import com.saxon564.mochickens.entities.mobs.EntityGiantChicken;
		import com.saxon564.mochickens.entities.mobs.EntityGlowingChicken;
		import com.saxon564.mochickens.entities.mobs.EntityGoldChicken;
		import com.saxon564.mochickens.entities.mobs.EntityIronChicken;
		import com.saxon564.mochickens.entities.mobs.EntityLapisChicken;
		import com.saxon564.mochickens.entities.mobs.EntityNuuwChicken;
		import com.saxon564.mochickens.entities.mobs.EntityQuartzChicken;
		import com.saxon564.mochickens.entities.mobs.EntityRainbowChicken;
		import com.saxon564.mochickens.entities.mobs.EntityRedstoneChicken;
		import com.saxon564.mochickens.entities.mobs.EntitySkeletonChicken;
		import com.saxon564.mochickens.entities.mobs.EntitySnowChicken;
		import com.saxon564.mochickens.entities.mobs.models.ModelBeefyChicken;
		import com.saxon564.mochickens.entities.mobs.models.ModelCChicken;
		import com.saxon564.mochickens.entities.mobs.models.ModelEnderChicken;
		import com.saxon564.mochickens.entities.mobs.models.ModelGiantChicken;
		import com.saxon564.mochickens.entities.mobs.models.ModelGoldChicken;
		import com.saxon564.mochickens.entities.mobs.models.ModelRedstoneChicken;
		import com.saxon564.mochickens.entities.mobs.models.ModelSkeletonChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderBeefyChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderBlazingChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderClayChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderCoalChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderCookieChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderCreeperChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderDiamondChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderEmeraldChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderEnchantedChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderEnderChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderGiantChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderGlowingChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderGoldChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderIronChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderLapisChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderNuuwChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderQuartzChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderRainbowChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderRedstoneChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderSkeletonChicken;
		import com.saxon564.mochickens.entities.mobs.renders.RenderSnowChicken;
		import com.saxon564.mochickens.enums.EnumHandler.*;
		import com.saxon564.mochickens.events.FireEventHandlerClient;
		import com.saxon564.mochickens.events.FireEventHandlerServer;
		import com.saxon564.mochickens.proxies.CommonProxyMoChickens;
		import com.saxon564.mochickens.registers.RegisterHelper;				
			@Mod.EventBusSubscriber
		public class ClientProxyMoChickens extends CommonProxyMoChickens
		{
		    private RenderManager manager;
		    
		    public void registerRenders()
		    {
		        chickens();
		    }
		    
		    public void modelExceptions() {
		        ModelLoader.setCustomStateMapper(MoChickens.chicken_fire, (new StateMap.Builder()).ignore(BlockChickenFireBlock.AGE).build());
		    }
		    
		    public void eventHandlers() {
		        MinecraftForge.EVENT_BUS.register(new FireEventHandlerClient());
		    }
		    
		    @SubscribeEvent
		    public static void items(ModelRegistryEvent event) {
		        for (EnumResourceTypes types : EnumResourceTypes.values()) {
		            String itemModelName = types.getName();
		            int metadata = types.getID();
		            
		            RegisterHelper.registerItemRenders(MoChickens.disc_stick, metadata, itemModelName + "_stick");
		            RegisterHelper.registerItemRenders(MoChickens.chicken_feather, metadata, itemModelName + "_feather");
		        }
		        
		        for (EnumBlockTypes types : EnumBlockTypes.values()) {
		            String itemModelName = types.getName();
		            int metadata = types.getID();
		            
		            RegisterHelper.registerItemRenders(Item.getItemFromBlock(MoChickens.feather_block), metadata, itemModelName + "_feather_block");
		        }
		        
		        //Items
		        RegisterHelper.registerItemRenders(MoChickens.inner_taming_disc, 0, "inner_taming_disc");
		        RegisterHelper.registerItemRenders(MoChickens.taming_disc, 0, "taming_disc");
		        RegisterHelper.registerItemRenders(MoChickens.random_egg, 0, "random_egg");
		        RegisterHelper.registerItemRenders(MoChickens.chicken_steel, 0, "chicken_steel");
		        
		        //Blocks
		        RegisterHelper.registerItemRenders(Item.getItemFromBlock(MoChickens.coal_gem_ore), 0, "coal_gem_ore");
		        
		    }				
			    private void chickens() {
		        RenderingRegistry.registerEntityRenderingHandler(EntityDiamondChicken.class, new RenderDiamondChicken(manager, new ModelEnderChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityCoalChicken.class, new RenderCoalChicken(manager, new ModelCChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityIronChicken.class, new RenderIronChicken(manager, new ModelCChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityGoldChicken.class, new RenderGoldChicken(manager, new ModelGoldChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityLapisChicken.class, new RenderLapisChicken(manager, new ModelGoldChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityRedstoneChicken.class, new RenderRedstoneChicken(manager, new ModelRedstoneChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityEmeraldChicken.class, new RenderEmeraldChicken(manager, new ModelEnderChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityGiantChicken.class, new RenderGiantChicken(manager, new ModelGiantChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityQuartzChicken.class, new RenderQuartzChicken(manager, new ModelCChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntitySkeletonChicken.class, new RenderSkeletonChicken(manager, new ModelSkeletonChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityEnderChicken.class, new RenderEnderChicken(manager, new ModelEnderChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityCreeperChicken.class, new RenderCreeperChicken(manager, new ModelCChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityCookieChicken.class, new RenderCookieChicken(manager, new ModelCChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntitySnowChicken.class, new RenderSnowChicken(manager, new ModelCChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityClayChicken.class, new RenderClayChicken(manager, new ModelCChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityRainbowChicken.class, new RenderRainbowChicken(manager, new ModelCChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityBeefyChicken.class, new RenderBeefyChicken(manager, new ModelBeefyChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityGlowingChicken.class, new RenderGlowingChicken(manager, new ModelEnderChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityBlazingChicken.class, new RenderBlazingChicken(manager, new ModelEnderChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityEnchantedChicken.class, new RenderEnchantedChicken(manager, new ModelEnderChicken(), 0.3F));
		        RenderingRegistry.registerEntityRenderingHandler(EntityNuuwChicken.class, new RenderNuuwChicken(manager, new ModelEnderChicken(), 0.3F));
		    }
		}

 

RegisterHelper.java

Spoiler 

				
			package com.saxon564.mochickens.registers;				
			import com.saxon564.mochickens.Reference;
		import com.saxon564.mochickens.enums.EnumHandler.EnumResourceTypes;				
			import net.minecraft.block.Block;
		import net.minecraft.client.Minecraft;
		import net.minecraft.client.renderer.block.model.ModelResourceLocation;
		import net.minecraft.item.Item;
		import net.minecraft.util.ResourceLocation;
		import net.minecraft.world.DimensionType;
		import net.minecraft.world.biome.Biome;
		import net.minecraftforge.client.event.ModelRegistryEvent;
		import net.minecraftforge.client.model.ModelLoader;
		import net.minecraftforge.common.BiomeManager;
		import net.minecraftforge.common.DimensionManager;
		import net.minecraftforge.event.RegistryEvent;
		import net.minecraftforge.fml.common.registry.GameRegistry;				
			public class RegisterHelper {				
			    public static void registerBlock(RegistryEvent.Register<Block> event, Block block) {
		        event.getRegistry().register(block);
		    }
		    
		    public static void registerItem (RegistryEvent.Register<Item> event, Item item) {
		        event.getRegistry().register(item);
		    }
		    
		    public static void registerDimension(int id, Class provider, boolean loaded) {
		        DimensionType.register("chicken", "_chicken", id, provider, loaded);
		        DimensionManager.registerDimension(id, DimensionType.valueOf("chicken"));
		    }
		    
		    public static void registerBiome(Biome biome, boolean canSpawn) {
		        BiomeManager.addSpawnBiome(biome);
		        registerVillageBiome(biome, canSpawn);
		    }
		    
		    public static void registerVillageBiome(Biome biome, boolean canSpawn) {
		        BiomeManager.addVillageBiome(biome, canSpawn);
		    }
		    
		    public static void registerItemRenders(Item item, int meta, String name) {
		        ModelLoader.setCustomModelResourceLocation(item, meta, new ModelResourceLocation(Reference.MOD_ID + ":" + name, "inventory"));    
		    }
		    
		}

 

Lang file

Spoiler


tile.feather_block.chicken.name=Feather Block
tile.feather_block.coal.name=Coal Feather Block
tile.feather_block.iron.name=Iron Feather Block
tile.feather_block.gold.name=Gold Feather Block
tile.feather_block.lapis.name=Lapis Feather Block
tile.feather_block.redstone.name=Redstone Feather Block
tile.feather_block.diamond.name=Diamond Feather Block
tile.feather_block.emerald.name=Emerald Feather Block
tile.feather_block.quartz.name=Quartz Feather Block

 

 

 

 

Edited by saxon564
aw_wolfe Stone Miner

aw_wolfe

Posted
Posted

first glance is the language file might need to be ( use colon) as that is how you define your resourcelocation

entity.mochickens:DiamondChicken.name=Diamond Chicken

instead of

entity.mochickens.DiamondChicken.name=Diamond Chicken

 

saxon564 Diamond Finder

saxon564

Posted
  • Author
Posted
7 minutes ago, aw_wolfe said:

first glance is the language file might need to be ( use colon) as that is how you define your resourcelocation

entity.mochickens:DiamondChicken.name=Diamond Chicken

instead of

entity.mochickens.DiamondChicken.name=Diamond Chicken

 

That one has nothing to do with this issue. I have removed all but the lines that are related to this issue.

Draco18s Reality Controller

Draco18s

Posted
Posted

The colon isn't the problem, this is:

https://github.com/saxon564/MoChickens/tree/master/src/main/resources/assets/mochickens/lang

Your lang file is improperly named. Starting with 1.11, all resources must be all lower case. That is, en_us.lang, not en_US.lang.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

saxon564 Diamond Finder

saxon564

Posted
  • Author
Posted

Really? All my items are still being named. I just tried it though, and I still only get tile.feather_block.name. Also with that change, my items now no longer show their names.

Draco18s Reality Controller

Draco18s

Posted
Posted
Just now, saxon564 said:

Really? All my items are still being named. I just tried it though, and I still only get tile.feather_block.name. Also with that change, my items now no longer show their names.

There's a pack.mcmeta setting that can force things back to v2 instead of v3.

Ignore that for now, you have a file that works, its just the one block that's messed up.

 

Best bet is to take what's shown in the game (what you see that's wrong) and put that into your lang file.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

saxon564 Diamond Finder

saxon564

Posted
  • Author
Posted

This block has 9 variants that each need to have different names and for some reason they are all using the tile.feather_block.name and are getting clumped together when in the inventory.

Draco18s Reality Controller

Draco18s

Posted
Posted (edited)

Where do you actually register your blocks and items? I can't find it in your repo.

Found it.

https://github.com/saxon564/MoChickens/blob/master/src/main/java/com/saxon564/mochickens/registers/RegisterItems.java#L36

Take a REALLY GOOD LOOK at that line.

Tell me where, exactly, you're using ItemFeatherBlock

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Draco18s Reality Controller

Draco18s

Posted
Posted
4 minutes ago, Draco18s said:

Found it.

https://github.com/saxon564/MoChickens/blob/master/src/main/java/com/saxon564/mochickens/registers/RegisterItems.java#L36

Take a REALLY GOOD LOOK at that line.

Tell me where, exactly, you're using ItemFeatherBlock

 

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

saxon564 Diamond Finder

saxon564

Posted
  • Author
Posted

Ahh! Now I feel stupid for that one! I can almost always trust you to get me in the right direction Draco! Thanks so much!

 

For anyone looking at this later. I did not register my ItemBlock and was instead registering the block as an 'instance' (I'm sure that is not actually the right word, but I'm not sure which word is) of ItemBlock.

Draco18s Reality Controller

Draco18s

Posted
Posted
1 minute ago, saxon564 said:

For anyone looking at this later. I did not register my ItemBlock and was instead registering the block as an 'instance' (I'm sure that is not actually the right word, but I'm not sure which word is) of ItemBlock.

You were creating a standard ItemBlock rather than your custom ItemBlock subclass.

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept