Ooky spooky ghost itemstacks

[TastesLikeBleach]

I made an event where you rightclick with a tool on a crop block and it changes the block back to having an age of 0, as well as spawning in an itemstack. However when the event is triggered it spawns two itemstacks, one of which you can't interact with.

Also instead of damaging the tool used it deletes it.

 

https://pastebin.com/hGxcC1qJ -> the event class

[Draco18s]

 

[Matryoshika]

Quote

event.getEntityPlayer().getHeldItemMainhand().shrink(1);

You're not "damaging" it here, you are actively removing one item from the stack.
If this is a non-stacking item, well... 1-1=?

Use ItemStack::setItemDamage(stack::getItemDamage() + x) to set damage.

 

Furthermore, if this is your own item, you should Override Item::onItemUse instead of making an event-handler

Edited November 13, 2017 by Matryoshika

[TastesLikeBleach]

On 11/12/2017 at 3:14 PM, Draco18s said:

 

I really am sorry to bother you, but I don't know how to apply the given information in code, an example, like a section of documentation, or code snippet would be appreciated.

[Matryoshika]

Use world.isRemote to see on what logical side you are on.

[TastesLikeBleach]

1 hour ago, Matryoshika said:

Use world.isRemote to see on what logical side you are on.

I understand that if a world is in single player then worldIn.isRemote is true, if it is a server the value is false, my problem is as follows...

if(WorldIn.isRemote){

/* what

do 

i 

do 

here? */

}

[desht]

If world.isRemote, then you do absolutely nothing.  The client should never be manipulating items in the player's inventory; make your changes on the server and Minecraft will (usually) handle sync'ing those changes to the client(s) for you.

 

Note that this applies just as much to a "single-player" world as to you're logged into a remote server.  Even a single-player instance has a local internal server.

[TastesLikeBleach]

32 minutes ago, desht said:

If world.isRemote, then you do absolutely nothing.  The client should never be manipulating items in the player's inventory; make your changes on the server and Minecraft will (usually) handle sync'ing those changes to the client(s) for you.

 

Note that this applies just as much to a "single-player" world as to you're logged into a remote server.  Even a single-player instance has a local internal server.

So then in conclusion the fix would be

if(World.isRemote != true){

Word.spawnEntity(item);

}

[TastesLikeBleach]

9 minutes ago, TastesLikeBleach said:

So then in conclusion the fix would be

if(World.isRemote != true){

Word.spawnEntity(item);

}

yeah it worked

[Draco18s]

4 hours ago, TastesLikeBleach said:

if(World.isRemote != true){

if(!world.isRemote) {

 

Also, world not World. World is a class name and isRemote is not static.

[TastesLikeBleach]

51 minutes ago, Draco18s said:

if(!world.isRemote) {

 

Also, world not World. World is a class name and isRemote is not static.

Good to know, also i was using the class name as a placeholder.