Jump to content

Recommended Posts

Posted (edited)

I believe you have to override the onBlockDestroyed method and destroy the 8 blocks around the one that the hammer itself broke. You need to know somehow what side did the player break this block from to determine in which direction you going to destroy the other 8. Back in 1.8.9 MovingObjectPosition was one way to do it. Not sure on 1.10.2 what works.
 

Edited by American2050
Posted

Call Item::rayTrace to gain access to a RayTraceResult, which can give you a block, and specifically the side of the block. Be sure to checkRayTraceResult#Type though. It might be nothing "MISS" or an entity "ENTITY".

 

I would call said rayTrace method in an override of Item::onBlockDestroyed, and verify that the result's blockstate equals the blockstate being destroyed.

 

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted

No.
This forum is for helping people with their own code.
Giving out copy-paste-code is not helpful, neither to you, who won't learn what the actual code does, nor us, who'd have to write detailed tutorials on where, how, why and when the code does whatever it does.

I've told you how to gain access to a block that the player is looking at, and how to get the specific side as well (Item::rayTrace).
Now try and use it.
We can help you along the way. We will not send you off with a free ticket.

  • Like 1

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted

ok here is my code : 

public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };
        BlockPos[] blockPoses;
        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {
          BlockPos[] blockPoses;
          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {
            BlockPos[] blockPoses;
            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              BlockPos[] blockPoses;
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {
                BlockPos[] blockPoses;
                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {
                  BlockPos[] blockPoses;
                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        BlockPos[] blockPoses;
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
}

 

Posted

I'm sorry, but... and?
Your code doesn't actually break any blocks...
It just ends with "i have these blocks."

 

You are validating the block's materials, but nothing else... of course the blocks won't break.

At the end of your for-each blockpos loop, call ForgeHooks#canHarvestBlock (to make sure the player can break these blocks (in the case of protection plugins etc)) and if they can, call World::destroyBlock with true to make sure the block's drops actually drop.

 

 

 

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted

it still not working 

package fr.darkprod.archymod.items;

import java.util.Iterator;
import java.util.List;

import fr.darkprod.archymod.ArchyMod;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public class ItemHammer
  extends ItemPickaxe
{
  public long time = System.currentTimeMillis();
  protected static final Material[] MATERIALS = { Material.ROCK, Material.IRON, Material.ICE, Material.GLASS, Material.PISTON, Material.ANVIL, Material.SNOW, Material.CRAFTED_SNOW, Material.CLAY };
  
  public ItemHammer(String name,Item.ToolMaterial material)
  {
    super(material);
    setCreativeTab(ArchyMod.ArchyMod);
    setRegistryName(name);
    setUnlocalizedName(name);
  }
  
  public int getItemEnchantability()
  {
    return 0;
  }
  
  public int getItemEnchantability(ItemStack stack)
  {
    return 0;
  }
  
  public boolean isBookEnchantable(ItemStack stack, ItemStack book)
  {
    return false;
  }
  
  public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
  {
    return false;
  }
  
  public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected)
  {
    if ((!worldIn.isRemote) && 
      ((entityIn instanceof EntityPlayer)))
    {
      EntityPlayer entityPlayer = (EntityPlayer)entityIn;
      if (entityPlayer.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND) == null) {
        return;
      }
    }
  }
  
  public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      BlockPos[] blockPoses;
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };

        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {

          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {

            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {

                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {

                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
  }
  public static boolean canHarvestBlock(Block block, EntityPlayer player, IBlockAccess world,BlockPos pos) {
	return true;
	  
  }
}

 

Posted (edited)

That is not what I said.
When someone states "call method x" you do not override it as you did here, and especially not in a class that is not an instance of the class using the original method...

What you did is re-create a method that blindly says "yes" whenever it is asked.
Calling a method means you actually call the method. Here that means running if(ForgeHooks.canHarvestBlock(Block, Player, World, BlockPos)){//run code here if player can break this block}

Edited by Matryoshika

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted

like this 

package fr.darkprod.archymod.items;

import java.util.Iterator;
import java.util.List;

import fr.darkprod.archymod.ArchyMod;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.common.ForgeHooks;

public class ItemHammer
  extends ItemPickaxe
{
  public long time = System.currentTimeMillis();
  protected static final Material[] MATERIALS = { Material.ROCK, Material.IRON, Material.ICE, Material.GLASS, Material.PISTON, Material.ANVIL, Material.SNOW, Material.CRAFTED_SNOW, Material.CLAY };
  
  public ItemHammer(String name,Item.ToolMaterial material)
  {
    super(material);
    setCreativeTab(ArchyMod.ArchyMod);
    setRegistryName(name);
    setUnlocalizedName(name);
  }
  
  public int getItemEnchantability()
  {
    return 0;
  }
  
  public int getItemEnchantability(ItemStack stack)
  {
    return 0;
  }
  
  public boolean isBookEnchantable(ItemStack stack, ItemStack book)
  {
    return false;
  }
  
  public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
  {
    return false;
  }
  
  public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected)
  {
    if ((!worldIn.isRemote) && 
      ((entityIn instanceof EntityPlayer)))
    {
      EntityPlayer entityPlayer = (EntityPlayer)entityIn;
      if (entityPlayer.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND) == null) {
        return;
      }
    }
  }
  
  public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
	
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      BlockPos[] blockPoses;
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };

        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {

          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {

            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {

                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {

                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
        if(ForgeHooks.canHarvestBlock(null, player, worldIn, pos)){
        	if(player.capabilities.isCreativeMode) {
        		
        	}
        }
        
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
    
  }
}

 

Posted

Yes, and no.
Never use null unless you are absolutely sure that it is harmless. Most of the time, using null with cause nullpointerexceptions, aka crash the game.
Use World::getBlockState::getBlock to get the block.

As I mentioned in my previous post, ForgeHooks::canHarvestBlock checks for you if the player CAN break the block. If it returns true, use World::breakBlock with true as the second argument to actually break the block.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted (edited)

ok thx a lot my code is good now?

package fr.darkprod.archymod.items;

import java.util.Iterator;
import java.util.List;

import fr.darkprod.archymod.ArchyMod;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraft.world.WorldEntitySpawner;
import net.minecraftforge.common.ForgeHooks;

public class ItemHammer
  extends ItemPickaxe
{
  public long time = System.currentTimeMillis();
  protected static final Material[] MATERIALS = { Material.ROCK, Material.IRON, Material.ICE, Material.GLASS, Material.PISTON, Material.ANVIL, Material.SNOW, Material.CRAFTED_SNOW, Material.CLAY };
  
  public ItemHammer(String name,Item.ToolMaterial material)
  {
    super(material);
    setCreativeTab(ArchyMod.ArchyMod);
    setRegistryName(name);
    setUnlocalizedName(name);
  }
  
  public int getItemEnchantability()
  {
    return 0;
  }
  
  public int getItemEnchantability(ItemStack stack)
  {
    return 0;
  }
  
  public boolean isBookEnchantable(ItemStack stack, ItemStack book)
  {
    return false;
  }
  
  public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
  {
    return false;
  }
  
  public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected)
  {
    if ((!worldIn.isRemote) && 
      ((entityIn instanceof EntityPlayer)))
    {
      EntityPlayer entityPlayer = (EntityPlayer)entityIn;
      if (entityPlayer.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND) == null) {
        return;
      }
    }
  }
  
  public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
	
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      BlockPos[] blockPoses;
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };

        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {

          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {

            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {

                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {

                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
        if(ForgeHooks.canHarvestBlock(worldIn.getBlockState(pos).getBlock(), player, worldIn, pos)){
        	if(player.canHarvestBlock(state)) {
        		worldIn.destroyBlock(pos, true);
        	}
        }
        
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
    
  }
}

edit : i tried it the hammer break blocks but he doesn't break blocks in 3x3x1

Edited by DarkProd02
tried it
Posted
1 hour ago, DarkProd02 said:

ok thx a lot my code is good now?


package fr.darkprod.archymod.items;

import java.util.Iterator;
import java.util.List;

import fr.darkprod.archymod.ArchyMod;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.inventory.EntityEquipmentSlot;
import net.minecraft.item.Item;
import net.minecraft.item.Item.ToolMaterial;
import net.minecraft.item.ItemPickaxe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraft.world.WorldEntitySpawner;
import net.minecraftforge.common.ForgeHooks;

public class ItemHammer
  extends ItemPickaxe
{
  public long time = System.currentTimeMillis();
  protected static final Material[] MATERIALS = { Material.ROCK, Material.IRON, Material.ICE, Material.GLASS, Material.PISTON, Material.ANVIL, Material.SNOW, Material.CRAFTED_SNOW, Material.CLAY };
  
  public ItemHammer(String name,Item.ToolMaterial material)
  {
    super(material);
    setCreativeTab(ArchyMod.ArchyMod);
    setRegistryName(name);
    setUnlocalizedName(name);
  }
  
  public int getItemEnchantability()
  {
    return 0;
  }
  
  public int getItemEnchantability(ItemStack stack)
  {
    return 0;
  }
  
  public boolean isBookEnchantable(ItemStack stack, ItemStack book)
  {
    return false;
  }
  
  public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
  {
    return false;
  }
  
  public void onUpdate(ItemStack stack, World worldIn, Entity entityIn, int itemSlot, boolean isSelected)
  {
    if ((!worldIn.isRemote) && 
      ((entityIn instanceof EntityPlayer)))
    {
      EntityPlayer entityPlayer = (EntityPlayer)entityIn;
      if (entityPlayer.getItemStackFromSlot(EntityEquipmentSlot.MAINHAND) == null) {
        return;
      }
    }
  }
  
  public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
  {
	
    if ((!worldIn.isRemote) && 
      ((entityLiving instanceof EntityPlayer)))
    {
      EntityPlayer player = (EntityPlayer)entityLiving;
      
      RayTraceResult raytraceresult = rayTrace(player.getEntityWorld(), player, true);
      BlockPos[] blockPoses;
      if (raytraceresult != null)
      {
        BlockPos[] blockPosesNS = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY() - 1, pos.getZ()) };
        
        BlockPos[] blockPosesEW = { new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() + 1, pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY() - 1, pos.getZ() - 1) };
        
        BlockPos[] blockPosesUD = { new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() + 1, pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX(), pos.getY(), pos.getZ()), new BlockPos(pos.getX(), pos.getY(), pos.getZ() - 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ()), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() + 1), new BlockPos(pos.getX() - 1, pos.getY(), pos.getZ() - 1) };

        if (raytraceresult.sideHit.equals(EnumFacing.NORTH))
        {
          blockPoses = blockPosesNS;
        }
        else
        {

          if (raytraceresult.sideHit.equals(EnumFacing.SOUTH))
          {
            blockPoses = blockPosesNS;
          }
          else
          {

            if (raytraceresult.sideHit.equals(EnumFacing.EAST))
            {
              blockPoses = blockPosesEW;
            }
            else
            {
              if (raytraceresult.sideHit.equals(EnumFacing.WEST))
              {
                blockPoses = blockPosesEW;
              }
              else
              {

                if (raytraceresult.sideHit.equals(EnumFacing.UP))
                {
                  blockPoses = blockPosesUD;
                }
                else
                {

                  if (raytraceresult.sideHit.equals(EnumFacing.DOWN)) {
                    blockPoses = blockPosesUD;
                  } else {
                    return super.onBlockDestroyed(stack, worldIn, state, pos, entityLiving);
                  }
                }
              }
            }
          }
        }
        for (BlockPos blockPos : blockPoses)
        {
          Boolean isvalidate = Boolean.valueOf(false);
          
          int x = blockPos.getX();
          int y = blockPos.getY();
          int z = blockPos.getZ();
          for (Material material : MATERIALS) {
            if (worldIn.getBlockState(blockPos).getMaterial().equals(material)) {
              isvalidate = Boolean.valueOf(true);
            }
          }
          if (worldIn.getBlockState(blockPos).getBlock().equals(Blocks.BEDROCK)) {
            isvalidate = Boolean.valueOf(false);
          }
        }
        if(ForgeHooks.canHarvestBlock(worldIn.getBlockState(pos).getBlock(), player, worldIn, pos)){
        	if(player.canHarvestBlock(state)) {
        		worldIn.destroyBlock(pos, true);
        	}
        }
        
      }
    }
    stack.damageItem(1, entityLiving);
    return false;
    
  }
}

edit : i tried it the hammer break blocks but he doesn't break blocks in 3x3x1

Why you have the onUpdate ?

Can you do a Switch with the result of the raytrace instead of those if else statements? That will probably make things cleaner.

 

Also I think it's not breaking blocks, because when you actually call the worldIn.detroyBlock you passing "pos" and not "blockPos" that you using on the for loop.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.